mirror of
https://github.com/tailscale/tailscale.git
synced 2024-11-29 04:55:31 +00:00
ed1ac799c8
Updates tailscale/tailscale#1634 Updates tailscale/tailscale#13265 Captive portal detection uses a custom `net.Dialer` in its `http.Client`. This custom Dialer ensures that the socket is bound specifically to the Wi-Fi interface. This is crucial because without it, if any default routes are set, the outgoing requests for detecting a captive portal would bypass Wi-Fi and go through the default route instead. The Dialer did not have a Timeout property configured, so the default system timeout was applied. This caused issues in #13265, where we attempted to make captive portal detection requests over an IPsec interface used for Wi-Fi Calling. The call to `connect()` would fail and remain blocked until the system timeout (approximately 1 minute) was reached. In #13598, I simply excluded the IPsec interface from captive portal detection. This was a quick and safe mitigation for the issue. This PR is a follow-up to make the process more robust, by setting a 3 seconds timeout on any connection establishment on any interface (this is the same timeout interval we were already setting on the HTTP client). Signed-off-by: Andrea Gottardo <andrea@gottardo.me> |
||
|---|---|---|
| .. | ||
| art | ||
| captivedetection | ||
| connstats | ||
| dns | ||
| dnscache | ||
| dnsfallback | ||
| flowtrack | ||
| ipset | ||
| ktimeout | ||
| memnet | ||
| netaddr | ||
| netcheck | ||
| neterror | ||
| netkernelconf | ||
| netknob | ||
| netmon | ||
| netns | ||
| netstat | ||
| netutil | ||
| packet | ||
| ping | ||
| portmapper | ||
| proxymux | ||
| routetable | ||
| socks5 | ||
| sockstats | ||
| speedtest | ||
| stun | ||
| stunserver | ||
| tcpinfo | ||
| tlsdial | ||
| tsaddr | ||
| tsdial | ||
| tshttpproxy | ||
| tstun | ||
| wsconn | ||