mirror of
https://github.com/tailscale/tailscale.git
synced 2024-12-04 23:45:34 +00:00
9ab70212f4
This changes the ACLTestError type to reuse the existing/identical types from the ACL implementation, to avoid issues in the future if the two types fall out of sync. Updates #8645 Signed-off-by: Jenny Zhang <jz@tailscale.com>
56 lines
1.5 KiB
Go
56 lines
1.5 KiB
Go
// Copyright (c) Tailscale Inc & AUTHORS
|
|
// SPDX-License-Identifier: BSD-3-Clause
|
|
package main
|
|
|
|
import (
|
|
"encoding/json"
|
|
"strings"
|
|
"testing"
|
|
|
|
"tailscale.com/client/tailscale"
|
|
)
|
|
|
|
func TestEmbeddedTypeUnmarshal(t *testing.T) {
|
|
var gitopsErr ACLGitopsTestError
|
|
gitopsErr.Message = "gitops response error"
|
|
gitopsErr.Data = []tailscale.ACLTestFailureSummary{
|
|
{
|
|
User: "GitopsError",
|
|
Errors: []string{"this was initially created as a gitops error"},
|
|
},
|
|
}
|
|
|
|
var aclTestErr tailscale.ACLTestError
|
|
aclTestErr.Message = "native ACL response error"
|
|
aclTestErr.Data = []tailscale.ACLTestFailureSummary{
|
|
{
|
|
User: "ACLError",
|
|
Errors: []string{"this was initially created as an ACL error"},
|
|
},
|
|
}
|
|
|
|
t.Run("unmarshal gitops type from acl type", func(t *testing.T) {
|
|
b, _ := json.Marshal(aclTestErr)
|
|
var e ACLGitopsTestError
|
|
err := json.Unmarshal(b, &e)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !strings.Contains(e.Error(), "For user ACLError") { // the gitops error prints out the user, the acl error doesn't
|
|
t.Fatalf("user heading for 'ACLError' not found in gitops error: %v", e.Error())
|
|
}
|
|
})
|
|
t.Run("unmarshal acl type from gitops type", func(t *testing.T) {
|
|
b, _ := json.Marshal(gitopsErr)
|
|
var e tailscale.ACLTestError
|
|
err := json.Unmarshal(b, &e)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
expectedErr := `Status: 0, Message: "gitops response error", Data: [{User:GitopsError Errors:[this was initially created as a gitops error] Warnings:[]}]`
|
|
if e.Error() != expectedErr {
|
|
t.Fatalf("got %v\n, expected %v", e.Error(), expectedErr)
|
|
}
|
|
})
|
|
}
|