Avoid unnecessarily allocating coords slice if it's unchanged.

This commit is contained in:
cathugger 2018-07-30 13:44:46 +00:00
parent 67b8a7a53d
commit b4db89ea9d
No known key found for this signature in database
GPG Key ID: 9BADDA2DAF6F01A8

View File

@ -4,7 +4,10 @@ package yggdrasil
// It's responsible for keeping track of open sessions to other nodes // It's responsible for keeping track of open sessions to other nodes
// The session information consists of crypto keys and coords // The session information consists of crypto keys and coords
import "time" import (
"bytes"
"time"
)
// All the information we know about an active session. // All the information we know about an active session.
// This includes coords, permanent and ephemeral keys, handles and nonces, various sorts of timing information for timeout and maintenance, and some metadata for the admin API. // This includes coords, permanent and ephemeral keys, handles and nonces, various sorts of timing information for timeout and maintenance, and some metadata for the admin API.
@ -72,8 +75,10 @@ func (s *sessionInfo) update(p *sessionPing) bool {
if p.MTU >= 1280 || p.MTU == 0 { if p.MTU >= 1280 || p.MTU == 0 {
s.theirMTU = p.MTU s.theirMTU = p.MTU
} }
if !bytes.Equal(s.coords, p.Coords) {
// allocate enough space for additional coords // allocate enough space for additional coords
s.coords = append(make([]byte, 0, len(p.Coords)+11), p.Coords...) s.coords = append(make([]byte, 0, len(p.Coords)+11), p.Coords...)
}
now := time.Now() now := time.Now()
s.time = now s.time = now
s.tstamp = p.Tstamp s.tstamp = p.Tstamp