TheArchive/yggdrasil-go
1
0
Fork 0
mirror of https://github.com/yggdrasil-network/yggdrasil-go.git synced 2024-11-23 18:15:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

reduce time spent with a mutex held in sessionInfo.recvWorker

Browse Source
This commit is contained in:
Arceliar 2019-08-03 22:47:10 -05:00
parent 099bd3ae1e
commit b9987b4fdc
1 changed files with 24 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
src/yggdrasil/session.go
View File

@ -449,36 +449,42 @@ func (sinfo *sessionInfo) recvWorker() {
case p := <-sinfo.fromRouter: case p := <-sinfo.fromRouter:
var bs []byte var bs []byte
var err error var err error
var k crypto.BoxSharedKey
sessionFunc := func() { sessionFunc := func() {
defer util.PutBytes(p.Payload)
// If the nonce is bad then drop the packet and return an error
if !sinfo.nonceIsOK(&p.Nonce) { if !sinfo.nonceIsOK(&p.Nonce) {
err = ConnError{errors.New("packet dropped due to invalid nonce"), false, true, false, 0} err = ConnError{errors.New("packet dropped due to invalid nonce"), false, true, false, 0}
return return
} }
// Decrypt the packet k = sinfo.sharedSesKey
var isOK bool }
bs, isOK = crypto.BoxOpen(&sinfo.sharedSesKey, p.Payload, &p.Nonce) sinfo.doFunc(sessionFunc)
// Check if we were unable to decrypt the packet for some reason and if err != nil {
// return an error if we couldn't util.PutBytes(p.Payload)
if !isOK { continue
err = ConnError{errors.New("packet dropped due to decryption failure"), false, true, false, 0} }
var isOK bool
bs, isOK = crypto.BoxOpen(&k, p.Payload, &p.Nonce)
if !isOK {
util.PutBytes(bs)
continue
}
sessionFunc = func() {
if k != sinfo.sharedSesKey || !sinfo.nonceIsOK(&p.Nonce) {
// The session updated in the mean time, so return an error
err = ConnError{errors.New("session updated during crypto operation"), false, true, false, 0}
return return
} }
// Update the session
sinfo.updateNonce(&p.Nonce) sinfo.updateNonce(&p.Nonce)
sinfo.time = time.Now() sinfo.time = time.Now()
sinfo.bytesRecvd += uint64(len(bs)) sinfo.bytesRecvd += uint64(len(bs))
} }
sinfo.doFunc(sessionFunc) sinfo.doFunc(sessionFunc)
if len(bs) > 0 { if err != nil {
if err != nil { // Not sure what else to do with this packet, I guess just drop it
// Bad packet, drop it util.PutBytes(bs)
util.PutBytes(bs) } else {
} else { // Pass the packet to the buffer for Conn.Read
// Pass the packet to the buffer for Conn.Read sinfo.recv <- bs
sinfo.recv <- bs
}
} }
} }
} }