updateSession error handling

apps/login/src/app/(login)/otp/[method]/page.tsx

@@ -33,6 +33,8 @@ export default async function Page(props: {
 
   const host = (await headers()).get("host");
 
+  console.log("host", host);
+
   return (
     <DynamicTheme branding={branding}>
       <div className="flex flex-col items-center space-y-4">

apps/login/src/components/login-otp.tsx

@@ -76,6 +76,13 @@ export function LoginOTP({
   async function updateSessionForOTPChallenge() {
     let challenges;
 
+    if (host) {
+      console.log(
+        `${host.includes("localhost") ? "http://" : "https://"}${host}/otp/method=${method}?code={{.Code}}&userId={{.UserID}}&sessionId={{.SessionID}}&organization={{.OrgID}}` +
+          (authRequestId ? `&authRequestId=${authRequestId}` : ""),
+      );
+    }
+
     if (method === "email") {
       challenges = create(RequestChallengesSchema, {
         otpEmail: {
@@ -107,14 +114,19 @@ export function LoginOTP({
       challenges,
       authRequestId,
     })
-      .catch((error) => {
+      .catch(() => {
-        setError(error.message ?? "Could not request OTP challenge");
+        setError("Could not request OTP challenge");
         return;
       })
       .finally(() => {
         setLoading(false);
       });
 
+    if (response && "error" in response && response.error) {
+      setError(response.error);
+      return;
+    }
+
     return response;
   }
 
@@ -167,6 +179,11 @@ export function LoginOTP({
         setLoading(false);
       });
 
+    if (response && "error" in response && response.error) {
+      setError(response.error);
+      return;
+    }
+
     return response;
   }
 

apps/login/src/components/login-passkey.tsx

@@ -110,6 +110,11 @@ export function LoginPasskey({
         setLoading(false);
       });
 
+    if (session && "error" in session && session.error) {
+      setError(session.error);
+      return;
+    }
+
     return session;
   }
 
@@ -132,6 +137,11 @@ export function LoginPasskey({
         setLoading(false);
       });
 
+    if (response && "error" in response && response.error) {
+      setError(response.error);
+      return;
+    }
+
     return response;
   }
 

apps/login/src/lib/cookies.ts

@@ -142,7 +142,7 @@ export async function removeSessionFromCookie<T>(
   }
 }
 
-export async function getMostRecentSessionCookie<T>(): Promise<any> {
+export async function getMostRecentSessionCookie<T>(): Promise<Cookie> {
   const cookiesList = await cookies();
   const stringifiedCookie = cookiesList.get("sessions");
 

apps/login/src/lib/server/session.ts

@@ -132,21 +132,23 @@ export async function updateSession(options: UpdateSessionCommand) {
     challenges,
   } = options;
   const recentSession = sessionId
-    ? await getSessionCookieById({ sessionId }).catch((error) => {
+    ? await getSessionCookieById({ sessionId })
-        return Promise.reject(error);
-      })
     : loginName
-      ? await getSessionCookieByLoginName({ loginName, organization }).catch(
+      ? await getSessionCookieByLoginName({ loginName, organization })
-          (error) => {
+      : await getMostRecentSessionCookie();
-            return Promise.reject(error);
+
-          },
+  if (!recentSession) {
-        )
+    return {
-      : await getMostRecentSessionCookie().catch((error) => {
+      error: "Could not find session",
-          return Promise.reject(error);
+    };
-        });
+  }
 
   const host = (await headers()).get("host");
 
+  if (!host) {
+    return { error: "Could not get host" };
+  }
+
   if (
     host &&
     challenges &&
@@ -174,6 +176,10 @@ export async function updateSession(options: UpdateSessionCommand) {
     lifetime,
   );
 
+  if (!session) {
+    return { error: "Could not update session" };
+  }
+
   // if password, check if user has MFA methods
   let authMethods;
   if (checks && checks.password && session.factors?.user?.id) {