fix: no project owner at project creation and cleanup (#9317)

# Which Problems Are Solved

Project creation always requires a user as project owner, in case of a
system user creating the project, there is no valid user existing at
that moment.

# How the Problems Are Solved

Remove the initially created project owner membership, as this is
something which was necessary in old versions, and all should work
perfectly without.
The call to add a project automatically designates the calling user as
the project owner, which is irrelevant currently, as this user always
already has higher permissions to be able to even create the project.

# Additional Changes

Cleanup of the existing checks for the project, which can be improved
through the usage of the fields table.

# Additional Context

Closes #9182

internal/command/project_test.go

@@ -25,7 +25,6 @@ func TestCommandSide_AddProject(t *testing.T) {
 		ctx           context.Context
 		project       *domain.Project
 		resourceOwner string
-		ownerID       string
 	}
 	type res struct {
 		want *domain.Project
@@ -54,7 +53,7 @@ func TestCommandSide_AddProject(t *testing.T) {
 			},
 		},
 		{
-			name: "org with project owner, resourceowner empty",
+			name: "project, resourceowner empty",
 			fields: fields{
 				eventstore: eventstoreExpect(
 					t,
@@ -70,40 +69,17 @@ func TestCommandSide_AddProject(t *testing.T) {
 					PrivateLabelingSetting: domain.PrivateLabelingSettingAllowLoginUserResourceOwnerPolicy,
 				},
 				resourceOwner: "",
-				ownerID:       "user1",
 			},
 			res: res{
 				err: zerrors.IsErrorInvalidArgument,
 			},
 		},
 		{
-			name: "org with project owner, ownerID empty",
-			fields: fields{
-				eventstore: eventstoreExpect(
-					t,
-				),
-			},
-			args: args{
-				ctx: context.Background(),
-				project: &domain.Project{
-					Name:                   "project",
-					ProjectRoleAssertion:   true,
-					ProjectRoleCheck:       true,
-					HasProjectCheck:        true,
-					PrivateLabelingSetting: domain.PrivateLabelingSettingAllowLoginUserResourceOwnerPolicy,
-				},
-				resourceOwner: "org1",
-				ownerID:       "",
-			},
-			res: res{
-				err: zerrors.IsErrorInvalidArgument,
-			},
-		},
-		{
-			name: "org with project owner, error already exists",
+			name: "project, error already exists",
 			fields: fields{
 				eventstore: eventstoreExpect(
 					t,
+					expectFilter(),
 					expectPushFailed(zerrors.ThrowAlreadyExists(nil, "ERROR", "internl"),
 						project.NewProjectAddedEvent(
 							context.Background(),
@@ -111,11 +87,36 @@ func TestCommandSide_AddProject(t *testing.T) {
 							"project", true, true, true,
 							domain.PrivateLabelingSettingAllowLoginUserResourceOwnerPolicy,
 						),
-						project.NewProjectMemberAddedEvent(
-							context.Background(),
-							&project.NewAggregate("project1", "org1").Aggregate,
-							"user1",
-							[]string{domain.RoleProjectOwner}...,
+					),
+				),
+				idGenerator: id_mock.NewIDGeneratorExpectIDs(t, "project1"),
+			},
+			args: args{
+				ctx: authz.WithInstanceID(context.Background(), "instanceID"),
+				project: &domain.Project{
+					Name:                   "project",
+					ProjectRoleAssertion:   true,
+					ProjectRoleCheck:       true,
+					HasProjectCheck:        true,
+					PrivateLabelingSetting: domain.PrivateLabelingSettingAllowLoginUserResourceOwnerPolicy,
+				},
+				resourceOwner: "org1",
+			},
+			res: res{
+				err: zerrors.IsErrorAlreadyExists,
+			},
+		},
+		{
+			name: "project, already exists",
+			fields: fields{
+				eventstore: eventstoreExpect(
+					t,
+					expectFilter(
+						eventFromEventPusher(
+							project.NewProjectAddedEvent(context.Background(),
+								&project.NewAggregate("project1", "org1").Aggregate,
+								"project", true, true, true,
+								domain.PrivateLabelingSettingAllowLoginUserResourceOwnerPolicy),
 						),
 					),
 				),
@@ -131,17 +132,17 @@ func TestCommandSide_AddProject(t *testing.T) {
 					PrivateLabelingSetting: domain.PrivateLabelingSettingAllowLoginUserResourceOwnerPolicy,
 				},
 				resourceOwner: "org1",
-				ownerID:       "user1",
 			},
 			res: res{
 				err: zerrors.IsErrorAlreadyExists,
 			},
 		},
 		{
-			name: "org with project owner, ok",
+			name: "project, ok",
 			fields: fields{
 				eventstore: eventstoreExpect(
 					t,
+					expectFilter(),
 					expectPush(
 						project.NewProjectAddedEvent(
 							context.Background(),
@@ -149,12 +150,6 @@ func TestCommandSide_AddProject(t *testing.T) {
 							"project", true, true, true,
 							domain.PrivateLabelingSettingAllowLoginUserResourceOwnerPolicy,
 						),
-						project.NewProjectMemberAddedEvent(
-							context.Background(),
-							&project.NewAggregate("project1", "org1").Aggregate,
-							"user1",
-							[]string{domain.RoleProjectOwner}...,
-						),
 					),
 				),
 				idGenerator: id_mock.NewIDGeneratorExpectIDs(t, "project1"),
@@ -169,7 +164,6 @@ func TestCommandSide_AddProject(t *testing.T) {
 					PrivateLabelingSetting: domain.PrivateLabelingSettingAllowLoginUserResourceOwnerPolicy,
 				},
 				resourceOwner: "org1",
-				ownerID:       "user1",
 			},
 			res: res{
 				want: &domain.Project{
@@ -193,7 +187,7 @@ func TestCommandSide_AddProject(t *testing.T) {
 				idGenerator: tt.fields.idGenerator,
 			}
 			c.setMilestonesCompletedForTest("instanceID")
-			got, err := c.AddProject(tt.args.ctx, tt.args.project, tt.args.resourceOwner, tt.args.ownerID)
+			got, err := c.AddProject(tt.args.ctx, tt.args.project, tt.args.resourceOwner)
 			if tt.res.err == nil {
 				assert.NoError(t, err)
 			}
@@ -1207,9 +1201,6 @@ func TestAddProject(t *testing.T) {
 						false,
 						domain.PrivateLabelingSettingAllowLoginUserResourceOwnerPolicy,
 					),
-					project.NewProjectMemberAddedEvent(ctx, &agg.Aggregate,
-						"CAOS AG",
-						domain.RoleProjectOwner),
 				},
 			},
 		},