feat: actions v2 execution targets command side (#7384)

Adds the API to create, update, delete targets for execution in a new ExecutionService (v3alpha)
2025-08-11 20:57:31 +00:00 · 2024-02-15 06:39:10 +01:00
parent 518c8f486e
commit 198bc017b8
33 changed files with 2552 additions and 18 deletions
--- a/internal/command/action_v2_target.go
+++ b/internal/command/action_v2_target.go
@@ -0,0 +1,177 @@
+package command
+
+import (
+	"context"
+	"net/url"
+	"time"
+
+	"github.com/zitadel/zitadel/internal/domain"
+	"github.com/zitadel/zitadel/internal/eventstore/v1/models"
+	"github.com/zitadel/zitadel/internal/repository/target"
+	"github.com/zitadel/zitadel/internal/zerrors"
+)
+
+type AddTarget struct {
+	models.ObjectRoot
+
+	Name             string
+	TargetType       domain.TargetType
+	URL              string
+	Timeout          time.Duration
+	Async            bool
+	InterruptOnError bool
+}
+
+func (a *AddTarget) IsValid() error {
+	if a.Name == "" {
+		return zerrors.ThrowInvalidArgument(nil, "COMMAND-ddqbm9us5p", "Errors.Target.Invalid")
+	}
+	if a.Timeout == 0 {
+		return zerrors.ThrowInvalidArgument(nil, "COMMAND-39f35d8uri", "Errors.Target.NoTimeout")
+	}
+	_, err := url.Parse(a.URL)
+	if err != nil || a.URL == "" {
+		return zerrors.ThrowInvalidArgument(nil, "COMMAND-1r2k6qo6wg", "Errors.Target.InvalidURL")
+	}
+
+	return nil
+}
+
+func (c *Commands) AddTarget(ctx context.Context, add *AddTarget, resourceOwner string) (_ *domain.ObjectDetails, err error) {
+	if resourceOwner == "" {
+		return nil, zerrors.ThrowInvalidArgument(nil, "COMMAND-brml926e2d", "Errors.IDMissing")
+	}
+
+	if err := add.IsValid(); err != nil {
+		return nil, err
+	}
+
+	if add.AggregateID == "" {
+		add.AggregateID, err = c.idGenerator.Next()
+		if err != nil {
+			return nil, err
+		}
+	}
+
+	wm := NewTargetWriteModel(add.AggregateID, resourceOwner)
+	pushedEvents, err := c.eventstore.Push(ctx, target.NewAddedEvent(
+		ctx,
+		TargetAggregateFromWriteModel(&wm.WriteModel),
+		add.Name,
+		add.TargetType,
+		add.URL,
+		add.Timeout,
+		add.Async,
+		add.InterruptOnError,
+	))
+	if err != nil {
+		return nil, err
+	}
+	if err := AppendAndReduce(wm, pushedEvents...); err != nil {
+		return nil, err
+	}
+	return writeModelToObjectDetails(&wm.WriteModel), nil
+}
+
+type ChangeTarget struct {
+	models.ObjectRoot
+
+	Name             *string
+	TargetType       *domain.TargetType
+	URL              *string
+	Timeout          *time.Duration
+	Async            *bool
+	InterruptOnError *bool
+}
+
+func (a *ChangeTarget) IsValid() error {
+	if a.AggregateID == "" {
+		return zerrors.ThrowInvalidArgument(nil, "COMMAND-1l6ympeagp", "Errors.IDMissing")
+	}
+	if a.Name != nil && *a.Name == "" {
+		return zerrors.ThrowInvalidArgument(nil, "COMMAND-d1wx4lm0zr", "Errors.Target.Invalid")
+	}
+	if a.Timeout != nil && *a.Timeout == 0 {
+		return zerrors.ThrowInvalidArgument(nil, "COMMAND-08b39vdi57", "Errors.Target.NoTimeout")
+	}
+	if a.URL != nil {
+		_, err := url.Parse(*a.URL)
+		if err != nil || *a.URL == "" {
+			return zerrors.ThrowInvalidArgument(nil, "COMMAND-jsbaera7b6", "Errors.Target.InvalidURL")
+		}
+	}
+	return nil
+}
+
+func (c *Commands) ChangeTarget(ctx context.Context, change *ChangeTarget, resourceOwner string) (*domain.ObjectDetails, error) {
+	if resourceOwner == "" {
+		return nil, zerrors.ThrowInvalidArgument(nil, "COMMAND-zqibgg0wwh", "Errors.IDMissing")
+	}
+	if err := change.IsValid(); err != nil {
+		return nil, err
+	}
+
+	existing, err := c.getTargetWriteModelByID(ctx, change.AggregateID, resourceOwner)
+	if err != nil {
+		return nil, err
+	}
+	if !existing.State.Exists() {
+		return nil, zerrors.ThrowNotFound(nil, "COMMAND-xj14f2cccn", "Errors.Target.NotFound")
+	}
+
+	changedEvent := existing.NewChangedEvent(
+		ctx,
+		TargetAggregateFromWriteModel(&existing.WriteModel),
+		change.Name,
+		change.TargetType,
+		change.URL,
+		change.Timeout,
+		change.Async,
+		change.InterruptOnError)
+	if changedEvent == nil {
+		return writeModelToObjectDetails(&existing.WriteModel), nil
+	}
+	pushedEvents, err := c.eventstore.Push(ctx, changedEvent)
+	if err != nil {
+		return nil, err
+	}
+	err = AppendAndReduce(existing, pushedEvents...)
+	if err != nil {
+		return nil, err
+	}
+	return writeModelToObjectDetails(&existing.WriteModel), nil
+}
+
+func (c *Commands) DeleteTarget(ctx context.Context, id, resourceOwner string) (*domain.ObjectDetails, error) {
+	if id == "" || resourceOwner == "" {
+		return nil, zerrors.ThrowInvalidArgument(nil, "COMMAND-obqos2l3no", "Errors.IDMissing")
+	}
+
+	existing, err := c.getTargetWriteModelByID(ctx, id, resourceOwner)
+	if err != nil {
+		return nil, err
+	}
+	if !existing.State.Exists() {
+		return nil, zerrors.ThrowNotFound(nil, "COMMAND-k4s7ucu0ax", "Errors.Target.NotFound")
+	}
+
+	if err := c.pushAppendAndReduce(ctx,
+		existing,
+		target.NewRemovedEvent(ctx,
+			TargetAggregateFromWriteModel(&existing.WriteModel),
+			existing.Name,
+		),
+	); err != nil {
+		return nil, err
+	}
+	return writeModelToObjectDetails(&existing.WriteModel), nil
+}
+
+func (c *Commands) getTargetWriteModelByID(ctx context.Context, id string, resourceOwner string) (*TargetWriteModel, error) {
+	wm := NewTargetWriteModel(id, resourceOwner)
+	err := c.eventstore.FilterToQueryReducer(ctx, wm)
+	if err != nil {
+		return nil, err
+	}
+	return wm, nil
+}