TheArchive/zitadel
1
0
Fork 0
mirror of https://github.com/zitadel/zitadel.git synced 2025-01-07 09:30:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add apple as identity provider type to settings v2 api (#8472)

Browse Source 
# Which Problems Are Solved

Apple is not availabe as IDP type in the settings v2 API.

# How the Problems Are Solved

Add Apple as type.

# Additional Changes

None

# Additional Context

None

Co-authored-by: Max Peintner <max@caos.ch>
This commit is contained in:
Stefan Benz 2024-09-11 16:26:28 +02:00 committed by GitHub
parent f6da528296
commit 1a75414315
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/api/grpc/settings/v2/settings_converter.go
View File

@ -216,6 +216,8 @@ func idpTypeToPb(idpType domain.IDPType) settings.IdentityProviderType {
return settings.IdentityProviderType_IDENTITY_PROVIDER_TYPE_GITLAB_SELF_HOSTED return settings.IdentityProviderType_IDENTITY_PROVIDER_TYPE_GITLAB_SELF_HOSTED
case domain.IDPTypeGoogle: case domain.IDPTypeGoogle:
return settings.IdentityProviderType_IDENTITY_PROVIDER_TYPE_GOOGLE return settings.IdentityProviderType_IDENTITY_PROVIDER_TYPE_GOOGLE
case domain.IDPTypeApple:
return settings.IdentityProviderType_IDENTITY_PROVIDER_TYPE_APPLE
case domain.IDPTypeSAML: case domain.IDPTypeSAML:
return settings.IdentityProviderType_IDENTITY_PROVIDER_TYPE_SAML return settings.IdentityProviderType_IDENTITY_PROVIDER_TYPE_SAML
default: default:

4
internal/api/grpc/settings/v2/settings_converter_test.go
View File

@ -466,6 +466,10 @@ func Test_idpTypeToPb(t *testing.T) {
args: args{domain.IDPTypeGoogle}, args: args{domain.IDPTypeGoogle},
want: settings.IdentityProviderType_IDENTITY_PROVIDER_TYPE_GOOGLE, want: settings.IdentityProviderType_IDENTITY_PROVIDER_TYPE_GOOGLE,
}, },
{
args: args{domain.IDPTypeApple},
want: settings.IdentityProviderType_IDENTITY_PROVIDER_TYPE_APPLE,
},
{ {
args: args{domain.IDPTypeSAML}, args: args{domain.IDPTypeSAML},
want: settings.IdentityProviderType_IDENTITY_PROVIDER_TYPE_SAML, want: settings.IdentityProviderType_IDENTITY_PROVIDER_TYPE_SAML,

3
proto/zitadel/settings/v2/login_settings.proto
View File

@ -148,5 +148,6 @@ enum IdentityProviderType {
IDENTITY_PROVIDER_TYPE_GITLAB = 8; IDENTITY_PROVIDER_TYPE_GITLAB = 8;
IDENTITY_PROVIDER_TYPE_GITLAB_SELF_HOSTED = 9; IDENTITY_PROVIDER_TYPE_GITLAB_SELF_HOSTED = 9;
IDENTITY_PROVIDER_TYPE_GOOGLE = 10; IDENTITY_PROVIDER_TYPE_GOOGLE = 10;
IDENTITY_PROVIDER_TYPE_SAML=11; IDENTITY_PROVIDER_TYPE_SAML = 11;
IDENTITY_PROVIDER_TYPE_APPLE = 12;
} }