From 1c1d66cbe806edeff6c7fc432ac3077be983981d Mon Sep 17 00:00:00 2001 From: Max Peintner Date: Tue, 11 Apr 2023 17:56:51 +0200 Subject: [PATCH] chore(console): remove first and lastName fallback from user (#5629) * chore(console): remove first and lastName fallback from user * use display name and ensure it's set without required name fields * add user type to user grant and memberships responses * contributor, members * fix avatar display checks --------- Co-authored-by: Livio Spring --- cmd/defaults.yaml | 24 +++++++++---------- .../accounts-card.component.html | 8 ++----- .../contributors/contributors.component.html | 4 ++-- .../contributors/contributors.component.ts | 3 +++ .../app/modules/header/header.component.html | 10 ++------ .../members-table.component.html | 2 +- .../members-table/members-table.component.ts | 2 ++ .../search-user-autocomplete.component.html | 18 ++------------ .../user-grants/user-grants.component.html | 2 +- .../user-grants/user-grants.component.ts | 1 - .../detail-form/detail-form.component.html | 6 ++--- .../user-table/user-table.component.html | 12 +++------- internal/api/grpc/auth/user_grant.go | 2 ++ internal/api/grpc/member/converter.go | 2 ++ internal/api/grpc/user/converter.go | 13 ++++++++++ internal/api/grpc/user/user_grant.go | 1 + internal/command/user_human.go | 12 ++++++++-- internal/domain/human.go | 9 ++++++- internal/notification/static/i18n/de.yaml | 16 ++++++------- internal/notification/static/i18n/en.yaml | 16 ++++++------- internal/notification/static/i18n/fr.yaml | 14 +++++------ internal/notification/static/i18n/it.yaml | 16 ++++++------- internal/notification/static/i18n/ja.yaml | 14 +++++------ internal/notification/static/i18n/pl.yaml | 14 +++++------ internal/notification/static/i18n/zh.yaml | 14 +++++------ internal/query/iam_member.go | 6 +++++ internal/query/iam_member_test.go | 13 ++++++++++ internal/query/member.go | 2 ++ internal/query/org_member.go | 6 +++++ internal/query/org_member_test.go | 14 +++++++++++ internal/query/project_grant_member.go | 6 +++++ internal/query/project_grant_member_test.go | 14 +++++++++++ internal/query/project_member.go | 6 +++++ internal/query/project_member_test.go | 14 +++++++++++ proto/zitadel/auth.proto | 5 ++++ proto/zitadel/member.proto | 6 +++++ proto/zitadel/user.proto | 5 ++++ 37 files changed, 218 insertions(+), 114 deletions(-) diff --git a/cmd/defaults.yaml b/cmd/defaults.yaml index 625a03dafc..8996e384c6 100644 --- a/cmd/defaults.yaml +++ b/cmd/defaults.yaml @@ -554,7 +554,7 @@ DefaultInstance: Title: Zitadel - User initialisieren PreHeader: User initialisieren Subject: User initialisieren - Greeting: Hallo {{.FirstName}} {{.LastName}}, + Greeting: Hallo {{.DisplayName}}, Text: Dieser Benutzer wurde soeben im Zitadel erstellt. Mit dem Benutzernamen <br><strong>{{.PreferredLoginName}}</strong><br> kannst du dich anmelden. Nutze den untenstehenden Button, um die Initialisierung abzuschliessen <br>(Code <strong>{{.Code}}</strong>).<br> Falls du dieses Mail nicht angefordert hast, kannst du es einfach ignorieren. ButtonText: Initialisierung abschliessen - MessageTextType: PasswordReset @@ -562,7 +562,7 @@ DefaultInstance: Title: Zitadel - Passwort zurücksetzen PreHeader: Passwort zurücksetzen Subject: Passwort zurücksetzen - Greeting: Hallo {{.FirstName}} {{.LastName}}, + Greeting: Hallo {{.DisplayName}}, Text: Wir haben eine Anfrage für das Zurücksetzen deines Passwortes bekommen. Du kannst den untenstehenden Button verwenden, um dein Passwort zurückzusetzen <br>(Code <strong>{{.Code}}</strong>).<br> Falls du dieses Mail nicht angefordert hast, kannst du es ignorieren. ButtonText: Passwort zurücksetzen - MessageTextType: VerifyEmail @@ -570,7 +570,7 @@ DefaultInstance: Title: Zitadel - Email verifizieren PreHeader: Email verifizieren Subject: Email verifizieren - Greeting: Hallo {{.FirstName}} {{.LastName}}, + Greeting: Hallo {{.DisplayName}}, Text: Eine neue E-Mail Adresse wurde hinzugefügt. Bitte verwende den untenstehenden Button um diese zu verifizieren <br>(Code <strong>{{.Code}}</strong>).<br> Falls du deine E-Mail Adresse nicht selber hinzugefügt hast, kannst du dieses E-Mail ignorieren. ButtonText: Email verifizieren - MessageTextType: VerifyPhone @@ -578,7 +578,7 @@ DefaultInstance: Title: Zitadel - Telefonnummer verifizieren PreHeader: Telefonnummer verifizieren Subject: Telefonnummer verifizieren - Greeting: Hallo {{.FirstName}} {{.LastName}}, + Greeting: Hallo {{.DisplayName}}, Text: Eine Telefonnummer wurde hinzugefügt. Bitte verifiziere diese in dem du folgenden Code eingibst (Code {{.Code}}) ButtonText: Telefon verifizieren - MessageTextType: DomainClaimed @@ -586,7 +586,7 @@ DefaultInstance: Title: Zitadel - Domain wurde beansprucht PreHeader: Email / Username ändern Subject: Domain wurde beansprucht - Greeting: Hallo {{.FirstName}} {{.LastName}}, + Greeting: Hallo {{.DisplayName}}, Text: Die Domain {{.Domain}} wurde von einer Organisation beansprucht. Dein derzeitiger User {{.Username}} ist nicht Teil dieser Organisation. Daher musst du beim nächsten Login eine neue Email hinterlegen. Für diesen Login haben wir dir einen temporären Usernamen ({{.TempUsername}}) erstellt. ButtonText: Login - MessageTextType: PasswordChange @@ -594,7 +594,7 @@ DefaultInstance: Title: ZITADEL - Passwort von Benutzer wurde geändert PreHeader: Passwort Änderung Subject: Passwort von Benutzer wurde geändert - Greeting: Hallo {{.FirstName}} {{.LastName}}, + Greeting: Hallo {{.DisplayName}}, Text: Das Password vom Benutzer wurde geändert. Wenn diese Änderung von jemand anderem gemacht wurde, empfehlen wir die sofortige Zurücksetzung ihres Passworts. ButtonText: Login - MessageTextType: InitCode @@ -602,7 +602,7 @@ DefaultInstance: Title: Zitadel - Initialize User PreHeader: Initialize User Subject: Initialize User - Greeting: Hello {{.FirstName}} {{.LastName}}, + Greeting: Hello {{.DisplayName}}, Text: This user was created in Zitadel. Use the username {{.PreferredLoginName}} to login. Please click the button below to finish the initialization process. (Code {{.Code}}) If you didn't ask for this mail, please ignore it. ButtonText: Finish initialization - MessageTextType: PasswordReset @@ -610,7 +610,7 @@ DefaultInstance: Title: Zitadel - Reset password PreHeader: Reset password Subject: Reset password - Greeting: Hello {{.FirstName}} {{.LastName}}, + Greeting: Hello {{.DisplayName}}, Text: We received a password reset request. Please use the button below to reset your password. (Code {{.Code}}) If you didn't ask for this mail, please ignore it. ButtonText: Reset password - MessageTextType: VerifyEmail @@ -618,7 +618,7 @@ DefaultInstance: Title: Zitadel - Verify email PreHeader: Verify email Subject: Verify email - Greeting: Hello {{.FirstName}} {{.LastName}}, + Greeting: Hello {{.DisplayName}}, Text: A new email has been added. Please use the button below to verify your mail. (Code {{.Code}}) If you din't add a new email, please ignore this email. ButtonText: Verify email - MessageTextType: VerifyPhone @@ -626,7 +626,7 @@ DefaultInstance: Title: Zitadel - Verify phone PreHeader: Verify phone Subject: Verify phone - Greeting: Hello {{.FirstName}} {{.LastName}}, + Greeting: Hello {{.DisplayName}}, Text: A new phonenumber has been added. Please use the following code to verify it {{.Code}}. ButtonText: Verify phone - MessageTextType: DomainClaimed @@ -634,7 +634,7 @@ DefaultInstance: Title: Zitadel - Domain has been claimed PreHeader: Change email / username Subject: Domain has been claimed - Greeting: Hello {{.FirstName}} {{.LastName}}, + Greeting: Hello {{.DisplayName}}, Text: The domain {{.Domain}} has been claimed by an organisation. Your current user {{.UserName}} is not part of this organisation. Therefore you'll have to change your email when you login. We have created a temporary username ({{.TempUsername}}) for this login. ButtonText: Login - MessageTextType: PasswordChange @@ -642,7 +642,7 @@ DefaultInstance: Title: ZITADEL - Password of user has changed PreHeader: Change password Subject: Password of user has changed - Greeting: Hello {{.FirstName}} {{.LastName}}, + Greeting: Hello {{.DisplayName}}, Text: The password of your user has changed. If this change was not done by you, please be advised to immediately reset your password. ButtonText: Login diff --git a/console/src/app/modules/accounts-card/accounts-card.component.html b/console/src/app/modules/accounts-card/accounts-card.component.html index 7780fd323f..b4a9439c36 100644 --- a/console/src/app/modules/accounts-card/accounts-card.component.html +++ b/console/src/app/modules/accounts-card/accounts-card.component.html @@ -1,16 +1,12 @@
diff --git a/console/src/app/modules/contributors/contributors.component.html b/console/src/app/modules/contributors/contributors.component.html index 58d6f6355a..0ef25b708c 100644 --- a/console/src/app/modules/contributors/contributors.component.html +++ b/console/src/app/modules/contributors/contributors.component.html @@ -13,10 +13,10 @@ data-e2e="member-avatar" > diff --git a/console/src/app/modules/contributors/contributors.component.ts b/console/src/app/modules/contributors/contributors.component.ts index d0dd487fd8..bdb3fe4540 100644 --- a/console/src/app/modules/contributors/contributors.component.ts +++ b/console/src/app/modules/contributors/contributors.component.ts @@ -2,6 +2,7 @@ import { animate, animateChild, keyframes, query, stagger, style, transition, tr import { Component, EventEmitter, Input, Output } from '@angular/core'; import { BehaviorSubject } from 'rxjs'; import { Member } from 'src/app/proto/generated/zitadel/member_pb'; +import { Type } from 'src/app/proto/generated/zitadel/user_pb'; @Component({ selector: 'cnsl-contributors', @@ -36,6 +37,8 @@ export class ContributorsComponent { @Output() showDetailClicked: EventEmitter = new EventEmitter(); @Output() refreshClicked: EventEmitter = new EventEmitter(); + public UserType: any = Type; + public emitAddMember(): void { this.addClicked.emit(); } diff --git a/console/src/app/modules/header/header.component.html b/console/src/app/modules/header/header.component.html index d9043c1381..de31e202eb 100644 --- a/console/src/app/modules/header/header.component.html +++ b/console/src/app/modules/header/header.component.html @@ -197,9 +197,7 @@
- +