From 260c91e66147f46b9a1d4fb7228c8c9015bd9d41 Mon Sep 17 00:00:00 2001 From: peintnermax Date: Fri, 13 Sep 2024 14:14:09 +0200 Subject: [PATCH] rm duplicate arrow --- apps/login/readme.md | 3 +-- apps/login/src/lib/server/loginname.ts | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/apps/login/readme.md b/apps/login/readme.md index 9edef9383ee..11ff6d3bd7a 100644 --- a/apps/login/readme.md +++ b/apps/login/readme.md @@ -9,7 +9,6 @@ This is going to be our next UI for the hosted login. It's based on Next.js 13 a A[Start] --> register A[Start] --> accounts A[Start] --> loginname - A[Start] --> register A[Start] -- signInWithIDP --> idp idp --> idp-success idp --> idp-failure @@ -74,4 +73,4 @@ If no previous condition is met we throw an error stating the user was not found If the outcome after this order produces a no authentication methods found, or user not found, we check whether `loginSettings?.ignoreUnknownUsernames` is set to `true` as in this case we redirect to the /password page regardless (to not leak information about a registered user). -> NOTE: We ignore `loginSettings.allowExternalIdp` as the information whether IDPs are available comes as response from `getActiveIdentityProviders(org?)` +> NOTE: We ignore `loginSettings.allowExternalIdp` as the information whether IDPs are available comes as response from `getActiveIdentityProviders(org?)`. diff --git a/apps/login/src/lib/server/loginname.ts b/apps/login/src/lib/server/loginname.ts index 3701fa7de2c..9d6e49779ec 100644 --- a/apps/login/src/lib/server/loginname.ts +++ b/apps/login/src/lib/server/loginname.ts @@ -185,7 +185,7 @@ export async function sendLoginname(command: SendLoginnameCommand) { // user not found, check if register is enabled on organization if (loginSettings?.allowRegister && !loginSettings?.allowUsernamePassword) { - // TODO redirect to loginname page with idp hint + // TODO: do we need to handle login hints for IDPs here? await redirectUserToSingleIDPIfAvailable(); throw Error("Could not find user");