mirror of
https://github.com/zitadel/zitadel.git
synced 2025-08-12 01:27:32 +00:00
fix: relax parsing of SCIM user 'active' flag to improve compatibility (#9296)
# Which Problems Are Solved - Microsoft Entra invokes the user patch endpoint with `"active": "True"` / `"active": "False"` when patching a user. This is a well-known bug in MS Entra (see [here](https://learn.microsoft.com/en-us/entra/identity/app-provisioning/application-provisioning-config-problem-scim-compatibility)), but the bug fix has not landed yet and/or the feature flag does not work. # How the Problems Are Solved - To ensure compatibility with MS Entra, the parsing of the the boolean active flag of the scim user is relaxed and accepts strings in any casing that resolve to `true` or `false` as well as raw boolean values. # Additional Context Part of https://github.com/zitadel/zitadel/issues/8140
This commit is contained in:
@@ -14,7 +14,6 @@ import (
|
||||
"time"
|
||||
|
||||
"github.com/brianvoe/gofakeit/v6"
|
||||
"github.com/muhlemmer/gu"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
"golang.org/x/text/language"
|
||||
@@ -289,7 +288,7 @@ func TestBulk(t *testing.T) {
|
||||
},
|
||||
DisplayName: "scim-bulk-created-user-0-given-name scim-bulk-created-user-0-family-name",
|
||||
PreferredLanguage: test.Must(language.Parse("en")),
|
||||
Active: gu.Ptr(true),
|
||||
Active: schemas.NewRelaxedBool(true),
|
||||
Emails: []*resources.ScimEmail{
|
||||
{
|
||||
Value: "scim-bulk-created-user-0@example.com",
|
||||
@@ -308,7 +307,7 @@ func TestBulk(t *testing.T) {
|
||||
DisplayName: "scim-bulk-created-user-1-given-name scim-bulk-created-user-1-family-name",
|
||||
NickName: "scim-bulk-created-user-1-nickname-patched",
|
||||
PreferredLanguage: test.Must(language.Parse("en")),
|
||||
Active: gu.Ptr(true),
|
||||
Active: schemas.NewRelaxedBool(true),
|
||||
Emails: []*resources.ScimEmail{
|
||||
{
|
||||
Value: "scim-bulk-created-user-1@example.com",
|
||||
@@ -333,7 +332,7 @@ func TestBulk(t *testing.T) {
|
||||
DisplayName: "scim-bulk-created-user-2-given-name scim-bulk-created-user-2-family-name",
|
||||
NickName: "scim-bulk-created-user-2-nickname-patched",
|
||||
PreferredLanguage: test.Must(language.Parse("en")),
|
||||
Active: gu.Ptr(true),
|
||||
Active: schemas.NewRelaxedBool(true),
|
||||
Emails: []*resources.ScimEmail{
|
||||
{
|
||||
Value: "scim-bulk-created-user-2@example.com",
|
||||
|
Reference in New Issue
Block a user