fix(cli): overwrite setups (#3488)

* fix(cli): possibility to overwrite setup steps

* chore: update cockroach version in go-dep

* fix(cli): init masterkey flags once

Co-authored-by: Livio Amstutz <livio.a@gmail.com>

build/zitadel/Dockerfile

@@ -21,9 +21,9 @@ RUN apt install openssl tzdata tar
 
 # cockroach binary used to backup database
 RUN mkdir /usr/local/lib/cockroach
-RUN wget -qO- https://binaries.cockroachdb.com/cockroach-v21.2.5.linux-amd64.tgz \
+RUN wget -qO- https://binaries.cockroachdb.com/cockroach-v21.2.9.linux-amd64.tgz \
-    | tar  xvz && cp -i cockroach-v21.2.5.linux-amd64/cockroach /usr/local/bin/
+    | tar  xvz && cp -i cockroach-v21.2.9.linux-amd64/cockroach /usr/local/bin/
-RUN rm -r cockroach-v21.2.5.linux-amd64
+RUN rm -r cockroach-v21.2.9.linux-amd64
 
 #######################
 ## generates static files

cmd/admin/key/masterkey.go

@@ -21,6 +21,9 @@ var (
 )
 
 func AddMasterKeyFlag(cmd *cobra.Command) {
+	if cmd.PersistentFlags().Lookup(flagMasterKey) != nil {
+		return
+	}
 	cmd.PersistentFlags().StringP(flagMasterKey, flagMasterKeyShort, "", "path to the masterkey for en/decryption keys")
 	cmd.PersistentFlags().String(flagMasterKeyArg, "", "masterkey as argument for en/decryption keys")
 	cmd.PersistentFlags().Bool(flagMasterKeyEnv, false, "read masterkey for en/decryption keys from environment variable (ZITADEL_MASTERKEY)")

cmd/admin/setup/config.go

@@ -36,6 +36,7 @@ func MustNewConfig(v *viper.Viper) *Config {
 			mapstructure.StringToSliceHookFunc(","),
 		)),
 	)
+	logging.OnError(err).Fatal("unable to read default config")
 
 	err = config.Log.SetLogger()
 	logging.OnError(err).Fatal("unable to set logger")
@@ -58,6 +59,12 @@ func MustNewSteps(v *viper.Viper) *Steps {
 	err := v.ReadConfig(bytes.NewBuffer(defaultSteps))
 	logging.OnError(err).Fatal("unable to read setup steps")
 
+	for _, file := range stepFiles {
+		v.SetConfigFile(file)
+		err := v.MergeInConfig()
+		logging.WithFields("file", file).OnError(err).Warn("unable to read setup file")
+	}
+
 	steps := new(Steps)
 	err = v.Unmarshal(steps,
 		viper.DecodeHook(mapstructure.ComposeDecodeHookFunc(

cmd/admin/setup/setup.go

@@ -18,10 +18,11 @@ import (
 var (
 	//go:embed steps.yaml
 	defaultSteps []byte
+	stepFiles    []string
 )
 
 func New() *cobra.Command {
-	return &cobra.Command{
+	cmd := &cobra.Command{
 		Use:   "setup",
 		Short: "setup ZITADEL instance",
 		Long: `sets up data to start ZITADEL.
@@ -37,6 +38,15 @@ Requirements:
 			Setup(config, steps, masterKey)
 		},
 	}
+
+	Flags(cmd)
+
+	return cmd
+}
+
+func Flags(cmd *cobra.Command) {
+	cmd.PersistentFlags().StringArrayVar(&stepFiles, "steps", nil, "paths to step files to overwrite default steps")
+	key.AddMasterKeyFlag(cmd)
 }
 
 func Setup(config *Config, steps *Steps, masterKey string) {
@@ -79,3 +89,13 @@ func Setup(config *Config, steps *Steps, masterKey string) {
 	err = migration.Migrate(ctx, eventstoreClient, steps.S3DefaultInstance)
 	logging.OnError(err).Fatal("unable to migrate step 4")
 }
+
+func initSteps(v *viper.Viper, files ...string) func() {
+	return func() {
+		for _, file := range files {
+			v.SetConfigFile(file)
+			err := v.MergeInConfig()
+			logging.WithFields("file", file).OnError(err).Warn("unable to read setup file")
+		}
+	}
+}

cmd/admin/start/flags.go

@@ -14,7 +14,6 @@ func startFlags(cmd *cobra.Command) {
 	bindBoolFlag(cmd, "externalSecure", "if ZITADEL will be served on HTTPS")
 
 	key.AddMasterKeyFlag(cmd)
-
 }
 
 func bindStringFlag(cmd *cobra.Command, name, description string) {

cmd/admin/start/start_from_init.go

@@ -38,6 +38,7 @@ Requirements:
 	}
 
 	startFlags(cmd)
+	setup.Flags(cmd)
 
 	return cmd
 }

cmd/zitadel.go

@@ -3,6 +3,7 @@ package cmd
 import (
 	"bytes"
 	_ "embed"
+	"errors"
 	"io"
 	"strings"
 
@@ -25,8 +26,8 @@ func New(out io.Writer, in io.Reader, args []string) *cobra.Command {
 		Use:   "zitadel",
 		Short: "The ZITADEL CLI let's you interact with ZITADEL",
 		Long:  `The ZITADEL CLI let's you interact with ZITADEL`,
-		Run: func(cmd *cobra.Command, args []string) {
+		RunE: func(cmd *cobra.Command, args []string) error {
-			logging.New().Info("hello world")
+			return errors.New("no additional command provided")
 		},
 	}