fix: cleanup some todos (#3642)

* cleanup todo

* fix: some todos
This commit is contained in:
Livio Amstutz
2022-05-16 16:35:49 +02:00
committed by GitHub
parent 5c0f527a49
commit 3a63fb765a
45 changed files with 130 additions and 199 deletions

View File

@@ -22,7 +22,6 @@ const (
ProjectRoleColumnInstanceID = "instance_id"
ProjectRoleColumnDisplayName = "display_name"
ProjectRoleColumnGroupName = "group_name"
ProjectRoleColumnCreator = "creator_id" //TODO: necessary?
)
type ProjectRoleProjection struct {
@@ -44,7 +43,6 @@ func NewProjectRoleProjection(ctx context.Context, config crdb.StatementHandlerC
crdb.NewColumn(ProjectRoleColumnInstanceID, crdb.ColumnTypeText),
crdb.NewColumn(ProjectRoleColumnDisplayName, crdb.ColumnTypeText),
crdb.NewColumn(ProjectRoleColumnGroupName, crdb.ColumnTypeText),
crdb.NewColumn(ProjectRoleColumnCreator, crdb.ColumnTypeText),
},
crdb.NewPrimaryKey(ProjectRoleColumnInstanceID, ProjectRoleColumnProjectID, ProjectRoleColumnKey),
),
@@ -96,7 +94,6 @@ func (p *ProjectRoleProjection) reduceProjectRoleAdded(event eventstore.Event) (
handler.NewCol(ProjectRoleColumnSequence, e.Sequence()),
handler.NewCol(ProjectRoleColumnDisplayName, e.DisplayName),
handler.NewCol(ProjectRoleColumnGroupName, e.Group),
handler.NewCol(ProjectRoleColumnCreator, e.EditorUser()),
},
), nil
}