fix: cleanup some todos (#3642)

* cleanup todo

* fix: some todos
This commit is contained in:
Livio Amstutz
2022-05-16 16:35:49 +02:00
committed by GitHub
parent 5c0f527a49
commit 3a63fb765a
45 changed files with 130 additions and 199 deletions

View File

@@ -2892,7 +2892,7 @@ message SetUpOrgRequest {
min_length: 1;
example: "\"gigi@caos.ch\"";
}
]; //TODO: check if no value is allowed
];
bool is_email_verified = 2;
}
message Phone {

View File

@@ -63,6 +63,8 @@ message AppNameQuery {
}
message OIDCConfig {
reserved "client_secret";
reserved 6;
repeated string redirect_uris = 1 [
(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
example: "[\"https://console.zitadel.ch/auth/callback\"]";
@@ -90,12 +92,6 @@ message OIDCConfig {
description: "generated oauth2/oidc client id";
}
];
string client_secret = 6 [
(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
example: "\"gjöq34589uasgh\"";
description: "generated secret for this config";
}
];
OIDCAuthMethodType auth_method_type = 7 [
(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
description: "defines how the application passes login credentials";
@@ -208,18 +204,14 @@ enum APIAuthMethodType {
}
message APIConfig {
reserved "client_secret";
reserved 2;
string client_id = 1 [
(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
example: "\"69629023906488334@ZITADEL\"";
description: "generated oauth2/oidc client_id";
}
];
string client_secret = 2 [
(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
example: "\"gjöq34589uasgh\"";
description: "generated secret for this config";
}
];
APIAuthMethodType auth_method_type = 3 [
(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
description: "defines how the api passes the login credentials";

View File

@@ -771,7 +771,7 @@ message GetMyEmailResponse {
}
message SetMyEmailRequest {
string email = 1 [(validate.rules).string.email = true]; //TODO: check if no value is allowed
string email = 1 [(validate.rules).string.email = true];
}
message SetMyEmailResponse {

View File

@@ -138,7 +138,6 @@ service ManagementService {
value: {
description: "OK";
}
//TODO: errors
};
};
}
@@ -2952,7 +2951,7 @@ message AddHumanUserRequest {
zitadel.user.v1.Gender gender = 6;
}
message Email {
string email = 1 [(validate.rules).string.email = true]; //TODO: check if no value is allowed
string email = 1 [(validate.rules).string.email = true];
bool is_email_verified = 2;
}
message Phone {
@@ -2984,7 +2983,7 @@ message ImportHumanUserRequest {
zitadel.user.v1.Gender gender = 6;
}
message Email {
string email = 1 [(validate.rules).string.email = true]; //TODO: check if no value is allowed
string email = 1 [(validate.rules).string.email = true];
bool is_email_verified = 2;
}
message Phone {