TheArchive/zitadel
1
0
Fork 0
mirror of https://github.com/zitadel/zitadel.git synced 2024-12-12 11:04:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(query): optimize instance by domain query (#7513)

Browse Source 
fix(query): optimize instance by domain query

On zitadel cloud we noticed an increase in database CPU usage and slightly higher response times.
By analyzes we found that the instance by domain query was wrongly joining all instance_feature rows against all instances.
This PR adds an additional CTE to limit the join set to only the features that apply to the found instance.

The query was introduced with https://github.com/zitadel/zitadel/pull/7356 and part of the v2.47 release.
This commit is contained in:
Tim Möhlmann 2024-03-06 20:02:16 +02:00 committed by GitHub
parent ab5fc05579
commit 3af28d29d2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/query/instance_by_domain.sql
View File

@ -1,6 +1,10 @@
with domain as ( with domain as (
select instance_id from projections.instance_domains select instance_id from projections.instance_domains
where domain = $1 where domain = $1
), instance_features as (
select i.*
from domain d
join projections.instance_features2 i on d.instance_id = i.instance_id
), features as ( ), features as (
select instance_id, json_object_agg( select instance_id, json_object_agg(
coalesce(i.key, s.key), coalesce(i.key, s.key),
@ -8,7 +12,7 @@ with domain as (
) features ) features
from domain d from domain d
cross join projections.system_features s cross join projections.system_features s
full outer join projections.instance_features2 i using (key, instance_id) full outer join instance_features i using (instance_id, key)
group by instance_id group by instance_id
) )
select select