From 47d658cf459ba34600c297816c33a674e80cb898 Mon Sep 17 00:00:00 2001 From: Elio Bischof Date: Thu, 24 Jul 2025 15:56:31 +0200 Subject: [PATCH] use npm for devcontainer cli --- .github/workflows/lint.yml | 4 ++-- .github/workflows/login-integration-test.yml | 4 ++-- CONTRIBUTING.md | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 5030cb55f3..2b6faf8a24 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -66,9 +66,9 @@ jobs: # We don't care about the node version or anything else, we just want to set up pnpm caching cache: 'pnpm' - name: Install Dev Container CLI - run: pnpm install -g @devcontainers/cli@0.3.0 + run: npm install -g @devcontainers/cli@0.80.0 - name: Lint and Unit Test All JavaScript Code - run: pnpm devcontainer:lint-unit + run: npm devcontainer:lint-unit core: name: core diff --git a/.github/workflows/login-integration-test.yml b/.github/workflows/login-integration-test.yml index 76357ccb08..af5dd75f55 100644 --- a/.github/workflows/login-integration-test.yml +++ b/.github/workflows/login-integration-test.yml @@ -27,6 +27,6 @@ jobs: # We don't care about the node version or anything else, we just want to set up pnpm caching cache: 'pnpm' - name: Install Dev Container CLI - run: pnpm install -g @devcontainers/cli@0.3.0 + run: npm install -g @devcontainers/cli@0.80.0 - name: Run Integration Tests against the Login and a Mocked Zitadel API - run: pnpm devcontainer:integration:login + run: npm devcontainer:integration:login diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b83d1f8518..9a1a30a754 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -573,7 +573,7 @@ You can also run the GitHub PR checks locally in dev containers without having t The following pnpm commands use the [devcontainer CLI](https://github.com/devcontainers/cli/) and exit when the checks are done. The minimal system requirements are having Docker and the devcontainers CLI installed. -If you don't have the node_modules installed already, you need to install the devcontainers CLI manually. Run `npm i -g @devcontainers/cli`. Alternatively, the [official Microsoft VS Code extension for Dev Containers](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers) offers a command `Dev Containers: Install devcontainer CLI` +If you don't have the node_modules installed already, you need to install the devcontainers CLI manually. Run `npm i -g @devcontainers/cli@0.80.0`. Alternatively, the [official Microsoft VS Code extension for Dev Containers](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers) offers a command `Dev Containers: Install devcontainer CLI` ```bash