chore(oidc): remove feature flag for introspection triggers (#10132)

# Which Problems Are Solved

Remove the feature flag that allowed triggers in introspection. This
option was a fallback in case introspection would not function properly
without triggers. The API documentation asked for anyone using this flag
to raise an issue. No such issue was received, hence we concluded it is
safe to remove it.

# How the Problems Are Solved

- Remove flags from the system and instance level feature APIs.
- Remove trigger functions that are no longer used
- Adjust tests that used the flag.

# Additional Changes

- none

# Additional Context

- Closes #10026 
- Flag was introduced in #7356

---------

Co-authored-by: Silvan <27845747+adlerhurst@users.noreply.github.com>

internal/api/grpc/feature/v2beta/converter.go

@@ -10,49 +10,45 @@ import (
 
 func systemFeaturesToCommand(req *feature_pb.SetSystemFeaturesRequest) *command.SystemFeatures {
 	return &command.SystemFeatures{
-		LoginDefaultOrg:                 req.LoginDefaultOrg,
-		TriggerIntrospectionProjections: req.OidcTriggerIntrospectionProjections,
-		UserSchema:                      req.UserSchema,
-		TokenExchange:                   req.OidcTokenExchange,
-		ImprovedPerformance:             improvedPerformanceListToDomain(req.ImprovedPerformance),
-		OIDCSingleV1SessionTermination:  req.OidcSingleV1SessionTermination,
+		LoginDefaultOrg:                req.LoginDefaultOrg,
+		UserSchema:                     req.UserSchema,
+		TokenExchange:                  req.OidcTokenExchange,
+		ImprovedPerformance:            improvedPerformanceListToDomain(req.ImprovedPerformance),
+		OIDCSingleV1SessionTermination: req.OidcSingleV1SessionTermination,
 	}
 }
 
 func systemFeaturesToPb(f *query.SystemFeatures) *feature_pb.GetSystemFeaturesResponse {
 	return &feature_pb.GetSystemFeaturesResponse{
-		Details:                             object.DomainToDetailsPb(f.Details),
-		LoginDefaultOrg:                     featureSourceToFlagPb(&f.LoginDefaultOrg),
-		OidcTriggerIntrospectionProjections: featureSourceToFlagPb(&f.TriggerIntrospectionProjections),
-		UserSchema:                          featureSourceToFlagPb(&f.UserSchema),
-		OidcTokenExchange:                   featureSourceToFlagPb(&f.TokenExchange),
-		ImprovedPerformance:                 featureSourceToImprovedPerformanceFlagPb(&f.ImprovedPerformance),
-		OidcSingleV1SessionTermination:      featureSourceToFlagPb(&f.OIDCSingleV1SessionTermination),
+		Details:                        object.DomainToDetailsPb(f.Details),
+		LoginDefaultOrg:                featureSourceToFlagPb(&f.LoginDefaultOrg),
+		UserSchema:                     featureSourceToFlagPb(&f.UserSchema),
+		OidcTokenExchange:              featureSourceToFlagPb(&f.TokenExchange),
+		ImprovedPerformance:            featureSourceToImprovedPerformanceFlagPb(&f.ImprovedPerformance),
+		OidcSingleV1SessionTermination: featureSourceToFlagPb(&f.OIDCSingleV1SessionTermination),
 	}
 }
 
 func instanceFeaturesToCommand(req *feature_pb.SetInstanceFeaturesRequest) *command.InstanceFeatures {
 	return &command.InstanceFeatures{
-		LoginDefaultOrg:                 req.LoginDefaultOrg,
-		TriggerIntrospectionProjections: req.OidcTriggerIntrospectionProjections,
-		UserSchema:                      req.UserSchema,
-		TokenExchange:                   req.OidcTokenExchange,
-		ImprovedPerformance:             improvedPerformanceListToDomain(req.ImprovedPerformance),
-		DebugOIDCParentError:            req.DebugOidcParentError,
-		OIDCSingleV1SessionTermination:  req.OidcSingleV1SessionTermination,
+		LoginDefaultOrg:                req.LoginDefaultOrg,
+		UserSchema:                     req.UserSchema,
+		TokenExchange:                  req.OidcTokenExchange,
+		ImprovedPerformance:            improvedPerformanceListToDomain(req.ImprovedPerformance),
+		DebugOIDCParentError:           req.DebugOidcParentError,
+		OIDCSingleV1SessionTermination: req.OidcSingleV1SessionTermination,
 	}
 }
 
 func instanceFeaturesToPb(f *query.InstanceFeatures) *feature_pb.GetInstanceFeaturesResponse {
 	return &feature_pb.GetInstanceFeaturesResponse{
-		Details:                             object.DomainToDetailsPb(f.Details),
-		LoginDefaultOrg:                     featureSourceToFlagPb(&f.LoginDefaultOrg),
-		OidcTriggerIntrospectionProjections: featureSourceToFlagPb(&f.TriggerIntrospectionProjections),
-		UserSchema:                          featureSourceToFlagPb(&f.UserSchema),
-		OidcTokenExchange:                   featureSourceToFlagPb(&f.TokenExchange),
-		ImprovedPerformance:                 featureSourceToImprovedPerformanceFlagPb(&f.ImprovedPerformance),
-		DebugOidcParentError:                featureSourceToFlagPb(&f.DebugOIDCParentError),
-		OidcSingleV1SessionTermination:      featureSourceToFlagPb(&f.OIDCSingleV1SessionTermination),
+		Details:                        object.DomainToDetailsPb(f.Details),
+		LoginDefaultOrg:                featureSourceToFlagPb(&f.LoginDefaultOrg),
+		UserSchema:                     featureSourceToFlagPb(&f.UserSchema),
+		OidcTokenExchange:              featureSourceToFlagPb(&f.TokenExchange),
+		ImprovedPerformance:            featureSourceToImprovedPerformanceFlagPb(&f.ImprovedPerformance),
+		DebugOidcParentError:           featureSourceToFlagPb(&f.DebugOIDCParentError),
+		OidcSingleV1SessionTermination: featureSourceToFlagPb(&f.OIDCSingleV1SessionTermination),
 	}
 }
 

internal/api/grpc/feature/v2beta/converter_test.go

@@ -18,20 +18,18 @@ import (
 
 func Test_systemFeaturesToCommand(t *testing.T) {
 	arg := &feature_pb.SetSystemFeaturesRequest{
-		LoginDefaultOrg:                     gu.Ptr(true),
-		OidcTriggerIntrospectionProjections: gu.Ptr(false),
-		UserSchema:                          gu.Ptr(true),
-		OidcTokenExchange:                   gu.Ptr(true),
-		ImprovedPerformance:                 nil,
-		OidcSingleV1SessionTermination:      gu.Ptr(true),
+		LoginDefaultOrg:                gu.Ptr(true),
+		UserSchema:                     gu.Ptr(true),
+		OidcTokenExchange:              gu.Ptr(true),
+		ImprovedPerformance:            nil,
+		OidcSingleV1SessionTermination: gu.Ptr(true),
 	}
 	want := &command.SystemFeatures{
-		LoginDefaultOrg:                 gu.Ptr(true),
-		TriggerIntrospectionProjections: gu.Ptr(false),
-		UserSchema:                      gu.Ptr(true),
-		TokenExchange:                   gu.Ptr(true),
-		ImprovedPerformance:             nil,
-		OIDCSingleV1SessionTermination:  gu.Ptr(true),
+		LoginDefaultOrg:                gu.Ptr(true),
+		UserSchema:                     gu.Ptr(true),
+		TokenExchange:                  gu.Ptr(true),
+		ImprovedPerformance:            nil,
+		OIDCSingleV1SessionTermination: gu.Ptr(true),
 	}
 	got := systemFeaturesToCommand(arg)
 	assert.Equal(t, want, got)
@@ -48,10 +46,6 @@ func Test_systemFeaturesToPb(t *testing.T) {
 			Level: feature.LevelSystem,
 			Value: true,
 		},
-		TriggerIntrospectionProjections: query.FeatureSource[bool]{
-			Level: feature.LevelUnspecified,
-			Value: false,
-		},
 		UserSchema: query.FeatureSource[bool]{
 			Level: feature.LevelSystem,
 			Value: true,
@@ -79,10 +73,6 @@ func Test_systemFeaturesToPb(t *testing.T) {
 			Enabled: true,
 			Source:  feature_pb.Source_SOURCE_SYSTEM,
 		},
-		OidcTriggerIntrospectionProjections: &feature_pb.FeatureFlag{
-			Enabled: false,
-			Source:  feature_pb.Source_SOURCE_UNSPECIFIED,
-		},
 		UserSchema: &feature_pb.FeatureFlag{
 			Enabled: true,
 			Source:  feature_pb.Source_SOURCE_SYSTEM,
@@ -106,20 +96,18 @@ func Test_systemFeaturesToPb(t *testing.T) {
 
 func Test_instanceFeaturesToCommand(t *testing.T) {
 	arg := &feature_pb.SetInstanceFeaturesRequest{
-		LoginDefaultOrg:                     gu.Ptr(true),
-		OidcTriggerIntrospectionProjections: gu.Ptr(false),
-		UserSchema:                          gu.Ptr(true),
-		OidcTokenExchange:                   gu.Ptr(true),
-		ImprovedPerformance:                 nil,
-		OidcSingleV1SessionTermination:      gu.Ptr(true),
+		LoginDefaultOrg:                gu.Ptr(true),
+		UserSchema:                     gu.Ptr(true),
+		OidcTokenExchange:              gu.Ptr(true),
+		ImprovedPerformance:            nil,
+		OidcSingleV1SessionTermination: gu.Ptr(true),
 	}
 	want := &command.InstanceFeatures{
-		LoginDefaultOrg:                 gu.Ptr(true),
-		TriggerIntrospectionProjections: gu.Ptr(false),
-		UserSchema:                      gu.Ptr(true),
-		TokenExchange:                   gu.Ptr(true),
-		ImprovedPerformance:             nil,
-		OIDCSingleV1SessionTermination:  gu.Ptr(true),
+		LoginDefaultOrg:                gu.Ptr(true),
+		UserSchema:                     gu.Ptr(true),
+		TokenExchange:                  gu.Ptr(true),
+		ImprovedPerformance:            nil,
+		OIDCSingleV1SessionTermination: gu.Ptr(true),
 	}
 	got := instanceFeaturesToCommand(arg)
 	assert.Equal(t, want, got)
@@ -136,10 +124,6 @@ func Test_instanceFeaturesToPb(t *testing.T) {
 			Level: feature.LevelSystem,
 			Value: true,
 		},
-		TriggerIntrospectionProjections: query.FeatureSource[bool]{
-			Level: feature.LevelUnspecified,
-			Value: false,
-		},
 		UserSchema: query.FeatureSource[bool]{
 			Level: feature.LevelInstance,
 			Value: true,
@@ -167,10 +151,6 @@ func Test_instanceFeaturesToPb(t *testing.T) {
 			Enabled: true,
 			Source:  feature_pb.Source_SOURCE_SYSTEM,
 		},
-		OidcTriggerIntrospectionProjections: &feature_pb.FeatureFlag{
-			Enabled: false,
-			Source:  feature_pb.Source_SOURCE_UNSPECIFIED,
-		},
 		UserSchema: &feature_pb.FeatureFlag{
 			Enabled: true,
 			Source:  feature_pb.Source_SOURCE_INSTANCE,

internal/api/grpc/feature/v2beta/integration_test/feature_test.go

@@ -61,7 +61,7 @@ func TestServer_SetInstanceFeatures(t *testing.T) {
 			args: args{
 				ctx: OrgCTX,
 				req: &feature.SetInstanceFeaturesRequest{
-					OidcTriggerIntrospectionProjections: gu.Ptr(true),
+					LoginDefaultOrg: gu.Ptr(true),
 				},
 			},
 			wantErr: true,
@@ -79,7 +79,7 @@ func TestServer_SetInstanceFeatures(t *testing.T) {
 			args: args{
 				ctx: IamCTX,
 				req: &feature.SetInstanceFeaturesRequest{
-					OidcTriggerIntrospectionProjections: gu.Ptr(true),
+					LoginDefaultOrg: gu.Ptr(true),
 				},
 			},
 			want: &feature.SetInstanceFeaturesResponse{
@@ -190,10 +190,6 @@ func TestServer_GetInstanceFeatures(t *testing.T) {
 					Enabled: false,
 					Source:  feature.Source_SOURCE_UNSPECIFIED,
 				},
-				OidcTriggerIntrospectionProjections: &feature.FeatureFlag{
-					Enabled: false,
-					Source:  feature.Source_SOURCE_UNSPECIFIED,
-				},
 				UserSchema: &feature.FeatureFlag{
 					Enabled: false,
 					Source:  feature.Source_SOURCE_UNSPECIFIED,
@@ -204,9 +200,8 @@ func TestServer_GetInstanceFeatures(t *testing.T) {
 			name: "some features, no inheritance",
 			prepare: func(t *testing.T) {
 				_, err := Client.SetInstanceFeatures(IamCTX, &feature.SetInstanceFeaturesRequest{
-					LoginDefaultOrg:                     gu.Ptr(true),
-					OidcTriggerIntrospectionProjections: gu.Ptr(false),
-					UserSchema:                          gu.Ptr(true),
+					LoginDefaultOrg: gu.Ptr(true),
+					UserSchema:      gu.Ptr(true),
 				})
 				require.NoError(t, err)
 			},
@@ -219,10 +214,6 @@ func TestServer_GetInstanceFeatures(t *testing.T) {
 					Enabled: true,
 					Source:  feature.Source_SOURCE_INSTANCE,
 				},
-				OidcTriggerIntrospectionProjections: &feature.FeatureFlag{
-					Enabled: false,
-					Source:  feature.Source_SOURCE_INSTANCE,
-				},
 				UserSchema: &feature.FeatureFlag{
 					Enabled: true,
 					Source:  feature.Source_SOURCE_INSTANCE,
@@ -248,10 +239,6 @@ func TestServer_GetInstanceFeatures(t *testing.T) {
 					Enabled: true,
 					Source:  feature.Source_SOURCE_INSTANCE,
 				},
-				OidcTriggerIntrospectionProjections: &feature.FeatureFlag{
-					Enabled: false,
-					Source:  feature.Source_SOURCE_UNSPECIFIED,
-				},
 				UserSchema: &feature.FeatureFlag{
 					Enabled: false,
 					Source:  feature.Source_SOURCE_UNSPECIFIED,
@@ -276,7 +263,6 @@ func TestServer_GetInstanceFeatures(t *testing.T) {
 			}
 			require.NoError(t, err)
 			assertFeatureFlag(t, tt.want.LoginDefaultOrg, got.LoginDefaultOrg)
-			assertFeatureFlag(t, tt.want.OidcTriggerIntrospectionProjections, got.OidcTriggerIntrospectionProjections)
 			assertFeatureFlag(t, tt.want.UserSchema, got.UserSchema)
 		})
 	}