chore(oidc): remove feature flag for introspection triggers (#10132)

# Which Problems Are Solved Remove the feature flag that allowed triggers in introspection. This option was a fallback in case introspection would not function properly without triggers. The API documentation asked for anyone using this flag to raise an issue. No such issue was received, hence we concluded it is safe to remove it. # How the Problems Are Solved - Remove flags from the system and instance level feature APIs. - Remove trigger functions that are no longer used - Adjust tests that used the flag. # Additional Changes - none # Additional Context - Closes #10026 - Flag was introduced in #7356 --------- Co-authored-by: Silvan <27845747+adlerhurst@users.noreply.github.com>
2025-08-11 17:27:31 +00:00 · 2025-06-30 08:48:04 +03:00
parent 14b45b58eb
commit 4cd52f33eb
57 changed files with 247 additions and 659 deletions
--- a/internal/command/instance_features.go
+++ b/internal/command/instance_features.go
@@ -13,23 +13,21 @@ import (
 )

 type InstanceFeatures struct {
-	LoginDefaultOrg                 *bool
-	TriggerIntrospectionProjections *bool
-	UserSchema                      *bool
-	TokenExchange                   *bool
-	ImprovedPerformance             []feature.ImprovedPerformanceType
-	DebugOIDCParentError            *bool
-	OIDCSingleV1SessionTermination  *bool
-	DisableUserTokenEvent           *bool
-	EnableBackChannelLogout         *bool
-	LoginV2                         *feature.LoginV2
-	PermissionCheckV2               *bool
-	ConsoleUseV2UserApi             *bool
+	LoginDefaultOrg                *bool
+	UserSchema                     *bool
+	TokenExchange                  *bool
+	ImprovedPerformance            []feature.ImprovedPerformanceType
+	DebugOIDCParentError           *bool
+	OIDCSingleV1SessionTermination *bool
+	DisableUserTokenEvent          *bool
+	EnableBackChannelLogout        *bool
+	LoginV2                        *feature.LoginV2
+	PermissionCheckV2              *bool
+	ConsoleUseV2UserApi            *bool
 }

 func (m *InstanceFeatures) isEmpty() bool {
 	return m.LoginDefaultOrg == nil &&
-		m.TriggerIntrospectionProjections == nil &&
 		m.UserSchema == nil &&
 		m.TokenExchange == nil &&
 		// nil check to allow unset improvements
--- a/internal/command/instance_features_model.go
+++ b/internal/command/instance_features_model.go
@@ -67,7 +67,6 @@ func (m *InstanceFeaturesWriteModel) Query() *eventstore.SearchQueryBuilder {
 			feature_v1.DefaultLoginInstanceEventType,
 			feature_v2.InstanceResetEventType,
 			feature_v2.InstanceLoginDefaultOrgEventType,
-			feature_v2.InstanceTriggerIntrospectionProjectionsEventType,
 			feature_v2.InstanceUserSchemaEventType,
 			feature_v2.InstanceTokenExchangeEventType,
 			feature_v2.InstanceImprovedPerformanceEventType,
@@ -93,9 +92,6 @@ func reduceInstanceFeature(features *InstanceFeatures, key feature.Key, value an
 	case feature.KeyLoginDefaultOrg:
 		v := value.(bool)
 		features.LoginDefaultOrg = &v
-	case feature.KeyTriggerIntrospectionProjections:
-		v := value.(bool)
-		features.TriggerIntrospectionProjections = &v
 	case feature.KeyTokenExchange:
 		v := value.(bool)
 		features.TokenExchange = &v
@@ -132,7 +128,6 @@ func (wm *InstanceFeaturesWriteModel) setCommands(ctx context.Context, f *Instan
 	aggregate := feature_v2.NewAggregate(wm.AggregateID, wm.ResourceOwner)
 	cmds := make([]eventstore.Command, 0, len(feature.KeyValues())-1)
 	cmds = appendFeatureUpdate(ctx, cmds, aggregate, wm.LoginDefaultOrg, f.LoginDefaultOrg, feature_v2.InstanceLoginDefaultOrgEventType)
-	cmds = appendFeatureUpdate(ctx, cmds, aggregate, wm.TriggerIntrospectionProjections, f.TriggerIntrospectionProjections, feature_v2.InstanceTriggerIntrospectionProjectionsEventType)
 	cmds = appendFeatureUpdate(ctx, cmds, aggregate, wm.TokenExchange, f.TokenExchange, feature_v2.InstanceTokenExchangeEventType)
 	cmds = appendFeatureUpdate(ctx, cmds, aggregate, wm.UserSchema, f.UserSchema, feature_v2.InstanceUserSchemaEventType)
 	cmds = appendFeatureSliceUpdate(ctx, cmds, aggregate, wm.ImprovedPerformance, f.ImprovedPerformance, feature_v2.InstanceImprovedPerformanceEventType)
--- a/internal/command/instance_features_test.go
+++ b/internal/command/instance_features_test.go
@@ -95,24 +95,6 @@ func TestCommands_SetInstanceFeatures(t *testing.T) {
 				ResourceOwner: "instance1",
 			},
 		},
-		{
-			name: "set TriggerIntrospectionProjections",
-			eventstore: expectEventstore(
-				expectFilter(),
-				expectPush(
-					feature_v2.NewSetEvent[bool](
-						ctx, aggregate,
-						feature_v2.InstanceTriggerIntrospectionProjectionsEventType, true,
-					),
-				),
-			),
-			args: args{ctx, &InstanceFeatures{
-				TriggerIntrospectionProjections: gu.Ptr(true),
-			}},
-			want: &domain.ObjectDetails{
-				ResourceOwner: "instance1",
-			},
-		},
 		{
 			name: "set UserSchema",
 			eventstore: expectEventstore(
@@ -156,10 +138,6 @@ func TestCommands_SetInstanceFeatures(t *testing.T) {
 						ctx, aggregate,
 						feature_v2.InstanceLoginDefaultOrgEventType, true,
 					),
-					feature_v2.NewSetEvent[bool](
-						ctx, aggregate,
-						feature_v2.InstanceTriggerIntrospectionProjectionsEventType, false,
-					),
 					feature_v2.NewSetEvent[bool](
 						ctx, aggregate,
 						feature_v2.InstanceUserSchemaEventType, true,
@@ -171,10 +149,9 @@ func TestCommands_SetInstanceFeatures(t *testing.T) {
 				),
 			),
 			args: args{ctx, &InstanceFeatures{
-				LoginDefaultOrg:                 gu.Ptr(true),
-				TriggerIntrospectionProjections: gu.Ptr(false),
-				UserSchema:                      gu.Ptr(true),
-				OIDCSingleV1SessionTermination:  gu.Ptr(true),
+				LoginDefaultOrg:                gu.Ptr(true),
+				UserSchema:                     gu.Ptr(true),
+				OIDCSingleV1SessionTermination: gu.Ptr(true),
 			}},
 			want: &domain.ObjectDetails{
 				ResourceOwner: "instance1",
@@ -189,10 +166,6 @@ func TestCommands_SetInstanceFeatures(t *testing.T) {
 						ctx, aggregate,
 						feature_v2.InstanceLoginDefaultOrgEventType, true,
 					)),
-					eventFromEventPusher(feature_v2.NewSetEvent[bool](
-						ctx, aggregate,
-						feature_v2.InstanceTriggerIntrospectionProjectionsEventType, false,
-					)),
 					eventFromEventPusher(feature_v2.NewResetEvent(
 						ctx, aggregate,
 						feature_v2.InstanceResetEventType,
@@ -211,16 +184,11 @@ func TestCommands_SetInstanceFeatures(t *testing.T) {
 						ctx, aggregate,
 						feature_v2.InstanceLoginDefaultOrgEventType, true,
 					),
-					feature_v2.NewSetEvent[bool](
-						ctx, aggregate,
-						feature_v2.InstanceTriggerIntrospectionProjectionsEventType, false,
-					),
 				),
 			),
 			args: args{ctx, &InstanceFeatures{
-				LoginDefaultOrg:                 gu.Ptr(true),
-				TriggerIntrospectionProjections: gu.Ptr(false),
-				OIDCSingleV1SessionTermination:  gu.Ptr(false),
+				LoginDefaultOrg:                gu.Ptr(true),
+				OIDCSingleV1SessionTermination: gu.Ptr(false),
 			}},
 			want: &domain.ObjectDetails{
 				ResourceOwner: "instance1",
--- a/internal/command/system_features.go
+++ b/internal/command/system_features.go
@@ -10,21 +10,19 @@ import (
 )

 type SystemFeatures struct {
-	LoginDefaultOrg                 *bool
-	TriggerIntrospectionProjections *bool
-	TokenExchange                   *bool
-	UserSchema                      *bool
-	ImprovedPerformance             []feature.ImprovedPerformanceType
-	OIDCSingleV1SessionTermination  *bool
-	DisableUserTokenEvent           *bool
-	EnableBackChannelLogout         *bool
-	LoginV2                         *feature.LoginV2
-	PermissionCheckV2               *bool
+	LoginDefaultOrg                *bool
+	TokenExchange                  *bool
+	UserSchema                     *bool
+	ImprovedPerformance            []feature.ImprovedPerformanceType
+	OIDCSingleV1SessionTermination *bool
+	DisableUserTokenEvent          *bool
+	EnableBackChannelLogout        *bool
+	LoginV2                        *feature.LoginV2
+	PermissionCheckV2              *bool
 }

 func (m *SystemFeatures) isEmpty() bool {
 	return m.LoginDefaultOrg == nil &&
-		m.TriggerIntrospectionProjections == nil &&
 		m.UserSchema == nil &&
 		m.TokenExchange == nil &&
 		// nil check to allow unset improvements
--- a/internal/command/system_features_model.go
+++ b/internal/command/system_features_model.go
@@ -60,7 +60,6 @@ func (m *SystemFeaturesWriteModel) Query() *eventstore.SearchQueryBuilder {
 		EventTypes(
 			feature_v2.SystemResetEventType,
 			feature_v2.SystemLoginDefaultOrgEventType,
-			feature_v2.SystemTriggerIntrospectionProjectionsEventType,
 			feature_v2.SystemUserSchemaEventType,
 			feature_v2.SystemTokenExchangeEventType,
 			feature_v2.SystemImprovedPerformanceEventType,
@@ -84,9 +83,6 @@ func reduceSystemFeature(features *SystemFeatures, key feature.Key, value any) {
 	case feature.KeyLoginDefaultOrg:
 		v := value.(bool)
 		features.LoginDefaultOrg = &v
-	case feature.KeyTriggerIntrospectionProjections:
-		v := value.(bool)
-		features.TriggerIntrospectionProjections = &v
 	case feature.KeyUserSchema:
 		v := value.(bool)
 		features.UserSchema = &v
@@ -116,7 +112,6 @@ func (wm *SystemFeaturesWriteModel) setCommands(ctx context.Context, f *SystemFe
 	aggregate := feature_v2.NewAggregate(wm.AggregateID, wm.ResourceOwner)
 	cmds := make([]eventstore.Command, 0, len(feature.KeyValues())-1)
 	cmds = appendFeatureUpdate(ctx, cmds, aggregate, wm.LoginDefaultOrg, f.LoginDefaultOrg, feature_v2.SystemLoginDefaultOrgEventType)
-	cmds = appendFeatureUpdate(ctx, cmds, aggregate, wm.TriggerIntrospectionProjections, f.TriggerIntrospectionProjections, feature_v2.SystemTriggerIntrospectionProjectionsEventType)
 	cmds = appendFeatureUpdate(ctx, cmds, aggregate, wm.UserSchema, f.UserSchema, feature_v2.SystemUserSchemaEventType)
 	cmds = appendFeatureUpdate(ctx, cmds, aggregate, wm.TokenExchange, f.TokenExchange, feature_v2.SystemTokenExchangeEventType)
 	cmds = appendFeatureSliceUpdate(ctx, cmds, aggregate, wm.ImprovedPerformance, f.ImprovedPerformance, feature_v2.SystemImprovedPerformanceEventType)
--- a/internal/command/system_features_test.go
+++ b/internal/command/system_features_test.go
@@ -63,24 +63,6 @@ func TestCommands_SetSystemFeatures(t *testing.T) {
 				ResourceOwner: "SYSTEM",
 			},
 		},
-		{
-			name: "set TriggerIntrospectionProjections",
-			eventstore: expectEventstore(
-				expectFilter(),
-				expectPush(
-					feature_v2.NewSetEvent[bool](
-						context.Background(), aggregate,
-						feature_v2.SystemTriggerIntrospectionProjectionsEventType, true,
-					),
-				),
-			),
-			args: args{context.Background(), &SystemFeatures{
-				TriggerIntrospectionProjections: gu.Ptr(true),
-			}},
-			want: &domain.ObjectDetails{
-				ResourceOwner: "SYSTEM",
-			},
-		},
 		{
 			name: "set UserSchema",
 			eventstore: expectEventstore(
@@ -124,10 +106,6 @@ func TestCommands_SetSystemFeatures(t *testing.T) {
 						context.Background(), aggregate,
 						feature_v2.SystemLoginDefaultOrgEventType, true,
 					),
-					feature_v2.NewSetEvent[bool](
-						context.Background(), aggregate,
-						feature_v2.SystemTriggerIntrospectionProjectionsEventType, false,
-					),
 					feature_v2.NewSetEvent[bool](
 						context.Background(), aggregate,
 						feature_v2.SystemUserSchemaEventType, true,
@@ -139,10 +117,9 @@ func TestCommands_SetSystemFeatures(t *testing.T) {
 				),
 			),
 			args: args{context.Background(), &SystemFeatures{
-				LoginDefaultOrg:                 gu.Ptr(true),
-				TriggerIntrospectionProjections: gu.Ptr(false),
-				UserSchema:                      gu.Ptr(true),
-				OIDCSingleV1SessionTermination:  gu.Ptr(true),
+				LoginDefaultOrg:                gu.Ptr(true),
+				UserSchema:                     gu.Ptr(true),
+				OIDCSingleV1SessionTermination: gu.Ptr(true),
 			}},
 			want: &domain.ObjectDetails{
 				ResourceOwner: "SYSTEM",
@@ -157,10 +134,6 @@ func TestCommands_SetSystemFeatures(t *testing.T) {
 						context.Background(), aggregate,
 						feature_v2.SystemLoginDefaultOrgEventType, true,
 					)),
-					eventFromEventPusher(feature_v2.NewSetEvent[bool](
-						context.Background(), aggregate,
-						feature_v2.SystemTriggerIntrospectionProjectionsEventType, false,
-					)),
 					eventFromEventPusher(feature_v2.NewResetEvent(
 						context.Background(), aggregate,
 						feature_v2.SystemResetEventType,
@@ -175,10 +148,6 @@ func TestCommands_SetSystemFeatures(t *testing.T) {
 						context.Background(), aggregate,
 						feature_v2.SystemLoginDefaultOrgEventType, true,
 					),
-					feature_v2.NewSetEvent[bool](
-						context.Background(), aggregate,
-						feature_v2.SystemTriggerIntrospectionProjectionsEventType, false,
-					),
 					feature_v2.NewSetEvent[bool](
 						context.Background(), aggregate,
 						feature_v2.SystemUserSchemaEventType, true,
@@ -190,10 +159,9 @@ func TestCommands_SetSystemFeatures(t *testing.T) {
 				),
 			),
 			args: args{context.Background(), &SystemFeatures{
-				LoginDefaultOrg:                 gu.Ptr(true),
-				TriggerIntrospectionProjections: gu.Ptr(false),
-				UserSchema:                      gu.Ptr(true),
-				OIDCSingleV1SessionTermination:  gu.Ptr(false),
+				LoginDefaultOrg:                gu.Ptr(true),
+				UserSchema:                     gu.Ptr(true),
+				OIDCSingleV1SessionTermination: gu.Ptr(false),
 			}},
 			want: &domain.ObjectDetails{
 				ResourceOwner: "SYSTEM",