chore(oidc): remove feature flag for introspection triggers (#10132)

# Which Problems Are Solved Remove the feature flag that allowed triggers in introspection. This option was a fallback in case introspection would not function properly without triggers. The API documentation asked for anyone using this flag to raise an issue. No such issue was received, hence we concluded it is safe to remove it. # How the Problems Are Solved - Remove flags from the system and instance level feature APIs. - Remove trigger functions that are no longer used - Adjust tests that used the flag. # Additional Changes - none # Additional Context - Closes #10026 - Flag was introduced in #7356 --------- Co-authored-by: Silvan <27845747+adlerhurst@users.noreply.github.com>
2025-12-06 14:32:28 +00:00 · 2025-06-30 08:48:04 +03:00
parent 14b45b58eb
commit 4cd52f33eb
57 changed files with 247 additions and 659 deletions
--- a/internal/query/instance_features.go
+++ b/internal/query/instance_features.go
@@ -8,19 +8,18 @@ import (
 )

 type InstanceFeatures struct {
-	Details                         *domain.ObjectDetails
-	LoginDefaultOrg                 FeatureSource[bool]
-	TriggerIntrospectionProjections FeatureSource[bool]
-	UserSchema                      FeatureSource[bool]
-	TokenExchange                   FeatureSource[bool]
-	ImprovedPerformance             FeatureSource[[]feature.ImprovedPerformanceType]
-	DebugOIDCParentError            FeatureSource[bool]
-	OIDCSingleV1SessionTermination  FeatureSource[bool]
-	DisableUserTokenEvent           FeatureSource[bool]
-	EnableBackChannelLogout         FeatureSource[bool]
-	LoginV2                         FeatureSource[*feature.LoginV2]
-	PermissionCheckV2               FeatureSource[bool]
-	ConsoleUseV2UserApi             FeatureSource[bool]
+	Details                        *domain.ObjectDetails
+	LoginDefaultOrg                FeatureSource[bool]
+	UserSchema                     FeatureSource[bool]
+	TokenExchange                  FeatureSource[bool]
+	ImprovedPerformance            FeatureSource[[]feature.ImprovedPerformanceType]
+	DebugOIDCParentError           FeatureSource[bool]
+	OIDCSingleV1SessionTermination FeatureSource[bool]
+	DisableUserTokenEvent          FeatureSource[bool]
+	EnableBackChannelLogout        FeatureSource[bool]
+	LoginV2                        FeatureSource[*feature.LoginV2]
+	PermissionCheckV2              FeatureSource[bool]
+	ConsoleUseV2UserApi            FeatureSource[bool]
 }

 func (q *Queries) GetInstanceFeatures(ctx context.Context, cascade bool) (_ *InstanceFeatures, err error) {
--- a/internal/query/instance_features_model.go
+++ b/internal/query/instance_features_model.go
@@ -63,7 +63,6 @@ func (m *InstanceFeaturesReadModel) Query() *eventstore.SearchQueryBuilder {
 			feature_v1.DefaultLoginInstanceEventType,
 			feature_v2.InstanceResetEventType,
 			feature_v2.InstanceLoginDefaultOrgEventType,
-			feature_v2.InstanceTriggerIntrospectionProjectionsEventType,
 			feature_v2.InstanceUserSchemaEventType,
 			feature_v2.InstanceTokenExchangeEventType,
 			feature_v2.InstanceImprovedPerformanceEventType,
@@ -91,7 +90,6 @@ func (m *InstanceFeaturesReadModel) populateFromSystem() bool {
 		return false
 	}
 	m.instance.LoginDefaultOrg = m.system.LoginDefaultOrg
-	m.instance.TriggerIntrospectionProjections = m.system.TriggerIntrospectionProjections
 	m.instance.UserSchema = m.system.UserSchema
 	m.instance.TokenExchange = m.system.TokenExchange
 	m.instance.ImprovedPerformance = m.system.ImprovedPerformance
@@ -112,8 +110,6 @@ func reduceInstanceFeatureSet[T any](features *InstanceFeatures, event *feature_
 		return nil
 	case feature.KeyLoginDefaultOrg:
 		features.LoginDefaultOrg.set(level, event.Value)
-	case feature.KeyTriggerIntrospectionProjections:
-		features.TriggerIntrospectionProjections.set(level, event.Value)
 	case feature.KeyUserSchema:
 		features.UserSchema.set(level, event.Value)
 	case feature.KeyTokenExchange:
--- a/internal/query/instance_features_test.go
+++ b/internal/query/instance_features_test.go
@@ -71,10 +71,6 @@ func TestQueries_GetInstanceFeatures(t *testing.T) {
 					Level: feature.LevelUnspecified,
 					Value: false,
 				},
-				TriggerIntrospectionProjections: FeatureSource[bool]{
-					Level: feature.LevelUnspecified,
-					Value: false,
-				},
 			},
 		},
 		{
@@ -89,10 +85,6 @@ func TestQueries_GetInstanceFeatures(t *testing.T) {
 						ctx, aggregate,
 						feature_v2.InstanceLoginDefaultOrgEventType, false,
 					)),
-					eventFromEventPusher(feature_v2.NewSetEvent(
-						ctx, aggregate,
-						feature_v2.InstanceTriggerIntrospectionProjectionsEventType, true,
-					)),
 					eventFromEventPusher(feature_v2.NewSetEvent(
 						ctx, aggregate,
 						feature_v2.InstanceUserSchemaEventType, false,
@@ -108,10 +100,6 @@ func TestQueries_GetInstanceFeatures(t *testing.T) {
 					Level: feature.LevelInstance,
 					Value: false,
 				},
-				TriggerIntrospectionProjections: FeatureSource[bool]{
-					Level: feature.LevelInstance,
-					Value: true,
-				},
 				UserSchema: FeatureSource[bool]{
 					Level: feature.LevelInstance,
 					Value: false,
@@ -130,10 +118,6 @@ func TestQueries_GetInstanceFeatures(t *testing.T) {
 						ctx, aggregate,
 						feature_v2.InstanceLoginDefaultOrgEventType, false,
 					)),
-					eventFromEventPusher(feature_v2.NewSetEvent(
-						ctx, aggregate,
-						feature_v2.InstanceTriggerIntrospectionProjectionsEventType, true,
-					)),
 					eventFromEventPusher(feature_v2.NewSetEvent(
 						ctx, aggregate,
 						feature_v2.InstanceUserSchemaEventType, false,
@@ -142,10 +126,6 @@ func TestQueries_GetInstanceFeatures(t *testing.T) {
 						ctx, aggregate,
 						feature_v2.InstanceResetEventType,
 					)),
-					eventFromEventPusher(feature_v2.NewSetEvent(
-						ctx, aggregate,
-						feature_v2.InstanceTriggerIntrospectionProjectionsEventType, true,
-					)),
 				),
 			),
 			args: args{true},
@@ -157,10 +137,6 @@ func TestQueries_GetInstanceFeatures(t *testing.T) {
 					Level: feature.LevelSystem,
 					Value: true,
 				},
-				TriggerIntrospectionProjections: FeatureSource[bool]{
-					Level: feature.LevelInstance,
-					Value: true,
-				},
 				UserSchema: FeatureSource[bool]{
 					Level: feature.LevelUnspecified,
 					Value: false,
@@ -175,10 +151,6 @@ func TestQueries_GetInstanceFeatures(t *testing.T) {
 						ctx, aggregate,
 						feature_v2.InstanceLoginDefaultOrgEventType, false,
 					)),
-					eventFromEventPusher(feature_v2.NewSetEvent(
-						ctx, aggregate,
-						feature_v2.InstanceTriggerIntrospectionProjectionsEventType, true,
-					)),
 					eventFromEventPusher(feature_v2.NewSetEvent(
 						ctx, aggregate,
 						feature_v2.InstanceUserSchemaEventType, false,
@@ -187,10 +159,6 @@ func TestQueries_GetInstanceFeatures(t *testing.T) {
 						ctx, aggregate,
 						feature_v2.InstanceResetEventType,
 					)),
-					eventFromEventPusher(feature_v2.NewSetEvent(
-						ctx, aggregate,
-						feature_v2.InstanceTriggerIntrospectionProjectionsEventType, true,
-					)),
 				),
 			),
 			args: args{false},
@@ -202,10 +170,6 @@ func TestQueries_GetInstanceFeatures(t *testing.T) {
 					Level: feature.LevelUnspecified,
 					Value: false,
 				},
-				TriggerIntrospectionProjections: FeatureSource[bool]{
-					Level: feature.LevelInstance,
-					Value: true,
-				},
 				UserSchema: FeatureSource[bool]{
 					Level: feature.LevelUnspecified,
 					Value: false,
--- a/internal/query/introspection.go
+++ b/internal/query/introspection.go
@@ -25,12 +25,6 @@ var introspectionTriggerHandlers = sync.OnceValue(func() []*handler.Handler {
 	)
 })

-// TriggerIntrospectionProjections triggers all projections
-// relevant to introspection queries concurrently.
-func TriggerIntrospectionProjections(ctx context.Context) {
-	triggerBatch(ctx, introspectionTriggerHandlers()...)
-}
-
 type AppType string

 const (
--- a/internal/query/projection/instance_features.go
+++ b/internal/query/projection/instance_features.go
@@ -64,10 +64,6 @@ func (*instanceFeatureProjection) Reducers() []handler.AggregateReducer {
 				Event:  feature_v2.InstanceLoginDefaultOrgEventType,
 				Reduce: reduceInstanceSetFeature[bool],
 			},
-			{
-				Event:  feature_v2.InstanceTriggerIntrospectionProjectionsEventType,
-				Reduce: reduceInstanceSetFeature[bool],
-			},
 			{
 				Event:  feature_v2.InstanceUserSchemaEventType,
 				Reduce: reduceInstanceSetFeature[bool],
--- a/internal/query/projection/system_features.go
+++ b/internal/query/projection/system_features.go
@@ -56,10 +56,6 @@ func (*systemFeatureProjection) Reducers() []handler.AggregateReducer {
 				Event:  feature_v2.SystemLoginDefaultOrgEventType,
 				Reduce: reduceSystemSetFeature[bool],
 			},
-			{
-				Event:  feature_v2.SystemTriggerIntrospectionProjectionsEventType,
-				Reduce: reduceSystemSetFeature[bool],
-			},
 			{
 				Event:  feature_v2.SystemUserSchemaEventType,
 				Reduce: reduceSystemSetFeature[bool],
--- a/internal/query/system_features.go
+++ b/internal/query/system_features.go
@@ -20,16 +20,15 @@ func (f *FeatureSource[T]) set(level feature.Level, value any) {
 type SystemFeatures struct {
 	Details *domain.ObjectDetails

-	LoginDefaultOrg                 FeatureSource[bool]
-	TriggerIntrospectionProjections FeatureSource[bool]
-	UserSchema                      FeatureSource[bool]
-	TokenExchange                   FeatureSource[bool]
-	ImprovedPerformance             FeatureSource[[]feature.ImprovedPerformanceType]
-	OIDCSingleV1SessionTermination  FeatureSource[bool]
-	DisableUserTokenEvent           FeatureSource[bool]
-	EnableBackChannelLogout         FeatureSource[bool]
-	LoginV2                         FeatureSource[*feature.LoginV2]
-	PermissionCheckV2               FeatureSource[bool]
+	LoginDefaultOrg                FeatureSource[bool]
+	UserSchema                     FeatureSource[bool]
+	TokenExchange                  FeatureSource[bool]
+	ImprovedPerformance            FeatureSource[[]feature.ImprovedPerformanceType]
+	OIDCSingleV1SessionTermination FeatureSource[bool]
+	DisableUserTokenEvent          FeatureSource[bool]
+	EnableBackChannelLogout        FeatureSource[bool]
+	LoginV2                        FeatureSource[*feature.LoginV2]
+	PermissionCheckV2              FeatureSource[bool]
 }

 func (q *Queries) GetSystemFeatures(ctx context.Context) (_ *SystemFeatures, err error) {
--- a/internal/query/system_features_model.go
+++ b/internal/query/system_features_model.go
@@ -56,7 +56,6 @@ func (m *SystemFeaturesReadModel) Query() *eventstore.SearchQueryBuilder {
 		EventTypes(
 			feature_v2.SystemResetEventType,
 			feature_v2.SystemLoginDefaultOrgEventType,
-			feature_v2.SystemTriggerIntrospectionProjectionsEventType,
 			feature_v2.SystemUserSchemaEventType,
 			feature_v2.SystemTokenExchangeEventType,
 			feature_v2.SystemImprovedPerformanceEventType,
@@ -84,8 +83,6 @@ func reduceSystemFeatureSet[T any](features *SystemFeatures, event *feature_v2.S
 		return nil
 	case feature.KeyLoginDefaultOrg:
 		features.LoginDefaultOrg.set(level, event.Value)
-	case feature.KeyTriggerIntrospectionProjections:
-		features.TriggerIntrospectionProjections.set(level, event.Value)
 	case feature.KeyUserSchema:
 		features.UserSchema.set(level, event.Value)
 	case feature.KeyTokenExchange:
--- a/internal/query/system_features_test.go
+++ b/internal/query/system_features_test.go
@@ -49,10 +49,6 @@ func TestQueries_GetSystemFeatures(t *testing.T) {
 						context.Background(), aggregate,
 						feature_v2.SystemLoginDefaultOrgEventType, false,
 					)),
-					eventFromEventPusher(feature_v2.NewSetEvent(
-						context.Background(), aggregate,
-						feature_v2.SystemTriggerIntrospectionProjectionsEventType, true,
-					)),
 					eventFromEventPusher(feature_v2.NewSetEvent(
 						context.Background(), aggregate,
 						feature_v2.SystemUserSchemaEventType, false,
@@ -67,10 +63,6 @@ func TestQueries_GetSystemFeatures(t *testing.T) {
 					Level: feature.LevelSystem,
 					Value: false,
 				},
-				TriggerIntrospectionProjections: FeatureSource[bool]{
-					Level: feature.LevelSystem,
-					Value: true,
-				},
 				UserSchema: FeatureSource[bool]{
 					Level: feature.LevelSystem,
 					Value: false,
@@ -85,10 +77,6 @@ func TestQueries_GetSystemFeatures(t *testing.T) {
 						context.Background(), aggregate,
 						feature_v2.SystemLoginDefaultOrgEventType, false,
 					)),
-					eventFromEventPusher(feature_v2.NewSetEvent(
-						context.Background(), aggregate,
-						feature_v2.SystemTriggerIntrospectionProjectionsEventType, true,
-					)),
 					eventFromEventPusher(feature_v2.NewSetEvent(
 						context.Background(), aggregate,
 						feature_v2.SystemUserSchemaEventType, false,
@@ -97,10 +85,6 @@ func TestQueries_GetSystemFeatures(t *testing.T) {
 						context.Background(), aggregate,
 						feature_v2.SystemResetEventType,
 					)),
-					eventFromEventPusher(feature_v2.NewSetEvent(
-						context.Background(), aggregate,
-						feature_v2.SystemTriggerIntrospectionProjectionsEventType, true,
-					)),
 				),
 			),
 			want: &SystemFeatures{
@@ -111,10 +95,6 @@ func TestQueries_GetSystemFeatures(t *testing.T) {
 					Level: feature.LevelUnspecified,
 					Value: false,
 				},
-				TriggerIntrospectionProjections: FeatureSource[bool]{
-					Level: feature.LevelSystem,
-					Value: true,
-				},
 				UserSchema: FeatureSource[bool]{
 					Level: feature.LevelUnspecified,
 					Value: false,
@@ -129,10 +109,6 @@ func TestQueries_GetSystemFeatures(t *testing.T) {
 						context.Background(), aggregate,
 						feature_v2.SystemLoginDefaultOrgEventType, false,
 					)),
-					eventFromEventPusher(feature_v2.NewSetEvent(
-						context.Background(), aggregate,
-						feature_v2.SystemTriggerIntrospectionProjectionsEventType, true,
-					)),
 					eventFromEventPusher(feature_v2.NewSetEvent(
 						context.Background(), aggregate,
 						feature_v2.SystemUserSchemaEventType, false,
@@ -141,10 +117,6 @@ func TestQueries_GetSystemFeatures(t *testing.T) {
 						context.Background(), aggregate,
 						feature_v2.SystemResetEventType,
 					)),
-					eventFromEventPusher(feature_v2.NewSetEvent(
-						context.Background(), aggregate,
-						feature_v2.SystemTriggerIntrospectionProjectionsEventType, true,
-					)),
 				),
 			),
 			want: &SystemFeatures{
@@ -155,10 +127,6 @@ func TestQueries_GetSystemFeatures(t *testing.T) {
 					Level: feature.LevelUnspecified,
 					Value: false,
 				},
-				TriggerIntrospectionProjections: FeatureSource[bool]{
-					Level: feature.LevelSystem,
-					Value: true,
-				},
 				UserSchema: FeatureSource[bool]{
 					Level: feature.LevelUnspecified,
 					Value: false,
--- a/internal/query/userinfo.go
+++ b/internal/query/userinfo.go
@@ -31,12 +31,6 @@ var oidcUserInfoTriggerHandlers = sync.OnceValue(func() []*handler.Handler {
 	}
 })

-// TriggerOIDCUserInfoProjections triggers all projections
-// relevant to userinfo queries concurrently.
-func TriggerOIDCUserInfoProjections(ctx context.Context) {
-	triggerBatch(ctx, oidcUserInfoTriggerHandlers()...)
-}
-
 var (
 	//go:embed userinfo_by_id.sql
 	oidcUserInfoQueryTmpl           string