From 576cdcc76a3c80c92785b9a9524e8e9362c5b1ee Mon Sep 17 00:00:00 2001
From: Elio Bischof <elio@zitadel.com>
Date: Wed, 16 Oct 2024 17:17:13 +0200
Subject: [PATCH] fail earlier

---
 .github/workflows/acceptance-tests.yml | 22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/acceptance-tests.yml b/.github/workflows/acceptance-tests.yml
index c20bed29534..43699aaf8c2 100644
--- a/.github/workflows/acceptance-tests.yml
+++ b/.github/workflows/acceptance-tests.yml
@@ -12,20 +12,34 @@ jobs:
     - name: Run Docker Compose and Install Dependencies in Parallel
       run: |
         echo "Start docker-compose in the background"
-        docker-compose -f ./acceptance/docker-compose.yaml up -d &
-        
+        docker compose -f ./acceptance/docker-compose.yaml up -d &
+        DOCKER_COMPOSE_PID=$!
+                
         echo "Install node_modules in the foreground"
         npm install -g pnpm && pnpm install
         
         echo "Generate and create a production build in the background"
         pnpm build &
+        GENERATE_BUILD_PID=$!
 
         echo "Install Playwright with browsers in the background"
         pnpm exec playwright install --with-deps &
+        PLAYWRIGHT_INSTALL_PID=$!
         
         echo "Wait for all background processes to complete"
-        wait
-    - name: Run Playwright tests
+        while true; do
+          wait -n $DOCKER_COMPOSE_PID $GENERATE_BUILD_PID $PLAYWRIGHT_INSTALL_PID
+          EXIT_STATUS=$?
+          if [ $EXIT_STATUS -ne 0 ]; then
+            echo "A background process failed with exit code $EXIT_STATUS."
+            exit $EXIT_STATUS
+          fi
+          # Exit the loop if all processes have finished
+          if ! kill -0 $DOCKER_COMPOSE_PID $GENERATE_BUILD_PID $PLAYWRIGHT_INSTALL_PID 2>/dev/null; then
+            break
+          fi
+        done
+    - name: Run Playwright Tests
       run: pnpm exec playwright test
     - uses: actions/upload-artifact@v4
       if: ${{ !cancelled() }}