TheArchive/zitadel
1
0
Fork 0
mirror of https://github.com/zitadel/zitadel.git synced 2025-08-12 07:57:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: fix flakiness in gofakeit usage with additional random string (#10385)

Browse Source 
# Which Problems Are Solved

Flakiness in integration tests regarding gofakeit functions, which
provided the same names on 2 different occasions.

# How the Problems Are Solved

Attach a random string to the provided names, so that they are not
dependent on the gofakeit code.

# Additional Changes

None

# Additional Context

None

---------

Co-authored-by: Marco A. <marco@zitadel.com>
This commit is contained in:
Stefan Benz
2025-08-07 15:27:01 +02:00
committed by GitHub
parent a96f4708cb
commit 6e8aa9a7d1
31 changed files with 700 additions and 665 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
internal/api/grpc/org/v2beta/integration_test/org_test.go
View File

@@ -99,7 +99,7 @@ func TestServer_CreateOrganization(t *testing.T) {
name: "invalid admin type",
ctx: CTX,
req: &v2beta_org.CreateOrganizationRequest{
Name: gofakeit.AppName(),
Name: integration.OrganizationName(),
Admins: []*v2beta_org.CreateOrganizationRequest_Admin{
{},
},
@@ -110,7 +110,7 @@ func TestServer_CreateOrganization(t *testing.T) {
name: "existing user as admin",
ctx: CTX,
req: &v2beta_org.CreateOrganizationRequest{
Name: gofakeit.AppName(),
Name: integration.OrganizationName(),
Admins: []*v2beta_org.CreateOrganizationRequest_Admin{
{
UserType: &v2beta_org.CreateOrganizationRequest_Admin_UserId{UserId: User.GetUserId()},
@@ -133,7 +133,7 @@ func TestServer_CreateOrganization(t *testing.T) {
name: "admin with init",
ctx: CTX,
req: &v2beta_org.CreateOrganizationRequest{
Name: gofakeit.AppName(),
Name: integration.OrganizationName(),
Admins: []*v2beta_org.CreateOrganizationRequest_Admin{
{
UserType: &v2beta_org.CreateOrganizationRequest_Admin_Human{
@@ -172,7 +172,7 @@ func TestServer_CreateOrganization(t *testing.T) {
name: "existing user and new human with idp",
ctx: CTX,
req: &v2beta_org.CreateOrganizationRequest{
Name: gofakeit.AppName(),
Name: integration.OrganizationName(),
Admins: []*v2beta_org.CreateOrganizationRequest_Admin{
{
UserType: &v2beta_org.CreateOrganizationRequest_Admin_UserId{UserId: User.GetUserId()},
@@ -227,7 +227,7 @@ func TestServer_CreateOrganization(t *testing.T) {
ctx: CTX,
id: "custom_id",
req: &v2beta_org.CreateOrganizationRequest{
Name: gofakeit.AppName(),
Name: integration.OrganizationName(),
Id: gu.Ptr("custom_id"),
},
want: &v2beta_org.CreateOrganizationResponse{
@@ -1099,7 +1099,7 @@ func TestServer_AddOrganizationDomain_ClaimDomain(t *testing.T) {
// create an organization, ensure it has globally unique usernames
// and create a user with a loginname that matches the domain later on
organization, err := Client.CreateOrganization(CTX, &v2beta_org.CreateOrganizationRequest{
Name: gofakeit.AppName(),
Name: integration.OrganizationName(),
})
require.NoError(t, err)
_, err = Instance.Client.Admin.AddCustomDomainPolicy(CTX, &admin.AddCustomDomainPolicyRequest{
@@ -1113,7 +1113,7 @@ func TestServer_AddOrganizationDomain_ClaimDomain(t *testing.T) {
// create another organization, ensure it has globally unique usernames
// and create a user with a loginname that matches the domain later on
otherOrg, err := Client.CreateOrganization(CTX, &v2beta_org.CreateOrganizationRequest{
Name: gofakeit.AppName(),
Name: integration.OrganizationName(),
})
require.NoError(t, err)
_, err = Instance.Client.Admin.AddCustomDomainPolicy(CTX, &admin.AddCustomDomainPolicyRequest{