From 8d7d95a08446513ded78a9f69c96d2555939bfaf Mon Sep 17 00:00:00 2001 From: Elio Bischof Date: Wed, 27 Sep 2023 12:25:46 +0200 Subject: [PATCH] add ready for review check --- CONTRIBUTING.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 128eb61a5a..990e759aae 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -101,7 +101,8 @@ Please make sure you cover your changes with tests before marking a Pull Request - [ ] Integration tests against the gRPC server ensure that probable good and bad read and write permissions are tested. - [ ] Integration tests against the gRPC server ensure that the API is easily usable despite eventual consistency. - [ ] Integration tests against the gRPC server ensure that all probable login and registration flows are covered." -- [ ] Integration tests ensure that certain commands send expected notifications. +- [ ] Integration tests ensure that certain commands emit expected events that trigger notifications. +- [ ] Integration tests ensure that certain events trigger expected notifications. ## Contribute