From 99d33505cf30963807dc76c22713ed35f5844878 Mon Sep 17 00:00:00 2001 From: Iraq Jaber Date: Fri, 30 May 2025 18:36:21 +0200 Subject: [PATCH] fixup! Merge branch 'main' into org_api_merge --- .../org/v2beta/integration_test/org_test.go | 36 +++++++++---------- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/internal/api/grpc/org/v2beta/integration_test/org_test.go b/internal/api/grpc/org/v2beta/integration_test/org_test.go index e57b973fbe..7b395eb370 100644 --- a/internal/api/grpc/org/v2beta/integration_test/org_test.go +++ b/internal/api/grpc/org/v2beta/integration_test/org_test.go @@ -893,7 +893,7 @@ func TestServer_DeactivateOrganization(t *testing.T) { } } -func TestServer_AddOerganizationDomain(t *testing.T) { +func TestServer_AddOrganizationDomain(t *testing.T) { tests := []struct { name string ctx context.Context @@ -903,7 +903,7 @@ func TestServer_AddOerganizationDomain(t *testing.T) { }{ { name: "add org domain, happy path", - domain: "www.domain.com", + domain: gofakeit.URL(), testFunc: func() string { orgs, _, err := createOrgs(CTX, Client, 1) if err != nil { @@ -916,7 +916,7 @@ func TestServer_AddOerganizationDomain(t *testing.T) { }, { name: "add org domain, twice", - domain: "www.domain.com", + domain: gofakeit.URL(), testFunc: func() string { // 1. create organization orgs, _, err := createOrgs(CTX, Client, 1) @@ -926,7 +926,7 @@ func TestServer_AddOerganizationDomain(t *testing.T) { } orgId := orgs[0].Id - domain := "www.domain.com" + domain := gofakeit.URL() // 2. add domain addOrgDomainRes, err := Client.AddOrganizationDomain(CTX, &v2beta_org.AddOrganizationDomainRequest{ OrganizationId: orgId, @@ -956,16 +956,15 @@ func TestServer_AddOerganizationDomain(t *testing.T) { return orgId }, - err: errors.New("AlreadyExists"), }, { name: "add org domain to non existent org", - domain: "www.domain.com", + domain: gofakeit.URL(), testFunc: func() string { return "non-existing-org-id" }, - // BUG: - err: errors.New("Domain already exists"), + // BUG: should return a error + err: nil, }, } @@ -991,6 +990,7 @@ func TestServer_AddOerganizationDomain(t *testing.T) { } func TestServer_ListOrganizationDomain(t *testing.T) { + domain := gofakeit.URL() tests := []struct { name string ctx context.Context @@ -1000,7 +1000,7 @@ func TestServer_ListOrganizationDomain(t *testing.T) { }{ { name: "list org domain, happy path", - domain: "www.domain.com", + domain: domain, testFunc: func() string { // 1. create organization orgs, _, err := createOrgs(CTX, Client, 1) @@ -1009,8 +1009,6 @@ func TestServer_ListOrganizationDomain(t *testing.T) { return "" } orgId := orgs[0].Id - - domain := "www.domain.com" // 2. add domain addOrgDomainRes, err := Client.AddOrganizationDomain(CTX, &v2beta_org.AddOrganizationDomainRequest{ OrganizationId: orgId, @@ -1055,6 +1053,7 @@ func TestServer_ListOrganizationDomain(t *testing.T) { } func TestServer_DeleteOerganizationDomain(t *testing.T) { + domain := gofakeit.URL() tests := []struct { name string ctx context.Context @@ -1064,7 +1063,7 @@ func TestServer_DeleteOerganizationDomain(t *testing.T) { }{ { name: "delete org domain, happy path", - domain: "www.domain.com", + domain: domain, testFunc: func() string { // 1. create organization orgs, _, err := createOrgs(CTX, Client, 1) @@ -1074,7 +1073,6 @@ func TestServer_DeleteOerganizationDomain(t *testing.T) { } orgId := orgs[0].Id - domain := "www.domain.com" // 2. add domain addOrgDomainRes, err := Client.AddOrganizationDomain(CTX, &v2beta_org.AddOrganizationDomainRequest{ OrganizationId: orgId, @@ -1107,7 +1105,7 @@ func TestServer_DeleteOerganizationDomain(t *testing.T) { }, { name: "delete org domain, twice", - domain: "www.domain.com", + domain: gofakeit.URL(), testFunc: func() string { // 1. create organization orgs, _, err := createOrgs(CTX, Client, 1) @@ -1117,7 +1115,7 @@ func TestServer_DeleteOerganizationDomain(t *testing.T) { } orgId := orgs[0].Id - domain := "www.domain.com" + domain := gofakeit.URL() // 2. add domain addOrgDomainRes, err := Client.AddOrganizationDomain(CTX, &v2beta_org.AddOrganizationDomainRequest{ OrganizationId: orgId, @@ -1157,7 +1155,7 @@ func TestServer_DeleteOerganizationDomain(t *testing.T) { }, { name: "delete org domain to non existent org", - domain: "www.domain.com", + domain: gofakeit.URL(), testFunc: func() string { return "non-existing-org-id" }, @@ -1202,7 +1200,7 @@ func TestServer_AddListDeleteOrganizationDomain(t *testing.T) { orgId := orgs[0].Id // ctx := Instance.WithAuthorization(CTX, integration.UserTypeIAMOwner) - domain := "www.domain.com" + domain := gofakeit.URL() // 2. add domain addOrgDomainRes, err := Client.AddOrganizationDomain(CTX, &v2beta_org.AddOrganizationDomainRequest{ OrganizationId: orgId, @@ -1252,7 +1250,7 @@ func TestServer_AddListDeleteOrganizationDomain(t *testing.T) { } orgId := orgs[0].Id - domain := "www.domain2.com" + domain := gofakeit.URL() // 2. add domain addOrgDomainRes, err := Client.AddOrganizationDomain(CTX, &v2beta_org.AddOrganizationDomainRequest{ OrganizationId: orgId, @@ -1339,7 +1337,7 @@ func TestServer_ValidateOrganizationDomain(t *testing.T) { require.NoError(t, err) } - domain := "www.domainnn.com" + domain := gofakeit.URL() _, err = Client.AddOrganizationDomain(CTX, &v2beta_org.AddOrganizationDomainRequest{ OrganizationId: orgId, Domain: domain,