From 9b41758af00e6df8e3111e52c0ffcb4673a1e113 Mon Sep 17 00:00:00 2001 From: Max Peintner Date: Tue, 21 Mar 2023 17:48:35 +0100 Subject: [PATCH] fix(console): delete provider, refactor add and update methods (#5515) fix: provider deletion --- .../modules/idp-table/idp-table.component.ts | 36 ++-- .../provider-azure-ad.component.ts | 169 ++++++------------ .../provider-github-es.component.ts | 139 +++++--------- .../provider-github.component.ts | 136 +++++--------- ...provider-gitlab-self-hosted.component.html | 11 +- .../provider-gitlab-self-hosted.component.ts | 144 +++++---------- .../provider-gitlab.component.ts | 136 +++++--------- .../provider-google.component.ts | 62 +++---- .../provider-jwt/provider-jwt.component.html | 2 +- .../provider-jwt/provider-jwt.component.ts | 134 +++++--------- .../provider-oauth.component.ts | 145 +++++---------- .../provider-oidc/provider-oidc.component.ts | 127 +++++-------- console/src/app/services/admin.service.ts | 12 +- console/src/app/services/mgmt.service.ts | 12 +- 14 files changed, 425 insertions(+), 840 deletions(-) diff --git a/console/src/app/modules/idp-table/idp-table.component.ts b/console/src/app/modules/idp-table/idp-table.component.ts index 55567fc06c..88ddae9718 100644 --- a/console/src/app/modules/idp-table/idp-table.component.ts +++ b/console/src/app/modules/idp-table/idp-table.component.ts @@ -142,31 +142,17 @@ export class IdpTableComponent implements OnInit { dialogRef.afterClosed().subscribe((resp) => { if (resp) { - if (this.serviceType === PolicyComponentServiceType.MGMT) { - (this.service as ManagementService).removeOrgIDP(idp.id).then( - () => { - this.toast.showInfo('IDP.TOAST.DELETED', true); - setTimeout(() => { - this.refreshPage(); - }, 1000); - }, - (error) => { - this.toast.showError(error); - }, - ); - } else { - (this.service as AdminService).removeIDP(idp.id).then( - () => { - this.toast.showInfo('IDP.TOAST.DELETED', true); - setTimeout(() => { - this.refreshPage(); - }, 1000); - }, - (error) => { - this.toast.showError(error); - }, - ); - } + this.service.deleteProvider(idp.id).then( + () => { + this.toast.showInfo('IDP.TOAST.DELETED', true); + setTimeout(() => { + this.refreshPage(); + }, 1000); + }, + (error) => { + this.toast.showError(error); + }, + ); } }); } diff --git a/console/src/app/modules/providers/provider-azure-ad/provider-azure-ad.component.ts b/console/src/app/modules/providers/provider-azure-ad/provider-azure-ad.component.ts index 71b4086a96..816171f8b0 100644 --- a/console/src/app/modules/providers/provider-azure-ad/provider-azure-ad.component.ts +++ b/console/src/app/modules/providers/provider-azure-ad/provider-azure-ad.component.ts @@ -130,134 +130,77 @@ export class ProviderAzureADComponent { } public addAzureADProvider(): void { - if (this.serviceType === PolicyComponentServiceType.MGMT) { - const req = new MgmtAddAzureADProviderRequest(); + const req = + this.serviceType === PolicyComponentServiceType.MGMT + ? new MgmtAddAzureADProviderRequest() + : new AdminAddAzureADProviderRequest(); - req.setName(this.name?.value); - req.setClientId(this.clientId?.value); - req.setClientSecret(this.clientSecret?.value); - req.setEmailVerified(this.emailVerified?.value); + req.setName(this.name?.value); + req.setClientId(this.clientId?.value); + req.setClientSecret(this.clientSecret?.value); + req.setEmailVerified(this.emailVerified?.value); - const tenant = new AzureADTenant(); - tenant.setTenantId(this.tenantId?.value); - tenant.setTenantType(this.tenantType?.value); - req.setTenant(tenant); + const tenant = new AzureADTenant(); + tenant.setTenantId(this.tenantId?.value); + tenant.setTenantType(this.tenantType?.value); + req.setTenant(tenant); - req.setScopesList(this.scopesList?.value); - req.setProviderOptions(this.options); + req.setScopesList(this.scopesList?.value); + req.setProviderOptions(this.options); - this.loading = true; - (this.service as ManagementService) - .addAzureADProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.router.navigate(['/org-settings'], { queryParams: { id: 'idp' } }); - }, 2000); - }) - .catch((error) => { - this.toast.showError(error); + this.loading = true; + this.service + .addAzureADProvider(req) + .then((idp) => { + setTimeout(() => { this.loading = false; - }); - } else if (PolicyComponentServiceType.ADMIN) { - const req = new AdminAddAzureADProviderRequest(); - req.setName(this.name?.value); - req.setClientId(this.clientId?.value); - req.setClientSecret(this.clientSecret?.value); - req.setEmailVerified(this.emailVerified?.value); - - const tenant = new AzureADTenant(); - tenant.setTenantId(this.tenantId?.value); - tenant.setTenantType(this.tenantType?.value); - req.setTenant(tenant); - - req.setScopesList(this.scopesList?.value); - req.setProviderOptions(this.options); - - this.loading = true; - (this.service as AdminService) - .addAzureADProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.router.navigate(['/settings'], { queryParams: { id: 'idp' } }); - }, 2000); - }) - .catch((error) => { - this.loading = false; - this.toast.showError(error); - }); - } + this.close(); + }, 2000); + }) + .catch((error) => { + this.toast.showError(error); + this.loading = false; + }); } public updateAzureADProvider(): void { if (this.provider) { - if (this.serviceType === PolicyComponentServiceType.MGMT) { - const req = new MgmtUpdateAzureADProviderRequest(); - req.setId(this.provider.id); - req.setName(this.name?.value); - req.setClientId(this.clientId?.value); - req.setEmailVerified(this.emailVerified?.value); + const req = + this.serviceType === PolicyComponentServiceType.MGMT + ? new MgmtUpdateAzureADProviderRequest() + : new AdminUpdateAzureADProviderRequest(); - const tenant = new AzureADTenant(); + req.setId(this.provider.id); + req.setName(this.name?.value); + req.setClientId(this.clientId?.value); + req.setEmailVerified(this.emailVerified?.value); - tenant.setTenantId(this.tenantId?.value); - tenant.setTenantType(this.tenantType?.value); - req.setTenant(tenant); + const tenant = new AzureADTenant(); - req.setScopesList(this.scopesList?.value); - req.setProviderOptions(this.options); + tenant.setTenantId(this.tenantId?.value); + tenant.setTenantType(this.tenantType?.value); + req.setTenant(tenant); - if (this.updateClientSecret) { - req.setClientSecret(this.clientSecret?.value); - } + req.setScopesList(this.scopesList?.value); + req.setProviderOptions(this.options); - this.loading = true; - (this.service as ManagementService) - .updateAzureADProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.router.navigate(['/org-settings'], { queryParams: { id: 'idp' } }); - }, 2000); - }) - .catch((error) => { - this.toast.showError(error); - this.loading = false; - }); - } else if (PolicyComponentServiceType.ADMIN) { - const req = new AdminUpdateAzureADProviderRequest(); - req.setId(this.provider.id); - req.setName(this.name?.value); - req.setClientId(this.clientId?.value); - req.setEmailVerified(this.emailVerified?.value); - - const tenant = new AzureADTenant(); - tenant.setTenantId(this.tenantId?.value); - tenant.setTenantType(this.tenantType?.value); - req.setTenant(tenant); - - req.setScopesList(this.scopesList?.value); - req.setProviderOptions(this.options); - - if (this.updateClientSecret) { - req.setClientSecret(this.clientSecret?.value); - } - - this.loading = true; - (this.service as AdminService) - .updateAzureADProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.router.navigate(['/settings'], { queryParams: { id: 'idp' } }); - }, 2000); - }) - .catch((error) => { - this.loading = false; - this.toast.showError(error); - }); + if (this.updateClientSecret) { + req.setClientSecret(this.clientSecret?.value); } + + this.loading = true; + this.service + .updateAzureADProvider(req) + .then((idp) => { + setTimeout(() => { + this.loading = false; + this.close(); + }, 2000); + }) + .catch((error) => { + this.toast.showError(error); + this.loading = false; + }); } } diff --git a/console/src/app/modules/providers/provider-github-es/provider-github-es.component.ts b/console/src/app/modules/providers/provider-github-es/provider-github-es.component.ts index 19e8092e0d..086bdd9a22 100644 --- a/console/src/app/modules/providers/provider-github-es/provider-github-es.component.ts +++ b/console/src/app/modules/providers/provider-github-es/provider-github-es.component.ts @@ -122,107 +122,62 @@ export class ProviderGithubESComponent { } public addGenericOAuthProvider(): void { - if (this.serviceType === PolicyComponentServiceType.MGMT) { - const req = new MgmtAddGitHubEnterpriseServerProviderRequest(); + const req = + this.serviceType === PolicyComponentServiceType.MGMT + ? new MgmtAddGitHubEnterpriseServerProviderRequest() + : new AdminAddGitHubEnterpriseServerProviderRequest(); - req.setName(this.name?.value); - req.setAuthorizationEndpoint(this.authorizationEndpoint?.value); - req.setTokenEndpoint(this.tokenEndpoint?.value); - req.setUserEndpoint(this.userEndpoint?.value); - req.setClientId(this.clientId?.value); - req.setClientSecret(this.clientSecret?.value); - req.setScopesList(this.scopesList?.value); + req.setName(this.name?.value); + req.setAuthorizationEndpoint(this.authorizationEndpoint?.value); + req.setTokenEndpoint(this.tokenEndpoint?.value); + req.setUserEndpoint(this.userEndpoint?.value); + req.setClientId(this.clientId?.value); + req.setClientSecret(this.clientSecret?.value); + req.setScopesList(this.scopesList?.value); - this.loading = true; - (this.service as ManagementService) - .addGitHubEnterpriseServerProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.toast.showError(error); + this.loading = true; + this.service + .addGitHubEnterpriseServerProvider(req) + .then((idp) => { + setTimeout(() => { this.loading = false; - }); - } else if (PolicyComponentServiceType.ADMIN) { - const req = new AdminAddGitHubEnterpriseServerProviderRequest(); - req.setName(this.name?.value); - req.setAuthorizationEndpoint(this.authorizationEndpoint?.value); - req.setTokenEndpoint(this.tokenEndpoint?.value); - req.setUserEndpoint(this.userEndpoint?.value); - req.setClientId(this.clientId?.value); - req.setClientSecret(this.clientSecret?.value); - req.setScopesList(this.scopesList?.value); - - this.loading = true; - (this.service as AdminService) - .addGitHubEnterpriseServerProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.toast.showError(error); - this.loading = false; - }); - } + this.close(); + }, 2000); + }) + .catch((error) => { + this.toast.showError(error); + this.loading = false; + }); } public updateGenericOAuthProvider(): void { if (this.provider) { - if (this.serviceType === PolicyComponentServiceType.MGMT) { - const req = new MgmtUpdateGitHubEnterpriseServerProviderRequest(); - req.setId(this.provider.id); - req.setName(this.name?.value); - req.setAuthorizationEndpoint(this.authorizationEndpoint?.value); - req.setTokenEndpoint(this.tokenEndpoint?.value); - req.setUserEndpoint(this.userEndpoint?.value); - req.setClientId(this.clientId?.value); - req.setClientSecret(this.clientSecret?.value); - req.setScopesList(this.scopesList?.value); + const req = + this.serviceType === PolicyComponentServiceType.MGMT + ? new MgmtUpdateGitHubEnterpriseServerProviderRequest() + : new AdminUpdateGitHubEnterpriseServerProviderRequest(); + req.setId(this.provider.id); + req.setName(this.name?.value); + req.setAuthorizationEndpoint(this.authorizationEndpoint?.value); + req.setTokenEndpoint(this.tokenEndpoint?.value); + req.setUserEndpoint(this.userEndpoint?.value); + req.setClientId(this.clientId?.value); + req.setClientSecret(this.clientSecret?.value); + req.setScopesList(this.scopesList?.value); - this.loading = true; - (this.service as ManagementService) - .updateGitHubEnterpriseServerProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.toast.showError(error); + this.loading = true; + this.service + .updateGitHubEnterpriseServerProvider(req) + .then((idp) => { + setTimeout(() => { this.loading = false; - }); - } else if (PolicyComponentServiceType.ADMIN) { - const req = new AdminUpdateGitHubEnterpriseServerProviderRequest(); - req.setId(this.provider.id); - req.setName(this.name?.value); - req.setAuthorizationEndpoint(this.authorizationEndpoint?.value); - req.setTokenEndpoint(this.tokenEndpoint?.value); - req.setUserEndpoint(this.userEndpoint?.value); - req.setClientId(this.clientId?.value); - req.setClientSecret(this.clientSecret?.value); - req.setScopesList(this.scopesList?.value); - - this.loading = true; - (this.service as AdminService) - .updateGitHubEnterpriseServerProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.toast.showError(error); - this.loading = false; - }); - } + this.close(); + }, 2000); + }) + .catch((error) => { + this.toast.showError(error); + this.loading = false; + }); } } diff --git a/console/src/app/modules/providers/provider-github/provider-github.component.ts b/console/src/app/modules/providers/provider-github/provider-github.component.ts index 212112ec4c..5524079d9f 100644 --- a/console/src/app/modules/providers/provider-github/provider-github.component.ts +++ b/console/src/app/modules/providers/provider-github/provider-github.component.ts @@ -119,105 +119,61 @@ export class ProviderGithubComponent { } public addGithubProvider(): void { - if (this.serviceType === PolicyComponentServiceType.MGMT) { - const req = new MgmtAddGithubProviderRequest(); + const req = + this.serviceType === PolicyComponentServiceType.MGMT + ? new MgmtAddGithubProviderRequest() + : new AdminAddGithubProviderRequest(); - req.setName(this.name?.value); - req.setClientId(this.clientId?.value); - req.setClientSecret(this.clientSecret?.value); - req.setScopesList(this.scopesList?.value); - req.setProviderOptions(this.options); + req.setName(this.name?.value); + req.setClientId(this.clientId?.value); + req.setClientSecret(this.clientSecret?.value); + req.setScopesList(this.scopesList?.value); + req.setProviderOptions(this.options); - this.loading = true; - (this.service as ManagementService) - .addGitHubProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.toast.showError(error); + this.loading = true; + this.service + .addGitHubProvider(req) + .then((idp) => { + setTimeout(() => { this.loading = false; - }); - } else if (PolicyComponentServiceType.ADMIN) { - const req = new AdminAddGithubProviderRequest(); - req.setName(this.name?.value); - req.setClientId(this.clientId?.value); - req.setClientSecret(this.clientSecret?.value); - req.setScopesList(this.scopesList?.value); - req.setProviderOptions(this.options); - - this.loading = true; - (this.service as AdminService) - .addGitHubProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.loading = false; - this.toast.showError(error); - }); - } + this.close(); + }, 2000); + }) + .catch((error) => { + this.toast.showError(error); + this.loading = false; + }); } public updateGithubProvider(): void { if (this.provider) { - if (this.serviceType === PolicyComponentServiceType.MGMT) { - const req = new MgmtUpdateGithubProviderRequest(); - req.setId(this.provider.id); - req.setName(this.name?.value); - req.setClientId(this.clientId?.value); - req.setScopesList(this.scopesList?.value); - req.setProviderOptions(this.options); + const req = + this.serviceType === PolicyComponentServiceType.MGMT + ? new MgmtUpdateGithubProviderRequest() + : new AdminUpdateGithubProviderRequest(); + req.setId(this.provider.id); + req.setName(this.name?.value); + req.setClientId(this.clientId?.value); + req.setScopesList(this.scopesList?.value); + req.setProviderOptions(this.options); - if (this.updateClientSecret) { - req.setClientSecret(this.clientSecret?.value); - } - - this.loading = true; - (this.service as ManagementService) - .updateGitHubProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.toast.showError(error); - this.loading = false; - }); - } else if (PolicyComponentServiceType.ADMIN) { - const req = new AdminUpdateGithubProviderRequest(); - req.setId(this.provider.id); - req.setName(this.name?.value); - req.setClientId(this.clientId?.value); - req.setScopesList(this.scopesList?.value); - req.setProviderOptions(this.options); - - if (this.updateClientSecret) { - req.setClientSecret(this.clientSecret?.value); - } - - this.loading = true; - (this.service as AdminService) - .updateGitHubProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.loading = false; - this.toast.showError(error); - }); + if (this.updateClientSecret) { + req.setClientSecret(this.clientSecret?.value); } + + this.loading = true; + this.service + .updateGitHubProvider(req) + .then((idp) => { + setTimeout(() => { + this.loading = false; + this.close(); + }, 2000); + }) + .catch((error) => { + this.toast.showError(error); + this.loading = false; + }); } } diff --git a/console/src/app/modules/providers/provider-gitlab-self-hosted/provider-gitlab-self-hosted.component.html b/console/src/app/modules/providers/provider-gitlab-self-hosted/provider-gitlab-self-hosted.component.html index b09217a7ca..a4346256a8 100644 --- a/console/src/app/modules/providers/provider-gitlab-self-hosted/provider-gitlab-self-hosted.component.html +++ b/console/src/app/modules/providers/provider-gitlab-self-hosted/provider-gitlab-self-hosted.component.html @@ -15,6 +15,11 @@
+ + {{ 'IDP.NAME' | translate }} + + + {{ 'IDP.ISSUER' | translate }} @@ -74,12 +79,6 @@
- - {{ 'IDP.NAME' | translate }} - - {{ 'IDP.NAMEHINT' | translate }} - - { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.toast.showError(error); + this.loading = true; + this.service + .addGitLabSelfHostedProvider(req) + .then((idp) => { + setTimeout(() => { this.loading = false; - }); - } else if (PolicyComponentServiceType.ADMIN) { - const req = new AdminAddGitLabSelfHostedProviderRequest(); - req.setName(this.name?.value); - req.setIssuer(this.issuer?.value); - req.setClientId(this.clientId?.value); - req.setClientSecret(this.clientSecret?.value); - req.setScopesList(this.scopesList?.value); - req.setProviderOptions(this.options); - - this.loading = true; - (this.service as AdminService) - .addGitLabSelfHostedProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.loading = false; - this.toast.showError(error); - }); - } + this.close(); + }, 2000); + }) + .catch((error) => { + this.toast.showError(error); + this.loading = false; + }); } public updateGitlabSelfHostedProvider(): void { if (this.provider) { - if (this.serviceType === PolicyComponentServiceType.MGMT) { - const req = new MgmtUpdateGitLabSelfHostedProviderRequest(); - req.setId(this.provider.id); - req.setName(this.name?.value); - req.setIssuer(this.issuer?.value); - req.setClientId(this.clientId?.value); - req.setScopesList(this.scopesList?.value); - req.setProviderOptions(this.options); + const req = + this.serviceType === PolicyComponentServiceType.MGMT + ? new MgmtUpdateGitLabSelfHostedProviderRequest() + : new AdminUpdateGitLabSelfHostedProviderRequest(); + req.setId(this.provider.id); + req.setName(this.name?.value); + req.setIssuer(this.issuer?.value); + req.setClientId(this.clientId?.value); + req.setScopesList(this.scopesList?.value); + req.setProviderOptions(this.options); - if (this.updateClientSecret) { - req.setClientSecret(this.clientSecret?.value); - } - - this.loading = true; - (this.service as ManagementService) - .updateGitLabSelfHostedProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.toast.showError(error); - this.loading = false; - }); - } else if (PolicyComponentServiceType.ADMIN) { - const req = new AdminUpdateGitLabSelfHostedProviderRequest(); - req.setId(this.provider.id); - req.setName(this.name?.value); - req.setIssuer(this.issuer?.value); - req.setClientId(this.clientId?.value); - req.setScopesList(this.scopesList?.value); - req.setProviderOptions(this.options); - - if (this.updateClientSecret) { - req.setClientSecret(this.clientSecret?.value); - } - - this.loading = true; - (this.service as AdminService) - .updateGitLabSelfHostedProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.loading = false; - this.toast.showError(error); - }); + if (this.updateClientSecret) { + req.setClientSecret(this.clientSecret?.value); } + + this.loading = true; + this.service + .updateGitLabSelfHostedProvider(req) + .then((idp) => { + setTimeout(() => { + this.loading = false; + this.close(); + }, 2000); + }) + .catch((error) => { + this.toast.showError(error); + this.loading = false; + }); } } diff --git a/console/src/app/modules/providers/provider-gitlab/provider-gitlab.component.ts b/console/src/app/modules/providers/provider-gitlab/provider-gitlab.component.ts index 3a7f3ed5ee..65f5fe3381 100644 --- a/console/src/app/modules/providers/provider-gitlab/provider-gitlab.component.ts +++ b/console/src/app/modules/providers/provider-gitlab/provider-gitlab.component.ts @@ -119,105 +119,61 @@ export class ProviderGitlabComponent { } public addGitlabProvider(): void { - if (this.serviceType === PolicyComponentServiceType.MGMT) { - const req = new MgmtAddGitLabProviderRequest(); + const req = + this.serviceType === PolicyComponentServiceType.MGMT + ? new MgmtAddGitLabProviderRequest() + : new AdminAddGitLabProviderRequest(); - req.setName(this.name?.value); - req.setClientId(this.clientId?.value); - req.setClientSecret(this.clientSecret?.value); - req.setScopesList(this.scopesList?.value); - req.setProviderOptions(this.options); + req.setName(this.name?.value); + req.setClientId(this.clientId?.value); + req.setClientSecret(this.clientSecret?.value); + req.setScopesList(this.scopesList?.value); + req.setProviderOptions(this.options); - this.loading = true; - (this.service as ManagementService) - .addGitLabProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.toast.showError(error); + this.loading = true; + this.service + .addGitLabProvider(req) + .then((idp) => { + setTimeout(() => { this.loading = false; - }); - } else if (PolicyComponentServiceType.ADMIN) { - const req = new AdminAddGitLabProviderRequest(); - req.setName(this.name?.value); - req.setClientId(this.clientId?.value); - req.setClientSecret(this.clientSecret?.value); - req.setScopesList(this.scopesList?.value); - req.setProviderOptions(this.options); - - this.loading = true; - (this.service as AdminService) - .addGitLabProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.loading = false; - this.toast.showError(error); - }); - } + this.close(); + }, 2000); + }) + .catch((error) => { + this.toast.showError(error); + this.loading = false; + }); } public updateGitlabProvider(): void { if (this.provider) { - if (this.serviceType === PolicyComponentServiceType.MGMT) { - const req = new MgmtUpdateGitLabProviderRequest(); - req.setId(this.provider.id); - req.setName(this.name?.value); - req.setClientId(this.clientId?.value); - req.setScopesList(this.scopesList?.value); - req.setProviderOptions(this.options); + const req = + this.serviceType === PolicyComponentServiceType.MGMT + ? new MgmtUpdateGitLabProviderRequest() + : new AdminUpdateGitLabProviderRequest(); + req.setId(this.provider.id); + req.setName(this.name?.value); + req.setClientId(this.clientId?.value); + req.setScopesList(this.scopesList?.value); + req.setProviderOptions(this.options); - if (this.updateClientSecret) { - req.setClientSecret(this.clientSecret?.value); - } - - this.loading = true; - (this.service as ManagementService) - .updateGitLabProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.toast.showError(error); - this.loading = false; - }); - } else if (PolicyComponentServiceType.ADMIN) { - const req = new AdminUpdateGitLabProviderRequest(); - req.setId(this.provider.id); - req.setName(this.name?.value); - req.setClientId(this.clientId?.value); - req.setScopesList(this.scopesList?.value); - req.setProviderOptions(this.options); - - if (this.updateClientSecret) { - req.setClientSecret(this.clientSecret?.value); - } - - this.loading = true; - (this.service as AdminService) - .updateGoogleProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.loading = false; - this.toast.showError(error); - }); + if (this.updateClientSecret) { + req.setClientSecret(this.clientSecret?.value); } + + this.loading = true; + this.service + .updateGitLabProvider(req) + .then((idp) => { + setTimeout(() => { + this.loading = false; + this.close(); + }, 2000); + }) + .catch((error) => { + this.toast.showError(error); + this.loading = false; + }); } } diff --git a/console/src/app/modules/providers/provider-google/provider-google.component.ts b/console/src/app/modules/providers/provider-google/provider-google.component.ts index d1a0f86eca..c7744bb010 100644 --- a/console/src/app/modules/providers/provider-google/provider-google.component.ts +++ b/console/src/app/modules/providers/provider-google/provider-google.component.ts @@ -119,50 +119,30 @@ export class ProviderGoogleComponent { } public addGoogleProvider(): void { - if (this.serviceType === PolicyComponentServiceType.MGMT) { - const req = new MgmtAddGoogleProviderRequest(); + const req = + this.serviceType === PolicyComponentServiceType.MGMT + ? new MgmtAddGoogleProviderRequest() + : new AdminAddGoogleProviderRequest(); - req.setName(this.name?.value); - req.setClientId(this.clientId?.value); - req.setClientSecret(this.clientSecret?.value); - req.setScopesList(this.scopesList?.value); - req.setProviderOptions(this.options); + req.setName(this.name?.value); + req.setClientId(this.clientId?.value); + req.setClientSecret(this.clientSecret?.value); + req.setScopesList(this.scopesList?.value); + req.setProviderOptions(this.options); - this.loading = true; - (this.service as ManagementService) - .addGoogleProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.toast.showError(error); + this.loading = true; + this.service + .addGoogleProvider(req) + .then((idp) => { + setTimeout(() => { this.loading = false; - }); - } else if (PolicyComponentServiceType.ADMIN) { - const req = new AdminAddGoogleProviderRequest(); - req.setName(this.name?.value); - req.setClientId(this.clientId?.value); - req.setClientSecret(this.clientSecret?.value); - req.setScopesList(this.scopesList?.value); - req.setProviderOptions(this.options); - - this.loading = true; - (this.service as AdminService) - .addGoogleProvider(req) - .then((idp) => { - setTimeout(() => { - this.loading = false; - this.close(); - }, 2000); - }) - .catch((error) => { - this.loading = false; - this.toast.showError(error); - }); - } + this.close(); + }, 2000); + }) + .catch((error) => { + this.toast.showError(error); + this.loading = false; + }); } public updateGoogleProvider(): void { diff --git a/console/src/app/modules/providers/provider-jwt/provider-jwt.component.html b/console/src/app/modules/providers/provider-jwt/provider-jwt.component.html index 3c72264ac1..853bb3e800 100644 --- a/console/src/app/modules/providers/provider-jwt/provider-jwt.component.html +++ b/console/src/app/modules/providers/provider-jwt/provider-jwt.component.html @@ -49,7 +49,7 @@ > -
+