mirror of
https://github.com/zitadel/zitadel.git
synced 2025-08-11 21:07:31 +00:00
fix(queries): project grant and role prepare funcs (#2659)
* chore(queries): test suite for prepare stmt funcs * test(queries): prepare project funcs * refactor: add comments * test: simlify expected sql, added possibility to add args to expected queries * test(queries): prepare funcs in org * chore(backend): correct modules * test(queries): org domain prepare funcs * test: correct name * refactor: file name * refactor: add table to login policy columns * chore(prepare_test): only add row to result if columns * test(queries): login policy prepare funcs * chore: add comments for configs * test(queries): prepare idp funcs * fix(queries): add table to password complexity policy cols * test(queries): password complexity policy prepare funcs * fix(queries): add table to password age policy cols * test(queries): password age policy prepare func * fix(queries): set cols on lockout policy * test(queries): lockout policy prepare funs * fix(queries): set table on privacy policy cols * test(queries): privacy policy prepare funcs * fix(queries): set table on org iam policy cols * fix(queries): correct table in org iam policy cols * test(queries): org iam policy prepare funcs * test(queries): prepare project grant funcs * refactor(queries): prepareProjectRoleQuery as func * test(queries): prepare project role funcs * test(queries): project grant check for nulls in joins * fix(queries): allow null values in project grant
This commit is contained in:
Silvan
312
internal/query/project_role_test.go
Normal file
312
internal/query/project_role_test.go
Normal file
@@ -0,0 +1,312 @@
|
||||
package query
|
||||
|
||||
import (
|
||||
"database/sql"
|
||||
"database/sql/driver"
|
||||
"errors"
|
||||
"fmt"
|
||||
"regexp"
|
||||
"testing"
|
||||
|
||||
errs "github.com/caos/zitadel/internal/errors"
|
||||
)
|
||||
|
||||
func Test_ProjectRolePrepares(t *testing.T) {
|
||||
type want struct {
|
||||
sqlExpectations sqlExpectation
|
||||
err checkErr
|
||||
}
|
||||
tests := []struct {
|
||||
name string
|
||||
prepare interface{}
|
||||
want want
|
||||
object interface{}
|
||||
}{
|
||||
{
|
||||
name: "prepareProjectRolesQuery no result",
|
||||
prepare: prepareProjectRolesQuery,
|
||||
want: want{
|
||||
sqlExpectations: mockQueries(
|
||||
regexp.QuoteMeta(`SELECT zitadel.projections.project_roles.project_id,`+
|
||||
` zitadel.projections.project_roles.creation_date,`+
|
||||
` zitadel.projections.project_roles.change_date,`+
|
||||
` zitadel.projections.project_roles.resource_owner,`+
|
||||
` zitadel.projections.project_roles.sequence,`+
|
||||
` zitadel.projections.project_roles.role_key,`+
|
||||
` zitadel.projections.project_roles.display_name,`+
|
||||
` zitadel.projections.project_roles.group_name,`+
|
||||
` COUNT(*) OVER ()`+
|
||||
` FROM zitadel.projections.project_roles`),
|
||||
nil,
|
||||
nil,
|
||||
),
|
||||
},
|
||||
object: &ProjectRoles{ProjectRoles: []*ProjectRole{}},
|
||||
},
|
||||
{
|
||||
name: "prepareProjectRolesQuery one result",
|
||||
prepare: prepareProjectRolesQuery,
|
||||
want: want{
|
||||
sqlExpectations: mockQueries(
|
||||
regexp.QuoteMeta(`SELECT zitadel.projections.project_roles.project_id,`+
|
||||
` zitadel.projections.project_roles.creation_date,`+
|
||||
` zitadel.projections.project_roles.change_date,`+
|
||||
` zitadel.projections.project_roles.resource_owner,`+
|
||||
` zitadel.projections.project_roles.sequence,`+
|
||||
` zitadel.projections.project_roles.role_key,`+
|
||||
` zitadel.projections.project_roles.display_name,`+
|
||||
` zitadel.projections.project_roles.group_name,`+
|
||||
` COUNT(*) OVER ()`+
|
||||
` FROM zitadel.projections.project_roles`),
|
||||
[]string{
|
||||
"project_id",
|
||||
"creation_date",
|
||||
"change_date",
|
||||
"resource_owner",
|
||||
"sequence",
|
||||
"role_key",
|
||||
"display_name",
|
||||
"group_name",
|
||||
"count",
|
||||
},
|
||||
[][]driver.Value{
|
||||
{
|
||||
"project-id",
|
||||
testNow,
|
||||
testNow,
|
||||
"ro",
|
||||
uint64(20211111),
|
||||
"role-key",
|
||||
"role-display-name",
|
||||
"role-group",
|
||||
},
|
||||
},
|
||||
),
|
||||
},
|
||||
object: &ProjectRoles{
|
||||
SearchResponse: SearchResponse{
|
||||
Count: 1,
|
||||
},
|
||||
ProjectRoles: []*ProjectRole{
|
||||
{
|
||||
ProjectID: "project-id",
|
||||
CreationDate: testNow,
|
||||
ChangeDate: testNow,
|
||||
ResourceOwner: "ro",
|
||||
Sequence: 20211111,
|
||||
Key: "role-key",
|
||||
DisplayName: "role-display-name",
|
||||
Group: "role-group",
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "prepareProjectRolesQuery multiple result",
|
||||
prepare: prepareProjectRolesQuery,
|
||||
want: want{
|
||||
sqlExpectations: mockQueries(
|
||||
regexp.QuoteMeta(`SELECT zitadel.projections.project_roles.project_id,`+
|
||||
` zitadel.projections.project_roles.creation_date,`+
|
||||
` zitadel.projections.project_roles.change_date,`+
|
||||
` zitadel.projections.project_roles.resource_owner,`+
|
||||
` zitadel.projections.project_roles.sequence,`+
|
||||
` zitadel.projections.project_roles.role_key,`+
|
||||
` zitadel.projections.project_roles.display_name,`+
|
||||
` zitadel.projections.project_roles.group_name,`+
|
||||
` COUNT(*) OVER ()`+
|
||||
` FROM zitadel.projections.project_roles`),
|
||||
[]string{
|
||||
"project_id",
|
||||
"creation_date",
|
||||
"change_date",
|
||||
"resource_owner",
|
||||
"sequence",
|
||||
"role_key",
|
||||
"display_name",
|
||||
"group_name",
|
||||
"count",
|
||||
},
|
||||
[][]driver.Value{
|
||||
{
|
||||
"project-id",
|
||||
testNow,
|
||||
testNow,
|
||||
"ro",
|
||||
uint64(20211111),
|
||||
"role-key-1",
|
||||
"role-display-name-1",
|
||||
"role-group",
|
||||
},
|
||||
{
|
||||
"project-id",
|
||||
testNow,
|
||||
testNow,
|
||||
"ro",
|
||||
uint64(20211111),
|
||||
"role-key-2",
|
||||
"role-display-name-2",
|
||||
"role-group",
|
||||
},
|
||||
},
|
||||
),
|
||||
},
|
||||
object: &ProjectRoles{
|
||||
SearchResponse: SearchResponse{
|
||||
Count: 2,
|
||||
},
|
||||
ProjectRoles: []*ProjectRole{
|
||||
{
|
||||
ProjectID: "project-id",
|
||||
CreationDate: testNow,
|
||||
ChangeDate: testNow,
|
||||
ResourceOwner: "ro",
|
||||
Sequence: 20211111,
|
||||
Key: "role-key-1",
|
||||
DisplayName: "role-display-name-1",
|
||||
Group: "role-group",
|
||||
},
|
||||
{
|
||||
ProjectID: "project-id",
|
||||
CreationDate: testNow,
|
||||
ChangeDate: testNow,
|
||||
ResourceOwner: "ro",
|
||||
Sequence: 20211111,
|
||||
Key: "role-key-2",
|
||||
DisplayName: "role-display-name-2",
|
||||
Group: "role-group",
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "prepareProjectRolesQuery sql err",
|
||||
prepare: prepareProjectRolesQuery,
|
||||
want: want{
|
||||
sqlExpectations: mockQueryErr(
|
||||
regexp.QuoteMeta(`SELECT zitadel.projections.project_roles.project_id,`+
|
||||
` zitadel.projections.project_roles.creation_date,`+
|
||||
` zitadel.projections.project_roles.change_date,`+
|
||||
` zitadel.projections.project_roles.resource_owner,`+
|
||||
` zitadel.projections.project_roles.sequence,`+
|
||||
` zitadel.projections.project_roles.role_key,`+
|
||||
` zitadel.projections.project_roles.display_name,`+
|
||||
` zitadel.projections.project_roles.group_name,`+
|
||||
` COUNT(*) OVER ()`+
|
||||
` FROM zitadel.projections.project_roles`),
|
||||
sql.ErrConnDone,
|
||||
),
|
||||
err: func(err error) (error, bool) {
|
||||
if !errors.Is(err, sql.ErrConnDone) {
|
||||
return fmt.Errorf("err should be sql.ErrConnDone got: %w", err), false
|
||||
}
|
||||
return nil, true
|
||||
},
|
||||
},
|
||||
object: nil,
|
||||
},
|
||||
{
|
||||
name: "prepareProjectRoleQuery no result",
|
||||
prepare: prepareProjectRoleQuery,
|
||||
want: want{
|
||||
sqlExpectations: mockQueries(
|
||||
regexp.QuoteMeta(`SELECT zitadel.projections.project_roles.project_id,`+
|
||||
` zitadel.projections.project_roles.creation_date,`+
|
||||
` zitadel.projections.project_roles.change_date,`+
|
||||
` zitadel.projections.project_roles.resource_owner,`+
|
||||
` zitadel.projections.project_roles.sequence,`+
|
||||
` zitadel.projections.project_roles.role_key,`+
|
||||
` zitadel.projections.project_roles.display_name,`+
|
||||
` zitadel.projections.project_roles.group_name`+
|
||||
` FROM zitadel.projections.project_roles`),
|
||||
nil,
|
||||
nil,
|
||||
),
|
||||
err: func(err error) (error, bool) {
|
||||
if !errs.IsNotFound(err) {
|
||||
return fmt.Errorf("err should be zitadel.NotFoundError got: %w", err), false
|
||||
}
|
||||
return nil, true
|
||||
},
|
||||
},
|
||||
object: (*ProjectRole)(nil),
|
||||
},
|
||||
{
|
||||
name: "prepareProjectRoleQuery found",
|
||||
prepare: prepareProjectRoleQuery,
|
||||
want: want{
|
||||
sqlExpectations: mockQuery(
|
||||
regexp.QuoteMeta(`SELECT zitadel.projections.project_roles.project_id,`+
|
||||
` zitadel.projections.project_roles.creation_date,`+
|
||||
` zitadel.projections.project_roles.change_date,`+
|
||||
` zitadel.projections.project_roles.resource_owner,`+
|
||||
` zitadel.projections.project_roles.sequence,`+
|
||||
` zitadel.projections.project_roles.role_key,`+
|
||||
` zitadel.projections.project_roles.display_name,`+
|
||||
` zitadel.projections.project_roles.group_name`+
|
||||
` FROM zitadel.projections.project_roles`),
|
||||
[]string{
|
||||
"project_id",
|
||||
"creation_date",
|
||||
"change_date",
|
||||
"resource_owner",
|
||||
"sequence",
|
||||
"role_key",
|
||||
"display_name",
|
||||
"group_name",
|
||||
},
|
||||
[]driver.Value{
|
||||
"project-id",
|
||||
testNow,
|
||||
testNow,
|
||||
"ro",
|
||||
uint64(20211111),
|
||||
"role-key",
|
||||
"role-display-name",
|
||||
"role-group",
|
||||
},
|
||||
),
|
||||
},
|
||||
object: &ProjectRole{
|
||||
ProjectID: "project-id",
|
||||
CreationDate: testNow,
|
||||
ChangeDate: testNow,
|
||||
ResourceOwner: "ro",
|
||||
Sequence: 20211111,
|
||||
Key: "role-key",
|
||||
DisplayName: "role-display-name",
|
||||
Group: "role-group",
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "prepareProjectRoleQuery sql err",
|
||||
prepare: prepareProjectRoleQuery,
|
||||
want: want{
|
||||
sqlExpectations: mockQueryErr(
|
||||
regexp.QuoteMeta(`SELECT zitadel.projections.project_roles.project_id,`+
|
||||
` zitadel.projections.project_roles.creation_date,`+
|
||||
` zitadel.projections.project_roles.change_date,`+
|
||||
` zitadel.projections.project_roles.resource_owner,`+
|
||||
` zitadel.projections.project_roles.sequence,`+
|
||||
` zitadel.projections.project_roles.role_key,`+
|
||||
` zitadel.projections.project_roles.display_name,`+
|
||||
` zitadel.projections.project_roles.group_name`+
|
||||
` FROM zitadel.projections.project_roles`),
|
||||
sql.ErrConnDone,
|
||||
),
|
||||
err: func(err error) (error, bool) {
|
||||
if !errors.Is(err, sql.ErrConnDone) {
|
||||
return fmt.Errorf("err should be sql.ErrConnDone got: %w", err), false
|
||||
}
|
||||
return nil, true
|
||||
},
|
||||
},
|
||||
object: nil,
|
||||
},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
assertPrepare(t, tt.prepare, tt.object, tt.want.sqlExpectations, tt.want.err)
|
||||
})
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user