From a7182671919eeb0dd0ead669bd60c6ab63451388 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jonas=20Badst=C3=BCbner?= <JoBad@online.de>
Date: Fri, 15 Aug 2025 14:00:16 +0200
Subject: [PATCH] fix(loginV2): hide sign-in-with-idp if none are configured
 (#10402)

<!--
Please inform yourself about the contribution guidelines on submitting a
PR here:
https://github.com/zitadel/zitadel/blob/main/CONTRIBUTING.md#submit-a-pull-request-pr.
Take note of how PR/commit titles should be written and replace the
template texts in the sections below. Don't remove any of the sections.
It is important that the commit history clearly shows what is changed
and why.
Important: By submitting a contribution you agree to the terms from our
Licensing Policy as described here:
https://github.com/zitadel/zitadel/blob/main/LICENSING.md#community-contributions.
-->

# Which Problems Are Solved

Don't show the external IdP section, if none are configured.

# How the Problems Are Solved

- Checks if the length of `identityProviders` is non-empty.

# Additional Changes

- Added 2 additional null-checks for `identityProviders`

# Additional Context

- Closes #10401

Co-authored-by: Max Peintner <max@caos.ch>
Co-authored-by: Livio Spring <livio.a@gmail.com>
---
 apps/login/src/app/(login)/idp/page.tsx        | 2 +-
 apps/login/src/app/(login)/loginname/page.tsx  | 2 +-
 apps/login/src/components/sign-in-with-idp.tsx | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/apps/login/src/app/(login)/idp/page.tsx b/apps/login/src/app/(login)/idp/page.tsx
index ab16e897e5..51b4f71bb2 100644
--- a/apps/login/src/app/(login)/idp/page.tsx
+++ b/apps/login/src/app/(login)/idp/page.tsx
@@ -38,7 +38,7 @@ export default async function Page(props: {
           <Translated i18nKey="description" namespace="idp" />
         </p>
 
-        {identityProviders && (
+        {!!identityProviders?.length && (
           <SignInWithIdp
             identityProviders={identityProviders}
             requestId={requestId}
diff --git a/apps/login/src/app/(login)/loginname/page.tsx b/apps/login/src/app/(login)/loginname/page.tsx
index 37b57ed1b9..f19d9986d1 100644
--- a/apps/login/src/app/(login)/loginname/page.tsx
+++ b/apps/login/src/app/(login)/loginname/page.tsx
@@ -78,7 +78,7 @@ export default async function Page(props: {
           allowRegister={!!loginSettings?.allowRegister}
         ></UsernameForm>
 
-        {identityProviders && loginSettings?.allowExternalIdp && (
+        {loginSettings?.allowExternalIdp && !!identityProviders?.length && (
           <div className="w-full pb-4 pt-6">
             <SignInWithIdp
               identityProviders={identityProviders}
diff --git a/apps/login/src/components/sign-in-with-idp.tsx b/apps/login/src/components/sign-in-with-idp.tsx
index 755416f6c9..e076805a3a 100644
--- a/apps/login/src/components/sign-in-with-idp.tsx
+++ b/apps/login/src/components/sign-in-with-idp.tsx
@@ -80,7 +80,7 @@ export function SignInWithIdp({
       <p className="ztdl-p text-center">
         <Translated i18nKey="orSignInWith" namespace="idp" />
       </p>
-      {!!identityProviders.length && identityProviders?.map(renderIDPButton)}
+      {!!identityProviders?.length && identityProviders?.map(renderIDPButton)}
       {state?.error && (
         <div className="py-4">
           <Alert>{state?.error}</Alert>