From a8a3001db5071be00f877f4c75606250f814cc65 Mon Sep 17 00:00:00 2001
From: Elio Bischof <eliobischof@gmail.com>
Date: Thu, 8 Jun 2023 07:42:35 +0200
Subject: [PATCH] self review

---
 CONTRIBUTING.md                                | 8 ++++----
 apps/login/ui/Input.tsx                        | 2 --
 packages/zitadel-client/src/middleware.test.ts | 4 ++--
 packages/zitadel-server/src/middleware.test.ts | 4 ++--
 4 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 53f031c6c56..11bf44f3af8 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -50,11 +50,11 @@ You can execute the following commands in the following directories:
 - The projects root directory: all tests in the project are executed
 
 ```sh
-# Run unit and integration tests once
-pnpm run test -- --passWithNoTests
+# Run all once
+pnpm test
 
-# Rerun unit and integration tests on file changes
-pnpm run test:watch -- --passWithNoTests
+# Rerun tests on file changes
+pnpm test:watch
 ```
 
 ### Developing Against Your Local ZITADEL Instance
diff --git a/apps/login/ui/Input.tsx b/apps/login/ui/Input.tsx
index 55887fbdb1a..3c7de28b1f1 100644
--- a/apps/login/ui/Input.tsx
+++ b/apps/login/ui/Input.tsx
@@ -8,7 +8,6 @@ import React, {
   InputHTMLAttributes,
   ReactNode,
 } from "react";
-import { v4 as uuidv4 } from "uuid";
 
 export type TextInputProps = DetailedHTMLProps<
   InputHTMLAttributes<HTMLInputElement>,
@@ -55,7 +54,6 @@ export const TextInput = forwardRef<HTMLInputElement, TextInputProps>(
     },
     ref
   ) => {
-    const id = uuidv4();
     return (
       <label className="flex flex-col text-12px text-input-light-label dark:text-input-dark-label">
         <span
diff --git a/packages/zitadel-client/src/middleware.test.ts b/packages/zitadel-client/src/middleware.test.ts
index 67415c5609e..5b4ae705990 100644
--- a/packages/zitadel-client/src/middleware.test.ts
+++ b/packages/zitadel-client/src/middleware.test.ts
@@ -27,7 +27,7 @@ describe('authMiddleware', () => {
       it(name, async () => {
 
         const mockNext = jest.fn().mockImplementation(async function*() { });
-        const mockRequest = {}; // Ersetze dies mit einem geeigneten Mock Request-Objekt
+        const mockRequest = {};
 
         const mockMethodDescriptor: MethodDescriptor = {
             options: {idempotencyLevel: undefined},
@@ -38,7 +38,7 @@ describe('authMiddleware', () => {
 
         const mockCall: ClientMiddlewareCall<unknown, unknown> = {
             method: mockMethodDescriptor,
-            requestStream: false, // Setze diese Werte entsprechend deiner Testbedingungen
+            requestStream: false,
             responseStream: false,
             request: mockRequest,
             next: mockNext,
diff --git a/packages/zitadel-server/src/middleware.test.ts b/packages/zitadel-server/src/middleware.test.ts
index 72e9b6489fe..1d6768a8d20 100644
--- a/packages/zitadel-server/src/middleware.test.ts
+++ b/packages/zitadel-server/src/middleware.test.ts
@@ -27,7 +27,7 @@ describe('authMiddleware', () => {
       it(name, async () => {
 
         const mockNext = jest.fn().mockImplementation(async function*() { });
-        const mockRequest = {}; // Ersetze dies mit einem geeigneten Mock Request-Objekt
+        const mockRequest = {};
 
         const mockMethodDescriptor: MethodDescriptor = {
             options: {idempotencyLevel: undefined},
@@ -38,7 +38,7 @@ describe('authMiddleware', () => {
 
         const mockCall: ClientMiddlewareCall<unknown, unknown> = {
             method: mockMethodDescriptor,
-            requestStream: false, // Setze diese Werte entsprechend deiner Testbedingungen
+            requestStream: false,
             responseStream: false,
             request: mockRequest,
             next: mockNext,