mirror of
https://github.com/zitadel/zitadel.git
synced 2025-12-23 19:26:59 +00:00
perf(actionsv2): execution target router (#10564)
# Which Problems Are Solved The event execution system currently uses a projection handler that subscribes to and processes all events for all instances. This creates a high static cost because the system over-fetches event data, handling many events that are not needed by most instances. This inefficiency is also reflected in high "rows returned" metrics in the database. # How the Problems Are Solved Eliminate the use of a project handler. Instead, events for which "execution targets" are defined, are directly pushed to the queue by the eventstore. A Router is populated in the Instance object in the authz middleware. - By joining the execution targets to the instance, no additional queries are needed anymore. - As part of the instance object, execution targets are now cached as well. - Events are queued within the same transaction, giving transactional guarantees on delivery. - Uses the "insert many fast` variant of River. Multiple jobs are queued in a single round-trip to the database. - Fix compatibility with PostgreSQL 15 # Additional Changes - The signing key was stored as plain-text in the river job payload in the DB. This violated our [Secrets Storage](https://zitadel.com/docs/concepts/architecture/secrets#secrets-storage) principle. This change removed the field and only uses the encrypted version of the signing key. - Fixed the target ordering from descending to ascending. - Some minor linter warnings on the use of `io.WriteString()`. # Additional Context - Introduced in https://github.com/zitadel/zitadel/pull/9249 - Closes https://github.com/zitadel/zitadel/issues/10553 - Closes https://github.com/zitadel/zitadel/issues/9832 - Closes https://github.com/zitadel/zitadel/issues/10372 - Closes https://github.com/zitadel/zitadel/issues/10492 --------- Co-authored-by: Stefan Benz <46600784+stebenz@users.noreply.github.com>
This commit is contained in:
@@ -10,6 +10,7 @@ import (
|
||||
"github.com/zitadel/zitadel/internal/crypto"
|
||||
"github.com/zitadel/zitadel/internal/domain"
|
||||
"github.com/zitadel/zitadel/internal/eventstore"
|
||||
target_domain "github.com/zitadel/zitadel/internal/execution/target"
|
||||
"github.com/zitadel/zitadel/internal/repository/execution"
|
||||
"github.com/zitadel/zitadel/internal/repository/target"
|
||||
"github.com/zitadel/zitadel/internal/zerrors"
|
||||
@@ -170,7 +171,7 @@ func TestCommands_SetExecutionRequest(t *testing.T) {
|
||||
target.NewAddedEvent(context.Background(),
|
||||
target.NewAggregate("target", "instance"),
|
||||
"name",
|
||||
domain.TargetTypeWebhook,
|
||||
target_domain.TargetTypeWebhook,
|
||||
"https://example.com",
|
||||
time.Second,
|
||||
true,
|
||||
@@ -225,7 +226,7 @@ func TestCommands_SetExecutionRequest(t *testing.T) {
|
||||
target.NewAddedEvent(context.Background(),
|
||||
target.NewAggregate("target", "instance"),
|
||||
"name",
|
||||
domain.TargetTypeWebhook,
|
||||
target_domain.TargetTypeWebhook,
|
||||
"https://example.com",
|
||||
time.Second,
|
||||
true,
|
||||
@@ -280,7 +281,7 @@ func TestCommands_SetExecutionRequest(t *testing.T) {
|
||||
target.NewAddedEvent(context.Background(),
|
||||
target.NewAggregate("target", "instance"),
|
||||
"name",
|
||||
domain.TargetTypeWebhook,
|
||||
target_domain.TargetTypeWebhook,
|
||||
"https://example.com",
|
||||
time.Second,
|
||||
true,
|
||||
@@ -852,7 +853,7 @@ func TestCommands_SetExecutionResponse(t *testing.T) {
|
||||
target.NewAddedEvent(context.Background(),
|
||||
target.NewAggregate("target", "instance"),
|
||||
"name",
|
||||
domain.TargetTypeWebhook,
|
||||
target_domain.TargetTypeWebhook,
|
||||
"https://example.com",
|
||||
time.Second,
|
||||
true,
|
||||
@@ -952,7 +953,7 @@ func TestCommands_SetExecutionResponse(t *testing.T) {
|
||||
target.NewAddedEvent(context.Background(),
|
||||
target.NewAggregate("target", "instance"),
|
||||
"name",
|
||||
domain.TargetTypeWebhook,
|
||||
target_domain.TargetTypeWebhook,
|
||||
"https://example.com",
|
||||
time.Second,
|
||||
true,
|
||||
|
||||
Reference in New Issue
Block a user