TheArchive/zitadel
1
0
Fork 0
mirror of https://github.com/zitadel/zitadel.git synced 2025-08-11 22:47:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(eventstore): precise decimal (#8527)

Browse Source 
# Which Problems Are Solved

Float64 which was used for the event.Position field is [not precise in
go and gets rounded](https://github.com/golang/go/issues/47300). This
can lead to unprecies position tracking of events and therefore
projections especially on cockcoachdb as the position used there is a
big number.

example of a unprecies position:
exact: 1725257931223002628
float64: 1725257931223002624.000000

# How the Problems Are Solved

The float64 was replaced by
[github.com/jackc/pgx-shopspring-decimal](https://github.com/jackc/pgx-shopspring-decimal).

# Additional Changes

Correct behaviour of makefile for load tests.
Rename `latestSequence`-queries to `latestPosition`
This commit is contained in:
Silvan
2024-09-06 11:19:19 +02:00
committed by GitHub
parent 2981ff04da
commit b522588d98
47 changed files with 319 additions and 215 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
internal/v2/eventstore/postgres/push_test.go
View File

@@ -8,6 +8,8 @@ import (
"testing"
"time"
"github.com/shopspring/decimal"
"github.com/zitadel/zitadel/internal/v2/database/mock"
"github.com/zitadel/zitadel/internal/v2/eventstore"
"github.com/zitadel/zitadel/internal/zerrors"
@@ -818,7 +820,7 @@ func Test_push(t *testing.T) {
[][]driver.Value{
{
time.Now(),
float64(123),
decimal.NewFromFloat(123).String(),
},
},
),
@@ -899,11 +901,11 @@ func Test_push(t *testing.T) {
[][]driver.Value{
{
time.Now(),
float64(123),
decimal.NewFromFloat(123).String(),
},
{
time.Now(),
float64(123.1),
decimal.NewFromFloat(123.1).String(),
},
},
),
@@ -984,11 +986,11 @@ func Test_push(t *testing.T) {
[][]driver.Value{
{
time.Now(),
float64(123),
decimal.NewFromFloat(123).String(),
},
{
time.Now(),
float64(123.1),
decimal.NewFromFloat(123.1).String(),
},
},
),
@@ -1044,7 +1046,7 @@ func Test_push(t *testing.T) {
[][]driver.Value{
{
time.Now(),
float64(123),
decimal.NewFromFloat(123).String(),
},
},
),
@@ -1099,7 +1101,7 @@ func Test_push(t *testing.T) {
[][]driver.Value{
{
time.Now(),
float64(123),
decimal.NewFromFloat(123).String(),
},
},
),
@@ -1181,11 +1183,11 @@ func Test_push(t *testing.T) {
[][]driver.Value{
{
time.Now(),
float64(123),
decimal.NewFromFloat(123).String(),
},
{
time.Now(),
float64(123.1),
decimal.NewFromFloat(123.1).String(),
},
},
),
@@ -1272,11 +1274,11 @@ func Test_push(t *testing.T) {
[][]driver.Value{
{
time.Now(),
float64(123),
decimal.NewFromFloat(123).String(),
},
{
time.Now(),
float64(123.1),
decimal.NewFromFloat(123.1).String(),
},
},
),