From bc885632fbb200acde43464205800ed251959f36 Mon Sep 17 00:00:00 2001 From: Livio Spring Date: Fri, 31 May 2024 10:11:32 +0200 Subject: [PATCH] fix(logging): reduce log level of errors in introspection and login UI (#8047) # Which Problems Are Solved Introspection errors such as invalid audience and errors in the login UI such as invalid user agents where all logged as severity error. # How the Problems Are Solved Log level for both general loggers is changed to `info`. # Additional Changes None # Additional Context - internal discussion --- internal/api/oidc/introspect.go | 6 +++++- internal/api/ui/login/renderer.go | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/internal/api/oidc/introspect.go b/internal/api/oidc/introspect.go index a2e59c9a45..41ffc3897f 100644 --- a/internal/api/oidc/introspect.go +++ b/internal/api/oidc/introspect.go @@ -80,7 +80,11 @@ func (s *Server) Introspect(ctx context.Context, r *op.Request[op.IntrospectionR // with active: false defer func() { if err != nil { - s.getLogger(ctx).ErrorContext(ctx, "oidc introspection", "err", err) + if zerrors.IsInternal(err) { + s.getLogger(ctx).ErrorContext(ctx, "oidc introspection", "err", err) + } else { + s.getLogger(ctx).InfoContext(ctx, "oidc introspection", "err", err) + } resp, err = op.NewResponse(new(oidc.IntrospectionResponse)), nil } }() diff --git a/internal/api/ui/login/renderer.go b/internal/api/ui/login/renderer.go index 2154248bae..e6234d9894 100644 --- a/internal/api/ui/login/renderer.go +++ b/internal/api/ui/login/renderer.go @@ -342,7 +342,11 @@ func (l *Login) renderInternalError(w http.ResponseWriter, r *http.Request, auth if authReq != nil { log = log.WithField("auth_req_id", authReq.ID) } - log.Error() + if zerrors.IsInternal(err) { + log.Error() + } else { + log.Info() + } _, msg = l.getErrorMessage(r, err) }