TheArchive/zitadel
1
0
Fork 0
mirror of https://github.com/zitadel/zitadel.git synced 2025-01-08 10:57:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: update IDP Success and Failure URLs to accept up to 2048 characters again (#8543)

Browse Source 
# Which Problems Are Solved

Durning the review of #8540, I noticed that the max length of the
success and failure url was set back to 200 instead of 2048 as changed
in #8327.
Looks like this was accidentally changed during the v2 GA release and
migration to v3 resources

# How the Problems Are Solved

Reapplied the change to 2048 max length

# Additional Changes

None

# Additional Context

- relates to #8327
- relates to #8343
  - requires backport until 2.58.x
- relates to #8494
  - requires backport to 2.60.x
This commit is contained in:
Livio Spring 2024-09-04 11:25:40 +02:00 committed by GitHub
parent d47ce93025
commit c26a07210c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
proto/zitadel/resources/user/v3alpha/authenticator.proto
View File

@ -383,21 +383,21 @@ message ReturnWebAuthNRegistrationCode {}
message RedirectURLs { message RedirectURLs {
// URL to which the user will be redirected after a successful login. // URL to which the user will be redirected after a successful login.
string success_url = 1 [ string success_url = 1 [
(validate.rules).string = {min_len: 1, max_len: 200, uri_ref: true}, (validate.rules).string = {min_len: 1, max_len: 2048, uri_ref: true},
(google.api.field_behavior) = REQUIRED, (google.api.field_behavior) = REQUIRED,
(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = { (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
min_length: 1; min_length: 1;
max_length: 200; max_length: 2048;
example: "\"https://custom.com/login/idp/success\""; example: "\"https://custom.com/login/idp/success\"";
} }
]; ];
// URL to which the user will be redirected after a failed login. // URL to which the user will be redirected after a failed login.
string failure_url = 2 [ string failure_url = 2 [
(validate.rules).string = {min_len: 1, max_len: 200, uri_ref: true}, (validate.rules).string = {min_len: 1, max_len: 2048, uri_ref: true},
(google.api.field_behavior) = REQUIRED, (google.api.field_behavior) = REQUIRED,
(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = { (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
min_length: 1; min_length: 1;
max_length: 200; max_length: 2048;
example: "\"https://custom.com/login/idp/fail\""; example: "\"https://custom.com/login/idp/fail\"";
} }
]; ];

8
proto/zitadel/user/v2/idp.proto
View File

@ -32,20 +32,20 @@ message LDAPCredentials {
message RedirectURLs { message RedirectURLs {
string success_url = 1 [ string success_url = 1 [
(validate.rules).string = {min_len: 1, max_len: 200, uri_ref: true}, (validate.rules).string = {min_len: 1, max_len: 2048, uri_ref: true},
(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = { (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
description: "URL on which the user will be redirected after a successful login" description: "URL on which the user will be redirected after a successful login"
min_length: 1; min_length: 1;
max_length: 200; max_length: 2048;
example: "\"https://custom.com/login/idp/success\""; example: "\"https://custom.com/login/idp/success\"";
} }
]; ];
string failure_url = 2 [ string failure_url = 2 [
(validate.rules).string = {min_len: 1, max_len: 200, uri_ref: true}, (validate.rules).string = {min_len: 1, max_len: 2048, uri_ref: true},
(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = { (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
description: "URL on which the user will be redirected after a failed login" description: "URL on which the user will be redirected after a failed login"
min_length: 1; min_length: 1;
max_length: 200; max_length: 2048;
example: "\"https://custom.com/login/idp/fail\""; example: "\"https://custom.com/login/idp/fail\"";
} }
]; ];

8
proto/zitadel/user/v2beta/idp.proto
View File

@ -32,20 +32,20 @@ message LDAPCredentials {
message RedirectURLs { message RedirectURLs {
string success_url = 1 [ string success_url = 1 [
(validate.rules).string = {min_len: 1, max_len: 200, uri_ref: true}, (validate.rules).string = {min_len: 1, max_len: 2048, uri_ref: true},
(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = { (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
description: "URL on which the user will be redirected after a successful login" description: "URL on which the user will be redirected after a successful login"
min_length: 1; min_length: 1;
max_length: 200; max_length: 2048;
example: "\"https://custom.com/login/idp/success\""; example: "\"https://custom.com/login/idp/success\"";
} }
]; ];
string failure_url = 2 [ string failure_url = 2 [
(validate.rules).string = {min_len: 1, max_len: 200, uri_ref: true}, (validate.rules).string = {min_len: 1, max_len: 2048, uri_ref: true},
(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = { (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
description: "URL on which the user will be redirected after a failed login" description: "URL on which the user will be redirected after a failed login"
min_length: 1; min_length: 1;
max_length: 200; max_length: 2048;
example: "\"https://custom.com/login/idp/fail\""; example: "\"https://custom.com/login/idp/fail\"";
} }
]; ];