From c4e0342c5f9bbdf0c6b25818f0f1c654bbcbf88c Mon Sep 17 00:00:00 2001 From: Livio Spring Date: Tue, 15 Jul 2025 09:09:22 -0400 Subject: [PATCH] chore(tests): fix tests (#10267) # Which Problems Are Solved The latest merge on main corrupted some unit tests. # How the Problems Are Solved Fix them as intended on the PR. # Additional Changes None # Additional Context relates to https://github.com/zitadel/zitadel/commit/4c942f3477b073e3e270079e6424b2b3797765d6 --- .../api/grpc/session/v2beta/session_test.go | 36 ++----------------- 1 file changed, 3 insertions(+), 33 deletions(-) diff --git a/internal/api/grpc/session/v2beta/session_test.go b/internal/api/grpc/session/v2beta/session_test.go index c088b5b886..16de30a9b1 100644 --- a/internal/api/grpc/session/v2beta/session_test.go +++ b/internal/api/grpc/session/v2beta/session_test.go @@ -328,24 +328,7 @@ func Test_listSessionsRequestToQuery(t *testing.T) { wantErr error }{ { - name: "default request", - args: args{ - ctx: authz.NewMockContext("123", "456", "789"), - req: &session.ListSessionsRequest{}, - }, - want: &query.SessionsSearchQueries{ - SearchRequest: query.SearchRequest{ - Offset: 0, - Limit: 0, - Asc: false, - }, - Queries: []query.SearchQuery{ - mustNewTextQuery(t, query.SessionColumnCreator, "789", query.TextEquals), - }, - }, - }, - { - name: "default request with sorting column", + name: "sorting column", args: args{ ctx: authz.NewMockContext("123", "456", "789"), req: &session.ListSessionsRequest{ @@ -359,9 +342,7 @@ func Test_listSessionsRequestToQuery(t *testing.T) { SortingColumn: query.SessionColumnCreationDate, Asc: false, }, - Queries: []query.SearchQuery{ - mustNewTextQuery(t, query.SessionColumnCreator, "789", query.TextEquals), - }, + Queries: []query.SearchQuery{}, }, }, { @@ -410,7 +391,6 @@ func Test_listSessionsRequestToQuery(t *testing.T) { mustNewListQuery(t, query.SessionColumnID, []interface{}{"4", "5", "6"}, query.ListIn), mustNewTextQuery(t, query.SessionColumnUserID, "10", query.TextEquals), mustNewTimestampQuery(t, query.SessionColumnCreationDate, creationDate, query.TimestampGreater), - mustNewTextQuery(t, query.SessionColumnCreator, "789", query.TextEquals), }, }, }, @@ -457,15 +437,6 @@ func Test_sessionQueriesToQuery(t *testing.T) { want []query.SearchQuery wantErr error }{ - { - name: "creator only", - args: args{ - ctx: authz.NewMockContext("123", "456", "789"), - }, - want: []query.SearchQuery{ - mustNewTextQuery(t, query.SessionColumnCreator, "789", query.TextEquals), - }, - }, { name: "invalid argument", args: args{ @@ -477,7 +448,7 @@ func Test_sessionQueriesToQuery(t *testing.T) { wantErr: zerrors.ThrowInvalidArgument(nil, "GRPC-Sfefs", "List.Query.Invalid"), }, { - name: "creator and sessions", + name: "sessions", args: args{ ctx: authz.NewMockContext("123", "456", "789"), queries: []*session.SearchQuery{ @@ -496,7 +467,6 @@ func Test_sessionQueriesToQuery(t *testing.T) { want: []query.SearchQuery{ mustNewListQuery(t, query.SessionColumnID, []interface{}{"1", "2", "3"}, query.ListIn), mustNewListQuery(t, query.SessionColumnID, []interface{}{"4", "5", "6"}, query.ListIn), - mustNewTextQuery(t, query.SessionColumnCreator, "789", query.TextEquals), }, }, }