feat(v3alpha): write actions (#8225)

# Which Problems Are Solved The current v3alpha actions APIs don't exactly adhere to the [new resources API design](https://zitadel.com/docs/apis/v3#standard-resources). # How the Problems Are Solved - **Breaking**: The current v3alpha actions APIs are removed. This is breaking. - **Resource Namespace**: New v3alpha actions APIs for targets and executions are added under the namespace /resources. - **Feature Flag**: New v3alpha actions APIs still have to be activated using the actions feature flag - **Reduced Executions Overhead**: Executions are managed similar to settings according to the new API design: an empty list of targets basically makes an execution a Noop. So a single method, SetExecution is enough to cover all use cases. Noop executions are not returned in future search requests. - **Compatibility**: The executions created with previous v3alpha APIs are still available to be managed with the new executions API. # Additional Changes - Removed integration tests which test executions but rely on readable targets. They are added again with #8169 # Additional Context Closes #8168
2025-08-12 14:37:32 +00:00 · 2024-07-31 14:42:12 +02:00
parent a1d24353db
commit cc3ec1e2a7
50 changed files with 2822 additions and 5570 deletions
--- a/internal/api/grpc/resources/action/v3alpha/target.go
+++ b/internal/api/grpc/resources/action/v3alpha/target.go
@@ -0,0 +1,121 @@
+package action
+
+import (
+	"context"
+
+	"github.com/muhlemmer/gu"
+
+	"github.com/zitadel/zitadel/internal/api/authz"
+	resource_object "github.com/zitadel/zitadel/internal/api/grpc/resources/object/v3alpha"
+	"github.com/zitadel/zitadel/internal/command"
+	"github.com/zitadel/zitadel/internal/domain"
+	"github.com/zitadel/zitadel/internal/eventstore/v1/models"
+	object "github.com/zitadel/zitadel/pkg/grpc/object/v3alpha"
+	action "github.com/zitadel/zitadel/pkg/grpc/resources/action/v3alpha"
+)
+
+func (s *Server) CreateTarget(ctx context.Context, req *action.CreateTargetRequest) (*action.CreateTargetResponse, error) {
+	if err := checkExecutionEnabled(ctx); err != nil {
+		return nil, err
+	}
+	add := createTargetToCommand(req)
+	instance := targetOwnerInstance(ctx)
+	details, err := s.command.AddTarget(ctx, add, instance.Id)
+	if err != nil {
+		return nil, err
+	}
+	return &action.CreateTargetResponse{
+		Details: resource_object.DomainToDetailsPb(details, instance, add.AggregateID),
+	}, nil
+}
+
+func (s *Server) PatchTarget(ctx context.Context, req *action.PatchTargetRequest) (*action.PatchTargetResponse, error) {
+	if err := checkExecutionEnabled(ctx); err != nil {
+		return nil, err
+	}
+	instance := targetOwnerInstance(ctx)
+	details, err := s.command.ChangeTarget(ctx, patchTargetToCommand(req), instance.Id)
+	if err != nil {
+		return nil, err
+	}
+	return &action.PatchTargetResponse{
+		Details: resource_object.DomainToDetailsPb(details, instance, req.GetId()),
+	}, nil
+}
+
+func (s *Server) DeleteTarget(ctx context.Context, req *action.DeleteTargetRequest) (*action.DeleteTargetResponse, error) {
+	if err := checkExecutionEnabled(ctx); err != nil {
+		return nil, err
+	}
+	instance := targetOwnerInstance(ctx)
+	details, err := s.command.DeleteTarget(ctx, req.GetId(), instance.Id)
+	if err != nil {
+		return nil, err
+	}
+	return &action.DeleteTargetResponse{
+		Details: resource_object.DomainToDetailsPb(details, instance, req.GetId()),
+	}, nil
+}
+
+func createTargetToCommand(req *action.CreateTargetRequest) *command.AddTarget {
+	reqTarget := req.GetTarget()
+	var (
+		targetType       domain.TargetType
+		interruptOnError bool
+	)
+	switch t := reqTarget.GetTargetType().(type) {
+	case *action.Target_RestWebhook:
+		targetType = domain.TargetTypeWebhook
+		interruptOnError = t.RestWebhook.InterruptOnError
+	case *action.Target_RestCall:
+		targetType = domain.TargetTypeCall
+		interruptOnError = t.RestCall.InterruptOnError
+	case *action.Target_RestAsync:
+		targetType = domain.TargetTypeAsync
+	}
+	return &command.AddTarget{
+		Name:             reqTarget.GetName(),
+		TargetType:       targetType,
+		Endpoint:         reqTarget.GetEndpoint(),
+		Timeout:          reqTarget.GetTimeout().AsDuration(),
+		InterruptOnError: interruptOnError,
+	}
+}
+
+func patchTargetToCommand(req *action.PatchTargetRequest) *command.ChangeTarget {
+	reqTarget := req.GetTarget()
+	if reqTarget == nil {
+		return nil
+	}
+	target := &command.ChangeTarget{
+		ObjectRoot: models.ObjectRoot{
+			AggregateID: req.GetId(),
+		},
+		Name:     reqTarget.Name,
+		Endpoint: reqTarget.Endpoint,
+	}
+	if reqTarget.TargetType != nil {
+		switch t := reqTarget.GetTargetType().(type) {
+		case *action.PatchTarget_RestWebhook:
+			target.TargetType = gu.Ptr(domain.TargetTypeWebhook)
+			target.InterruptOnError = gu.Ptr(t.RestWebhook.InterruptOnError)
+		case *action.PatchTarget_RestCall:
+			target.TargetType = gu.Ptr(domain.TargetTypeCall)
+			target.InterruptOnError = gu.Ptr(t.RestCall.InterruptOnError)
+		case *action.PatchTarget_RestAsync:
+			target.TargetType = gu.Ptr(domain.TargetTypeAsync)
+			target.InterruptOnError = gu.Ptr(false)
+		}
+	}
+	if reqTarget.Timeout != nil {
+		target.Timeout = gu.Ptr(reqTarget.GetTimeout().AsDuration())
+	}
+	return target
+}
+
+func targetOwnerInstance(ctx context.Context) *object.Owner {
+	return &object.Owner{
+		Type: object.OwnerType_OWNER_TYPE_INSTANCE,
+		Id:   authz.GetInstance(ctx).InstanceID(),
+	}
+}