diff --git a/login/CONTRIBUTING.md b/login/CONTRIBUTING.md index 2aa8b67c8d..783935984f 100644 --- a/login/CONTRIBUTING.md +++ b/login/CONTRIBUTING.md @@ -184,6 +184,8 @@ pnpm test:integration help To run the tests in docker against the latest release of Zitadel, use the following command: +:warning: The acceptance tests are not reliable at the moment :construction: + ```sh make login_test_acceptance ``` diff --git a/login/Makefile b/login/Makefile index e7b863dc72..3a8327a775 100644 --- a/login/Makefile +++ b/login/Makefile @@ -71,7 +71,7 @@ login_test_integration_cleanup: login_test_integration: login_test_integration_build $(LOGIN_DIR)scripts/run_or_skip.sh login_test_integration_run \ "$(LOGIN_TAG) \ - $(CORE_MOCK_TAG) \ + $(LOGIN_CORE_MOCK_TAG) \ $(LOGIN_TEST_INTEGRATION_TAG)" login_test_acceptance_build_bake: diff --git a/login/apps/login-test-integration/docker-compose.yaml b/login/apps/login-test-integration/docker-compose.yaml index 991523e88c..2f09a2253e 100644 --- a/login/apps/login-test-integration/docker-compose.yaml +++ b/login/apps/login-test-integration/docker-compose.yaml @@ -1,6 +1,6 @@ services: core-mock: - image: "${CORE_MOCK_TAG:-core-mock:local}" + image: "${LOGIN_CORE_MOCK_TAG:-login-core-mock:local}" container_name: integration-core-mock ports: - 22220:22220 diff --git a/login/docker-bake.hcl b/login/docker-bake.hcl index 3d98c09b2c..e44ecbc4e4 100644 --- a/login/docker-bake.hcl +++ b/login/docker-bake.hcl @@ -6,14 +6,6 @@ variable "DOCKERFILES_DIR" { default = "dockerfiles/" } -variable "UID" { - default = "1000" -} - -variable "GID" { - default = "1000" -} - # typescript-proto-client is used to generate the client code for the login service. # It is not login-prefixed, so it is easily extendable. # To extend this bake-file.hcl, set the context of all login-prefixed targets to a different directory. @@ -28,8 +20,10 @@ target "typescript-proto-client" { } target "typescript-proto-client-out" { - inherits = ["typescript-proto-client"] - target = "typescript-proto-client-out" + dockerfile = "${DOCKERFILES_DIR}typescript-proto-client-out.Dockerfile" + contexts = { + typescript-proto-client = "target:typescript-proto-client" + } output = [ "type=local,dest=packages/zitadel-proto" ] diff --git a/login/dockerfiles/login-client.Dockerfile b/login/dockerfiles/login-client.Dockerfile index 107c9e1846..4eb01615b4 100644 --- a/login/dockerfiles/login-client.Dockerfile +++ b/login/dockerfiles/login-client.Dockerfile @@ -1,7 +1,6 @@ FROM typescript-proto-client AS login-client COPY packages/zitadel-tsconfig packages/zitadel-tsconfig COPY packages/zitadel-client/package.json ./packages/zitadel-client/ -RUN ls -la RUN --mount=type=cache,id=pnpm,target=/pnpm/store \ pnpm install --frozen-lockfile --workspace-root --filter ./packages/zitadel-client COPY packages/zitadel-client ./packages/zitadel-client diff --git a/login/dockerfiles/typescript-proto-client-out.Dockerfile b/login/dockerfiles/typescript-proto-client-out.Dockerfile new file mode 100644 index 0000000000..3aa3c9d7d6 --- /dev/null +++ b/login/dockerfiles/typescript-proto-client-out.Dockerfile @@ -0,0 +1,5 @@ +FROM scratch AS typescript-proto-client-out +COPY --from=typescript-proto-client /build/packages/zitadel-proto/zitadel /zitadel +COPY --from=typescript-proto-client /build/packages/zitadel-proto/google /google +COPY --from=typescript-proto-client /build/packages/zitadel-proto/protoc-gen-openapiv2 /protoc-gen-openapiv2 +COPY --from=typescript-proto-client /build/packages/zitadel-proto/validate /validate diff --git a/login/dockerfiles/typescript-proto-client-out.Dockerfile.dockerignore b/login/dockerfiles/typescript-proto-client-out.Dockerfile.dockerignore new file mode 100644 index 0000000000..72e8ffc0db --- /dev/null +++ b/login/dockerfiles/typescript-proto-client-out.Dockerfile.dockerignore @@ -0,0 +1 @@ +* diff --git a/login/dockerfiles/typescript-proto-client.Dockerfile b/login/dockerfiles/typescript-proto-client.Dockerfile index a04d9e0ede..ee0848f52d 100644 --- a/login/dockerfiles/typescript-proto-client.Dockerfile +++ b/login/dockerfiles/typescript-proto-client.Dockerfile @@ -4,11 +4,3 @@ RUN --mount=type=cache,id=pnpm,target=/pnpm/store \ pnpm install --frozen-lockfile --workspace-root --filter zitadel-proto COPY packages/zitadel-proto ./packages/zitadel-proto RUN pnpm generate - -FROM scratch AS typescript-proto-client-out -COPY --from=typescript-proto-client /build/packages/zitadel-proto/zitadel /zitadel -COPY --from=typescript-proto-client /build/packages/zitadel-proto/google /google -COPY --from=typescript-proto-client /build/packages/zitadel-proto/protoc-gen-openapiv2 /protoc-gen-openapiv2 -COPY --from=typescript-proto-client /build/packages/zitadel-proto/validate /validate - -FROM typescript-proto-client diff --git a/login/dockerfiles/typescript-proto-client.Dockerfile.dockerignore b/login/dockerfiles/typescript-proto-client.Dockerfile.dockerignore index 0db4b8402e..e11d365847 100644 --- a/login/dockerfiles/typescript-proto-client.Dockerfile.dockerignore +++ b/login/dockerfiles/typescript-proto-client.Dockerfile.dockerignore @@ -1,2 +1,6 @@ * !/packages/zitadel-proto/ +packages/zitadel-proto/google +packages/zitadel-proto/zitadel +packages/zitadel-proto/protoc-gen-openapiv2 +packages/zitadel-proto/validate