fix(setup): make step 39 repeatable (#9085)

# Which Problems Are Solved

When downgrading zitadel and upgrading it again, it might be that orgs
deleted in this period still have stale entries in the fields table.

# How the Problems Are Solved

- Make the cleanup repeatable
- Scope the query by instance so that an index is used.

cmd/setup/39.go

@@ -3,9 +3,12 @@ package setup
 import (
 	"context"
 	_ "embed"
+	"fmt"
+
+	"github.com/zitadel/logging"
 
-	"github.com/zitadel/zitadel/internal/database"
 	"github.com/zitadel/zitadel/internal/eventstore"
+	"github.com/zitadel/zitadel/internal/repository/instance"
 )
 
 var (
@@ -14,14 +17,35 @@ var (
 )
 
 type DeleteStaleOrgFields struct {
-	dbClient *database.DB
+	eventstore *eventstore.Eventstore
 }
 
 func (mig *DeleteStaleOrgFields) Execute(ctx context.Context, _ eventstore.Event) error {
-	_, err := mig.dbClient.ExecContext(ctx, deleteStaleOrgFields)
-	return err
+	instances, err := mig.eventstore.InstanceIDs(
+		ctx,
+		eventstore.NewSearchQueryBuilder(eventstore.ColumnsInstanceIDs).
+			OrderDesc().
+			AddQuery().
+			AggregateTypes("instance").
+			EventTypes(instance.InstanceAddedEventType).
+			Builder(),
+	)
+	if err != nil {
+		return err
+	}
+	for i, instance := range instances {
+		logging.WithFields("instance_id", instance, "migration", mig.String(), "progress", fmt.Sprintf("%d/%d", i+1, len(instances))).Info("execute delete query")
+		if _, err := mig.eventstore.Client().ExecContext(ctx, deleteStaleOrgFields, instance); err != nil {
+			return err
+		}
+	}
+	return nil
 }
 
-func (mig *DeleteStaleOrgFields) String() string {
-	return "39_delete_stale_org_fields"
+func (*DeleteStaleOrgFields) Check(map[string]any) bool {
+	return true
+}
+
+func (*DeleteStaleOrgFields) String() string {
+	return "repeatable_delete_stale_org_fields"
 }