feat: idp and login policy configurations (#619)

* feat: oidc config

* fix: oidc configurations

* feat: oidc idp config

* feat: add oidc config test

* fix: tests

* fix: tests

* feat: translate new events

* feat: idp eventstore

* feat: idp eventstore

* fix: tests

* feat: command side idp

* feat: query side idp

* feat: idp config on org

* fix: tests

* feat: authz idp on org

* feat: org idps

* feat: login policy

* feat: login policy

* feat: login policy

* feat: add idp func on login policy

* feat: add validation to loginpolicy and idp provider

* feat: add default login policy

* feat: login policy on org

* feat: login policy on org

* fix: id config handlers

* fix: id config handlers

* fix: create idp on org

* fix: create idp on org

* fix: not existing idp config

* fix: default login policy

* fix: add login policy on org

* fix: idp provider search on org

* fix: test

* fix: remove idp on org

* fix: test

* fix: test

* fix: remove admin idp

* fix: logo src as byte

* fix: migration

* fix: tests

* Update internal/iam/repository/eventsourcing/iam.go

Co-authored-by: Silvan <silvan.reusser@gmail.com>

* Update internal/iam/repository/eventsourcing/iam_test.go

Co-authored-by: Silvan <silvan.reusser@gmail.com>

* Update internal/iam/repository/eventsourcing/iam_test.go

Co-authored-by: Silvan <silvan.reusser@gmail.com>

* Update internal/iam/repository/eventsourcing/model/login_policy.go

Co-authored-by: Silvan <silvan.reusser@gmail.com>

* Update internal/iam/repository/eventsourcing/model/login_policy.go

Co-authored-by: Silvan <silvan.reusser@gmail.com>

* Update internal/org/repository/eventsourcing/org_test.go

Co-authored-by: Silvan <silvan.reusser@gmail.com>

* Update internal/iam/repository/eventsourcing/model/login_policy_test.go

Co-authored-by: Silvan <silvan.reusser@gmail.com>

* Update internal/iam/repository/eventsourcing/model/login_policy_test.go

Co-authored-by: Silvan <silvan.reusser@gmail.com>

* fix: pr comments

* fix: tests

* Update types.go

* fix: merge request changes

* fix: reduce optimization

Co-authored-by: Silvan <silvan.reusser@gmail.com>
Co-authored-by: Livio Amstutz <livio.a@gmail.com>
This commit is contained in:
Fabi
2020-08-26 09:56:23 +02:00
committed by GitHub
parent f05c5bae24
commit db1d8f4efe
157 changed files with 37510 additions and 15698 deletions

View File

@@ -2,6 +2,7 @@ package eventsourcing
import (
"context"
iam_es_model "github.com/caos/zitadel/internal/iam/repository/eventsourcing/model"
"testing"
"github.com/caos/zitadel/internal/api/authz"
@@ -847,3 +848,583 @@ func TestOrgDomainRemovedAggregates(t *testing.T) {
})
}
}
func TestIdpConfigAddedAggregate(t *testing.T) {
type args struct {
ctx context.Context
existing *model.Org
new *iam_es_model.IDPConfig
aggCreator *es_models.AggregateCreator
}
type res struct {
eventLen int
eventTypes []es_models.EventType
wantErr bool
errFunc func(err error) bool
}
tests := []struct {
name string
args args
res res
}{
{
name: "add oidc idp configuration",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: &model.Org{ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"}, Name: "Name"},
new: &iam_es_model.IDPConfig{
ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"},
IDPConfigID: "IDPConfigID",
Name: "Name",
OIDCIDPConfig: &iam_es_model.OIDCIDPConfig{IDPConfigID: "IDPConfigID", ClientID: "ClientID"},
},
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
eventLen: 2,
eventTypes: []es_models.EventType{model.IDPConfigAdded, model.OIDCIDPConfigAdded},
},
},
{
name: "existing iam nil",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: nil,
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
wantErr: true,
errFunc: errors.IsPreconditionFailed,
},
},
{
name: "idp config nil",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: &model.Org{ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"}, Name: "Name"},
new: nil,
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
wantErr: true,
errFunc: errors.IsPreconditionFailed,
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
agg, err := IDPConfigAddedAggregate(tt.args.aggCreator, tt.args.existing, tt.args.new)(tt.args.ctx)
if !tt.res.wantErr && len(agg.Events) != tt.res.eventLen {
t.Errorf("got wrong event len: expected: %v, actual: %v ", tt.res.eventLen, len(agg.Events))
}
for i := 0; i < tt.res.eventLen; i++ {
if !tt.res.wantErr && agg.Events[i].Type != tt.res.eventTypes[i] {
t.Errorf("got wrong event type: expected: %v, actual: %v ", tt.res.eventTypes[i], agg.Events[i].Type.String())
}
if !tt.res.wantErr && agg.Events[i].Data == nil {
t.Errorf("should have data in event")
}
if !tt.res.wantErr && agg.Events[i].Data == nil {
t.Errorf("should have data in event")
}
}
if tt.res.wantErr && !tt.res.errFunc(err) {
t.Errorf("got wrong err: %v ", err)
}
})
}
}
func TestIdpConfigurationChangedAggregate(t *testing.T) {
type args struct {
ctx context.Context
existing *model.Org
new *iam_es_model.IDPConfig
aggCreator *es_models.AggregateCreator
}
type res struct {
eventLen int
eventTypes []es_models.EventType
wantErr bool
errFunc func(err error) bool
}
tests := []struct {
name string
args args
res res
}{
{
name: "change idp configuration",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: &model.Org{
ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"},
Name: "Name",
IDPs: []*iam_es_model.IDPConfig{
{IDPConfigID: "IDPConfigID", Name: "IDPName"},
}},
new: &iam_es_model.IDPConfig{
ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"},
IDPConfigID: "IDPConfigID",
Name: "NameChanged",
},
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
eventLen: 1,
eventTypes: []es_models.EventType{model.IDPConfigChanged},
},
},
{
name: "existing iam nil",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: nil,
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
wantErr: true,
errFunc: errors.IsPreconditionFailed,
},
},
{
name: "idp config nil",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: &model.Org{ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"}, Name: "Name"},
new: nil,
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
wantErr: true,
errFunc: errors.IsPreconditionFailed,
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
agg, err := IDPConfigChangedAggregate(tt.args.aggCreator, tt.args.existing, tt.args.new)(tt.args.ctx)
if !tt.res.wantErr && len(agg.Events) != tt.res.eventLen {
t.Errorf("got wrong event len: expected: %v, actual: %v ", tt.res.eventLen, len(agg.Events))
}
for i := 0; i < tt.res.eventLen; i++ {
if !tt.res.wantErr && agg.Events[i].Type != tt.res.eventTypes[i] {
t.Errorf("got wrong event type: expected: %v, actual: %v ", tt.res.eventTypes[i], agg.Events[i].Type.String())
}
if !tt.res.wantErr && agg.Events[i].Data == nil {
t.Errorf("should have data in event")
}
}
if tt.res.wantErr && !tt.res.errFunc(err) {
t.Errorf("got wrong err: %v ", err)
}
})
}
}
func TestIdpConfigurationRemovedAggregate(t *testing.T) {
type args struct {
ctx context.Context
existing *model.Org
new *iam_es_model.IDPConfig
provider *iam_es_model.IDPProvider
aggCreator *es_models.AggregateCreator
}
type res struct {
eventLen int
eventTypes []es_models.EventType
wantErr bool
errFunc func(err error) bool
}
tests := []struct {
name string
args args
res res
}{
{
name: "remove idp config",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: &model.Org{
ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"},
Name: "Name",
IDPs: []*iam_es_model.IDPConfig{
{IDPConfigID: "IDPConfigID", Name: "Name"},
}},
new: &iam_es_model.IDPConfig{
ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"},
IDPConfigID: "IDPConfigID",
Name: "Name",
},
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
eventLen: 1,
eventTypes: []es_models.EventType{model.IDPConfigRemoved},
},
},
{
name: "remove idp config with provider",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: &model.Org{
ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"},
Name: "Name",
IDPs: []*iam_es_model.IDPConfig{
{IDPConfigID: "IDPConfigID", Name: "Name"},
}},
new: &iam_es_model.IDPConfig{
ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"},
IDPConfigID: "IDPConfigID",
Name: "Name",
},
provider: &iam_es_model.IDPProvider{
IDPConfigID: "IDPConfigID",
},
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
eventLen: 2,
eventTypes: []es_models.EventType{model.IDPConfigRemoved, model.LoginPolicyIDPProviderCascadeRemoved},
},
},
{
name: "existing iam nil",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: nil,
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
wantErr: true,
errFunc: errors.IsPreconditionFailed,
},
},
{
name: "idp config nil",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: &model.Org{ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"}, Name: "Name"},
new: nil,
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
wantErr: true,
errFunc: errors.IsPreconditionFailed,
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
agg, err := IDPConfigRemovedAggregate(tt.args.ctx, tt.args.aggCreator, tt.args.existing, tt.args.new, tt.args.provider)
if !tt.res.wantErr && len(agg.Events) != tt.res.eventLen {
t.Errorf("got wrong event len: expected: %v, actual: %v ", tt.res.eventLen, len(agg.Events))
}
for i := 0; i < tt.res.eventLen; i++ {
if !tt.res.wantErr && agg.Events[i].Type != tt.res.eventTypes[i] {
t.Errorf("got wrong event type: expected: %v, actual: %v ", tt.res.eventTypes[i], agg.Events[i].Type.String())
}
if !tt.res.wantErr && agg.Events[i].Data == nil {
t.Errorf("should have data in event")
}
}
if tt.res.wantErr && !tt.res.errFunc(err) {
t.Errorf("got wrong err: %v ", err)
}
})
}
}
func TestIdpConfigurationDeactivatedAggregate(t *testing.T) {
type args struct {
ctx context.Context
existing *model.Org
new *iam_es_model.IDPConfig
aggCreator *es_models.AggregateCreator
}
type res struct {
eventLen int
eventTypes []es_models.EventType
wantErr bool
errFunc func(err error) bool
}
tests := []struct {
name string
args args
res res
}{
{
name: "deactivate idp config",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: &model.Org{
ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"},
Name: "Name",
IDPs: []*iam_es_model.IDPConfig{
{IDPConfigID: "IDPConfigID", Name: "Name"},
}},
new: &iam_es_model.IDPConfig{
ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"},
IDPConfigID: "IDPConfigID",
Name: "Name",
},
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
eventLen: 1,
eventTypes: []es_models.EventType{model.IDPConfigDeactivated},
},
},
{
name: "existing iam nil",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: nil,
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
wantErr: true,
errFunc: errors.IsPreconditionFailed,
},
},
{
name: "idp config nil",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: &model.Org{ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"}, Name: "Name"},
new: nil,
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
wantErr: true,
errFunc: errors.IsPreconditionFailed,
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
agg, err := IDPConfigDeactivatedAggregate(tt.args.aggCreator, tt.args.existing, tt.args.new)(tt.args.ctx)
if !tt.res.wantErr && len(agg.Events) != tt.res.eventLen {
t.Errorf("got wrong event len: expected: %v, actual: %v ", tt.res.eventLen, len(agg.Events))
}
for i := 0; i < tt.res.eventLen; i++ {
if !tt.res.wantErr && agg.Events[i].Type != tt.res.eventTypes[i] {
t.Errorf("got wrong event type: expected: %v, actual: %v ", tt.res.eventTypes[i], agg.Events[i].Type.String())
}
if !tt.res.wantErr && agg.Events[i].Data == nil {
t.Errorf("should have data in event")
}
}
if tt.res.wantErr && !tt.res.errFunc(err) {
t.Errorf("got wrong err: %v ", err)
}
})
}
}
func TestIdpConfigurationReactivatedAggregate(t *testing.T) {
type args struct {
ctx context.Context
existing *model.Org
new *iam_es_model.IDPConfig
aggCreator *es_models.AggregateCreator
}
type res struct {
eventLen int
eventTypes []es_models.EventType
wantErr bool
errFunc func(err error) bool
}
tests := []struct {
name string
args args
res res
}{
{
name: "deactivate app",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: &model.Org{
ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"},
Name: "Name",
IDPs: []*iam_es_model.IDPConfig{
{IDPConfigID: "IDPConfigID", Name: "Name"},
}},
new: &iam_es_model.IDPConfig{
ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"},
IDPConfigID: "IDPConfigID",
Name: "Name",
},
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
eventLen: 1,
eventTypes: []es_models.EventType{model.IDPConfigReactivated},
},
},
{
name: "existing iam nil",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: nil,
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
wantErr: true,
errFunc: errors.IsPreconditionFailed,
},
},
{
name: "idp config nil",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: &model.Org{ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"}, Name: "Name"},
new: nil,
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
wantErr: true,
errFunc: errors.IsPreconditionFailed,
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
agg, err := IDPConfigReactivatedAggregate(tt.args.aggCreator, tt.args.existing, tt.args.new)(tt.args.ctx)
if !tt.res.wantErr && len(agg.Events) != tt.res.eventLen {
t.Errorf("got wrong event len: expected: %v, actual: %v ", tt.res.eventLen, len(agg.Events))
}
for i := 0; i < tt.res.eventLen; i++ {
if !tt.res.wantErr && agg.Events[i].Type != tt.res.eventTypes[i] {
t.Errorf("got wrong event type: expected: %v, actual: %v ", tt.res.eventTypes[i], agg.Events[i].Type.String())
}
if !tt.res.wantErr && agg.Events[i].Data == nil {
t.Errorf("should have data in event")
}
}
if tt.res.wantErr && !tt.res.errFunc(err) {
t.Errorf("got wrong err: %v ", err)
}
})
}
}
func TestOIDCConfigChangedAggregate(t *testing.T) {
type args struct {
ctx context.Context
existing *model.Org
new *iam_es_model.OIDCIDPConfig
aggCreator *es_models.AggregateCreator
}
type res struct {
eventLen int
eventTypes []es_models.EventType
wantErr bool
errFunc func(err error) bool
}
tests := []struct {
name string
args args
res res
}{
{
name: "change oidc config",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: &model.Org{
ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"},
Name: "Name",
IDPs: []*iam_es_model.IDPConfig{
{IDPConfigID: "IDPConfigID", Name: "Name", OIDCIDPConfig: &iam_es_model.OIDCIDPConfig{IDPConfigID: "IDPConfigID", ClientID: "ClientID"}},
}},
new: &iam_es_model.OIDCIDPConfig{
ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"},
IDPConfigID: "IDPConfigID",
ClientID: "ClientIDChanged",
},
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
eventLen: 1,
eventTypes: []es_models.EventType{model.OIDCIDPConfigChanged},
},
},
{
name: "no changes",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: &model.Org{
ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"},
Name: "Name",
IDPs: []*iam_es_model.IDPConfig{
{IDPConfigID: "IDPConfigID", Name: "Name", OIDCIDPConfig: &iam_es_model.OIDCIDPConfig{IDPConfigID: "IDPConfigID", ClientID: "ClientID"}},
}},
new: &iam_es_model.OIDCIDPConfig{
ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"},
IDPConfigID: "IDPConfigID",
ClientID: "ClientID",
},
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
wantErr: true,
errFunc: errors.IsPreconditionFailed,
},
},
{
name: "existing iam nil",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: nil,
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
wantErr: true,
errFunc: errors.IsPreconditionFailed,
},
},
{
name: "oidc config nil",
args: args{
ctx: authz.NewMockContext("orgID", "userID"),
existing: &model.Org{ObjectRoot: es_models.ObjectRoot{AggregateID: "AggregateID"}, Name: "Name"},
new: nil,
aggCreator: es_models.NewAggregateCreator("Test"),
},
res: res{
wantErr: true,
errFunc: errors.IsPreconditionFailed,
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
agg, err := OIDCIDPConfigChangedAggregate(tt.args.aggCreator, tt.args.existing, tt.args.new)(tt.args.ctx)
if !tt.res.wantErr && len(agg.Events) != tt.res.eventLen {
t.Errorf("got wrong event len: expected: %v, actual: %v ", tt.res.eventLen, len(agg.Events))
}
for i := 0; i < tt.res.eventLen; i++ {
if !tt.res.wantErr && agg.Events[i].Type != tt.res.eventTypes[i] {
t.Errorf("got wrong event type: expected: %v, actual: %v ", tt.res.eventTypes[i], agg.Events[i].Type.String())
}
if !tt.res.wantErr && agg.Events[i].Data == nil {
t.Errorf("should have data in event")
}
}
if tt.res.wantErr && !tt.res.errFunc(err) {
t.Errorf("got wrong err: %v ", err)
}
})
}
}