From db3c785bc6cdf234f2721168ffa92aad0e37c2b8 Mon Sep 17 00:00:00 2001
From: Marco Ardizzone <marco@zitadel.com>
Date: Tue, 29 Apr 2025 14:53:38 +0200
Subject: [PATCH] feat: Integration tests for DeleteInstance v2 endpoint
 (#9452)

---
 .../v2/integration_test/instance_test.go      | 67 +++++++++++++++++++
 1 file changed, 67 insertions(+)

diff --git a/internal/api/grpc/instance/v2/integration_test/instance_test.go b/internal/api/grpc/instance/v2/integration_test/instance_test.go
index 43abf6f9275..549765b51dd 100644
--- a/internal/api/grpc/instance/v2/integration_test/instance_test.go
+++ b/internal/api/grpc/instance/v2/integration_test/instance_test.go
@@ -101,3 +101,70 @@ func TestCreateInstance(t *testing.T) {
 		})
 	}
 }
+
+func TestDeleteInstace(t *testing.T) {
+	// Given
+	inst := integration.NewInstance(CTXWithSysAuthZ)
+
+	tt := []struct {
+		testName           string
+		inputRequest       *instance.DeleteInstanceRequest
+		inputContext       context.Context
+		expectedErrorMsg   string
+		expectedErrorCode  codes.Code
+		expectedInstanceID string
+	}{
+		{
+			testName: "when invalid context should return unauthN error",
+			inputRequest: &instance.DeleteInstanceRequest{
+				InstanceId: " ",
+			},
+			inputContext:      context.Background(),
+			expectedErrorCode: codes.Unauthenticated,
+			expectedErrorMsg:  "auth header missing",
+		},
+		{
+			testName: "when invalid input should return invalid argument error",
+			inputRequest: &instance.DeleteInstanceRequest{
+				InstanceId: " ",
+			},
+			inputContext:      CTXWithSysAuthZ,
+			expectedErrorCode: codes.InvalidArgument,
+			expectedErrorMsg:  "instance_id must not be empty (instance_id)",
+		},
+		{
+			testName: "when invalid input should return invalid argument error",
+			inputRequest: &instance.DeleteInstanceRequest{
+				InstanceId: inst.ID() + "invalid",
+			},
+			inputContext:      CTXWithSysAuthZ,
+			expectedErrorCode: codes.NotFound,
+			expectedErrorMsg:  "Instance not found (COMMA-AE3GS)",
+		},
+		{
+			testName: "when invalid input should return invalid argument error",
+			inputRequest: &instance.DeleteInstanceRequest{
+				InstanceId: inst.ID(),
+			},
+			inputContext:       CTXWithSysAuthZ,
+			expectedInstanceID: inst.ID(),
+		},
+	}
+
+	for _, tc := range tt {
+		t.Run(tc.testName, func(t *testing.T) {
+			// Test
+			res, err := inst.Client.InstanceV2Beta.DeleteInstance(tc.inputContext, tc.inputRequest)
+
+			// Verify
+			assert.Equal(t, tc.expectedErrorCode, status.Code(err))
+			assert.Equal(t, tc.expectedErrorMsg, status.Convert(err).Message())
+			if tc.expectedErrorMsg == "" {
+				require.NotNil(t, res)
+				require.NotNil(t, res.GetDetails())
+				assert.Equal(t, tc.expectedInstanceID, res.GetDetails().GetResourceOwner())
+				assert.NotEmpty(t, res.GetDetails().GetChangeDate())
+			}
+		})
+	}
+}