fix: make user creation errors helpful (#5382)

* fix: make user creation errors helpful

* fix linting and unit testing errors

* fix linting

* make zitadel config reusable

* fix human validations

* translate ssr errors

* make zitadel config reusable

* cover more translations for ssr

* handle email validation message centrally

* fix unit tests

* fix linting

* align signatures

* use more precise wording

* handle phone validation message centrally

* fix: return specific profile errors

* docs: edit comments

* fix unit tests

---------

Co-authored-by: Silvan <silvan.reusser@gmail.com>

internal/repository/user/human.go

@@ -38,9 +38,9 @@ type HumanAddedEvent struct {
 	PreferredLanguage language.Tag  `json:"preferredLanguage,omitempty"`
 	Gender            domain.Gender `json:"gender,omitempty"`
 
-	EmailAddress string `json:"email,omitempty"`
+	EmailAddress domain.EmailAddress `json:"email,omitempty"`
 
-	PhoneNumber string `json:"phone,omitempty"`
+	PhoneNumber domain.PhoneNumber `json:"phone,omitempty"`
 
 	Country       string `json:"country,omitempty"`
 	Locality      string `json:"locality,omitempty"`
@@ -75,7 +75,7 @@ func (e *HumanAddedEvent) AddAddressData(
 }
 
 func (e *HumanAddedEvent) AddPhoneData(
-	phoneNumber string,
+	phoneNumber domain.PhoneNumber,
 ) {
 	e.PhoneNumber = phoneNumber
 }
@@ -99,7 +99,7 @@ func NewHumanAddedEvent(
 	displayName string,
 	preferredLanguage language.Tag,
 	gender domain.Gender,
-	emailAddress string,
+	emailAddress domain.EmailAddress,
 	userLoginMustBeDomain bool,
 ) *HumanAddedEvent {
 	return &HumanAddedEvent{
@@ -133,30 +133,24 @@ func HumanAddedEventMapper(event *repository.Event) (eventstore.Event, error) {
 }
 
 type HumanRegisteredEvent struct {
-	eventstore.BaseEvent `json:"-"`
-
+	eventstore.BaseEvent  `json:"-"`
 	UserName              string `json:"userName"`
 	userLoginMustBeDomain bool
-
-	FirstName         string        `json:"firstName,omitempty"`
-	LastName          string        `json:"lastName,omitempty"`
-	NickName          string        `json:"nickName,omitempty"`
-	DisplayName       string        `json:"displayName,omitempty"`
-	PreferredLanguage language.Tag  `json:"preferredLanguage,omitempty"`
-	Gender            domain.Gender `json:"gender,omitempty"`
-
-	EmailAddress string `json:"email,omitempty"`
-
-	PhoneNumber string `json:"phone,omitempty"`
-
-	Country       string `json:"country,omitempty"`
-	Locality      string `json:"locality,omitempty"`
-	PostalCode    string `json:"postalCode,omitempty"`
-	Region        string `json:"region,omitempty"`
-	StreetAddress string `json:"streetAddress,omitempty"`
-
-	Secret         *crypto.CryptoValue `json:"secret,omitempty"`
-	ChangeRequired bool                `json:"changeRequired,omitempty"`
+	FirstName             string              `json:"firstName,omitempty"`
+	LastName              string              `json:"lastName,omitempty"`
+	NickName              string              `json:"nickName,omitempty"`
+	DisplayName           string              `json:"displayName,omitempty"`
+	PreferredLanguage     language.Tag        `json:"preferredLanguage,omitempty"`
+	Gender                domain.Gender       `json:"gender,omitempty"`
+	EmailAddress          domain.EmailAddress `json:"email,omitempty"`
+	PhoneNumber           domain.PhoneNumber  `json:"phone,omitempty"`
+	Country               string              `json:"country,omitempty"`
+	Locality              string              `json:"locality,omitempty"`
+	PostalCode            string              `json:"postalCode,omitempty"`
+	Region                string              `json:"region,omitempty"`
+	StreetAddress         string              `json:"streetAddress,omitempty"`
+	Secret                *crypto.CryptoValue `json:"secret,omitempty"`
+	ChangeRequired        bool                `json:"changeRequired,omitempty"`
 }
 
 func (e *HumanRegisteredEvent) Data() interface{} {
@@ -182,7 +176,7 @@ func (e *HumanRegisteredEvent) AddAddressData(
 }
 
 func (e *HumanRegisteredEvent) AddPhoneData(
-	phoneNumber string,
+	phoneNumber domain.PhoneNumber,
 ) {
 	e.PhoneNumber = phoneNumber
 }
@@ -206,7 +200,7 @@ func NewHumanRegisteredEvent(
 	displayName string,
 	preferredLanguage language.Tag,
 	gender domain.Gender,
-	emailAddress string,
+	emailAddress domain.EmailAddress,
 	userLoginMustBeDomain bool,
 ) *HumanRegisteredEvent {
 	return &HumanRegisteredEvent{

internal/repository/user/human_email.go

@@ -5,10 +5,10 @@ import (
 	"encoding/json"
 	"time"
 
-	"github.com/zitadel/zitadel/internal/eventstore"
-
 	"github.com/zitadel/zitadel/internal/crypto"
+	"github.com/zitadel/zitadel/internal/domain"
 	"github.com/zitadel/zitadel/internal/errors"
+	"github.com/zitadel/zitadel/internal/eventstore"
 	"github.com/zitadel/zitadel/internal/eventstore/repository"
 )
 
@@ -24,7 +24,7 @@ const (
 type HumanEmailChangedEvent struct {
 	eventstore.BaseEvent `json:"-"`
 
-	EmailAddress string `json:"email,omitempty"`
+	EmailAddress domain.EmailAddress `json:"email,omitempty"`
 }
 
 func (e *HumanEmailChangedEvent) Data() interface{} {
@@ -35,7 +35,7 @@ func (e *HumanEmailChangedEvent) UniqueConstraints() []*eventstore.EventUniqueCo
 	return nil
 }
 
-func NewHumanEmailChangedEvent(ctx context.Context, aggregate *eventstore.Aggregate, emailAddress string) *HumanEmailChangedEvent {
+func NewHumanEmailChangedEvent(ctx context.Context, aggregate *eventstore.Aggregate, emailAddress domain.EmailAddress) *HumanEmailChangedEvent {
 	return &HumanEmailChangedEvent{
 		BaseEvent: *eventstore.NewBaseEventForPush(
 			ctx,

internal/repository/user/human_phone.go

@@ -6,6 +6,7 @@ import (
 	"time"
 
 	"github.com/zitadel/zitadel/internal/crypto"
+	"github.com/zitadel/zitadel/internal/domain"
 	"github.com/zitadel/zitadel/internal/errors"
 	"github.com/zitadel/zitadel/internal/eventstore"
 	"github.com/zitadel/zitadel/internal/eventstore/repository"
@@ -24,7 +25,7 @@ const (
 type HumanPhoneChangedEvent struct {
 	eventstore.BaseEvent `json:"-"`
 
-	PhoneNumber string `json:"phone,omitempty"`
+	PhoneNumber domain.PhoneNumber `json:"phone,omitempty"`
 }
 
 func (e *HumanPhoneChangedEvent) Data() interface{} {
@@ -35,7 +36,7 @@ func (e *HumanPhoneChangedEvent) UniqueConstraints() []*eventstore.EventUniqueCo
 	return nil
 }
 
-func NewHumanPhoneChangedEvent(ctx context.Context, aggregate *eventstore.Aggregate, phone string) *HumanPhoneChangedEvent {
+func NewHumanPhoneChangedEvent(ctx context.Context, aggregate *eventstore.Aggregate, phone domain.PhoneNumber) *HumanPhoneChangedEvent {
 	return &HumanPhoneChangedEvent{
 		BaseEvent: *eventstore.NewBaseEventForPush(
 			ctx,