fix: make user creation errors helpful (#5382)

* fix: make user creation errors helpful

* fix linting and unit testing errors

* fix linting

* make zitadel config reusable

* fix human validations

* translate ssr errors

* make zitadel config reusable

* cover more translations for ssr

* handle email validation message centrally

* fix unit tests

* fix linting

* align signatures

* use more precise wording

* handle phone validation message centrally

* fix: return specific profile errors

* docs: edit comments

* fix unit tests

---------

Co-authored-by: Silvan <silvan.reusser@gmail.com>

internal/user/model/email.go

@@ -21,10 +21,6 @@ type EmailCode struct {
 	Expiry time.Duration
 }
 
-func (e *Email) IsValid() bool {
-	return e.EmailAddress != ""
-}
-
 func (e *Email) GenerateEmailCodeIfNeeded(emailGenerator crypto.Generator) (*EmailCode, error) {
 	var emailCode *EmailCode
 	if e.IsEmailVerified {

internal/user/model/phone.go

@@ -3,9 +3,7 @@ package model
 import (
 	"time"
 
-	"github.com/ttacon/libphonenumber"
 	"github.com/zitadel/zitadel/internal/crypto"
-	caos_errs "github.com/zitadel/zitadel/internal/errors"
 	es_models "github.com/zitadel/zitadel/internal/eventstore/v1/models"
 )
 
@@ -27,20 +25,6 @@ type PhoneCode struct {
 	Expiry time.Duration
 }
 
-func (p *Phone) IsValid() bool {
-	err := p.formatPhone()
-	return p.PhoneNumber != "" && err == nil
-}
-
-func (p *Phone) formatPhone() error {
-	phoneNr, err := libphonenumber.Parse(p.PhoneNumber, defaultRegion)
-	if err != nil {
-		return caos_errs.ThrowPreconditionFailed(nil, "EVENT-so0wa", "Phonenumber is invalid")
-	}
-	p.PhoneNumber = libphonenumber.Format(phoneNr, libphonenumber.E164)
-	return nil
-}
-
 func (p *Phone) GeneratePhoneCodeIfNeeded(phoneGenerator crypto.Generator) (*PhoneCode, error) {
 	var phoneCode *PhoneCode
 	if p.IsPhoneVerified {

internal/user/model/phone_test.go

@@ -1,107 +0,0 @@
-package model
-
-import (
-	"testing"
-
-	caos_errs "github.com/zitadel/zitadel/internal/errors"
-)
-
-func TestFormatPhoneNumber(t *testing.T) {
-	type args struct {
-		phone *Phone
-	}
-	tests := []struct {
-		name    string
-		args    args
-		result  *Phone
-		errFunc func(err error) bool
-	}{
-		{
-			name: "invalid phone number",
-			args: args{
-				phone: &Phone{
-					PhoneNumber: "PhoneNumber",
-				},
-			},
-			errFunc: caos_errs.IsPreconditionFailed,
-		},
-		{
-			name: "format phone 071...",
-			args: args{
-				phone: &Phone{
-					PhoneNumber: "0711234567",
-				},
-			},
-			result: &Phone{
-				PhoneNumber: "+41711234567",
-			},
-		},
-		{
-			name: "format phone 0041...",
-			args: args{
-				phone: &Phone{
-					PhoneNumber: "0041711234567",
-				},
-			},
-			result: &Phone{
-				PhoneNumber: "+41711234567",
-			},
-		},
-		{
-			name: "format phone 071 xxx xx xx",
-			args: args{
-				phone: &Phone{
-					PhoneNumber: "071 123 45 67",
-				},
-			},
-			result: &Phone{
-				PhoneNumber: "+41711234567",
-			},
-		},
-		{
-			name: "format phone +4171 xxx xx xx",
-			args: args{
-				phone: &Phone{
-					PhoneNumber: "+4171 123 45 67",
-				},
-			},
-			result: &Phone{
-				PhoneNumber: "+41711234567",
-			},
-		},
-		{
-			name: "format phone 004171 xxx xx xx",
-			args: args{
-				phone: &Phone{
-					PhoneNumber: "004171 123 45 67",
-				},
-			},
-			result: &Phone{
-				PhoneNumber: "+41711234567",
-			},
-		},
-		{
-			name: "format non swiss phone 004371 xxx xx xx",
-			args: args{
-				phone: &Phone{
-					PhoneNumber: "004371 123 45 67",
-				},
-			},
-			result: &Phone{
-				PhoneNumber: "+43711234567",
-			},
-		},
-	}
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			err := tt.args.phone.formatPhone()
-
-			if tt.errFunc == nil && tt.result.PhoneNumber != tt.args.phone.PhoneNumber {
-				t.Errorf("got wrong result: expected: %v, actual: %v ", tt.args.phone.PhoneNumber, tt.result.PhoneNumber)
-			}
-			if tt.errFunc != nil && !tt.errFunc(err) {
-				t.Errorf("got wrong err: %v ", err)
-			}
-		})
-	}
-}