TheArchive/zitadel
1
0
Fork 0
mirror of https://github.com/zitadel/zitadel.git synced 2025-08-11 21:07:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(oidc): optimize client verification (#6999)

Browse Source 
* fix some spelling errors

* client credential auth

* implementation of client auth

* improve error handling

* unit test command package

* unit test database package

* unit test query package

* cleanup unused tracing func

* fix integration tests

* errz to zerrors

* fix linting and import issues

* fix another linting error

* integration test with client secret

* Revert "integration test with client secret"

This reverts commit 0814ba522f.

* add integration tests

* client credentials integration test

* resolve comments

* pin oidc v3.5.0
This commit is contained in:
Tim Möhlmann
2023-12-05 19:01:03 +02:00
committed by GitHub
parent 51cfb9564a
commit ec03340b67
46 changed files with 1666 additions and 781 deletions
Download Patch File Download Diff File Expand all files Collapse all files

126
internal/command/command_test.go
View File

@@ -1,11 +1,19 @@
package command
import (
"context"
"io"
"os"
"testing"
"time"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"golang.org/x/text/language"
"github.com/zitadel/zitadel/internal/eventstore"
"github.com/zitadel/zitadel/internal/i18n"
"github.com/zitadel/zitadel/internal/repository/user"
)
var (
@@ -18,5 +26,121 @@ var (
func TestMain(m *testing.M) {
i18n.SupportLanguages(SupportedLanguages...)
m.Run()
os.Exit(m.Run())
}
func TestCommands_asyncPush(t *testing.T) {
// make sure the test terminates on deadlock
background := context.Background()
agg := user.NewAggregate("userID", "orgID")
cmd := user.NewMachineSecretCheckFailedEvent(background, &agg.Aggregate)
tests := []struct {
name string
pushCtx func() (context.Context, context.CancelFunc)
eventstore func(*testing.T) *eventstore.Eventstore
closeCtx func() (context.Context, context.CancelFunc)
wantCloseErr bool
}{
{
name: "push error",
pushCtx: func() (context.Context, context.CancelFunc) {
return context.WithCancel(background)
},
eventstore: expectEventstore(
expectPushFailed(io.ErrClosedPipe, cmd),
),
closeCtx: func() (context.Context, context.CancelFunc) {
return context.WithTimeout(background, time.Second)
},
wantCloseErr: false,
},
{
name: "success",
pushCtx: func() (context.Context, context.CancelFunc) {
return context.WithCancel(background)
},
eventstore: expectEventstore(
expectPushSlow(time.Second/10, cmd),
),
closeCtx: func() (context.Context, context.CancelFunc) {
return context.WithTimeout(background, time.Second)
},
wantCloseErr: false,
},
{
name: "success after push context cancels",
pushCtx: func() (context.Context, context.CancelFunc) {
ctx, cancel := context.WithCancel(background)
cancel()
return ctx, cancel
},
eventstore: expectEventstore(
expectPushSlow(time.Second/10, cmd),
),
closeCtx: func() (context.Context, context.CancelFunc) {
return context.WithTimeout(background, time.Second)
},
wantCloseErr: false,
},
{
name: "success after push context timeout",
pushCtx: func() (context.Context, context.CancelFunc) {
return context.WithTimeout(background, time.Second/100)
},
eventstore: expectEventstore(
expectPushSlow(time.Second/10, cmd),
),
closeCtx: func() (context.Context, context.CancelFunc) {
return context.WithTimeout(background, time.Second)
},
wantCloseErr: false,
},
{
name: "success after push context timeout",
pushCtx: func() (context.Context, context.CancelFunc) {
return context.WithTimeout(background, time.Second/100)
},
eventstore: expectEventstore(
expectPushSlow(time.Second/10, cmd),
),
closeCtx: func() (context.Context, context.CancelFunc) {
return context.WithTimeout(background, time.Second)
},
wantCloseErr: false,
},
{
name: "close timeout error",
pushCtx: func() (context.Context, context.CancelFunc) {
return context.WithCancel(background)
},
eventstore: expectEventstore(
expectPushSlow(time.Second/10, cmd),
),
closeCtx: func() (context.Context, context.CancelFunc) {
return context.WithTimeout(background, time.Second/100)
},
wantCloseErr: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
c := &Commands{
eventstore: tt.eventstore(t),
}
c.eventstore.PushTimeout = 10 * time.Second
pushCtx, cancel := tt.pushCtx()
c.asyncPush(pushCtx, cmd)
cancel()
closeCtx, cancel := tt.closeCtx()
defer cancel()
err := c.Close(closeCtx)
if tt.wantCloseErr {
assert.Error(t, err)
return
}
require.NoError(t, err)
})
}
}