mirror of
https://github.com/zitadel/zitadel.git
synced 2025-08-11 14:17:34 +00:00
64a03fba28
<!-- Please inform yourself about the contribution guidelines on submitting a PR here: https://github.com/zitadel/zitadel/blob/main/CONTRIBUTING.md#submit-a-pull-request-pr. Take note of how PR/commit titles should be written and replace the template texts in the sections below. Don't remove any of the sections. It is important that the commit history clearly shows what is changed and why. Important: By submitting a contribution you agree to the terms from our Licensing Policy as described here: https://github.com/zitadel/zitadel/blob/main/LICENSING.md#community-contributions. --> # Which Problems Are Solved The current user V2 API returns a `[]byte` containing a whole HTML document including the form on `StartIdentifyProviderIntent` for intents based on form post (e.g. SAML POST bindings). This is not usable for most clients as they cannot handle that and render a whole page inside their app. For redirect based intents, the url to which the client needs to redirect is returned. # How the Problems Are Solved - Changed the returned type to a new `FormData` message containing the url and a `fields` map. - internal changes: - Session.GetAuth now returns an `Auth` interfacce and error instead of (content string, redirect bool) - Auth interface has two implementations: `RedirectAuth` and `FormAuth` - All use of the GetAuth function now type switch on the returned auth object - A template has been added to the login UI to execute the form post automatically (as is). # Additional Changes - Some intent integration test did not check the redirect url and were wrongly configured. # Additional Context - relates to zitadel/typescript#410
52 lines
1.4 KiB
Go
52 lines
1.4 KiB
Go
package idp
|
|
|
|
import (
|
|
"context"
|
|
"time"
|
|
)
|
|
|
|
// Session is the minimal implementation for a session of a 3rd party authentication [Provider]
|
|
type Session interface {
|
|
GetAuth(ctx context.Context) (Auth, error)
|
|
PersistentParameters() map[string]any
|
|
FetchUser(ctx context.Context) (User, error)
|
|
ExpiresAt() time.Time
|
|
}
|
|
|
|
type Auth interface {
|
|
auth()
|
|
}
|
|
|
|
type RedirectAuth struct {
|
|
RedirectURL string
|
|
}
|
|
|
|
func (r *RedirectAuth) auth() {}
|
|
|
|
type FormAuth struct {
|
|
URL string
|
|
Fields map[string]string
|
|
}
|
|
|
|
func (f *FormAuth) auth() {}
|
|
|
|
// SessionSupportsMigration is an optional extension to the Session interface.
|
|
// It can be implemented to support migrating users, were the initial external id has changed because of a migration of the Provider type.
|
|
// E.g. when a user was linked on a generic OIDC provider and this provider has now been migrated to an AzureAD provider.
|
|
// In this case OIDC used the `sub` claim and Azure now uses the id of the user endpoint, which differ.
|
|
// The RetrievePreviousID will return the `sub` claim again, so that the user can be matched and safely migrated to the new id.
|
|
type SessionSupportsMigration interface {
|
|
RetrievePreviousID() (previousID string, err error)
|
|
}
|
|
|
|
func Redirect(redirectURL string) (*RedirectAuth, error) {
|
|
return &RedirectAuth{RedirectURL: redirectURL}, nil
|
|
}
|
|
|
|
func Form(url string, fields map[string]string) (*FormAuth, error) {
|
|
return &FormAuth{
|
|
URL: url,
|
|
Fields: fields,
|
|
}, nil
|
|
}
|