mirror of
https://github.com/zitadel/zitadel.git
synced 2025-12-26 19:56:32 +00:00
22ef817d5c
Improves compatibility of eventstore and related database components with the new relational table package. ## Which problems are solved 1. **Incompatible Database Interfaces**: The existing eventstore was tightly coupled to the database package, which is incompatible with the new, more abstract relational table package in v3. This prevented the new command-side logic from pushing events to the legacy eventstore. 2. **Missing Health Checks**: The database interfaces in the new package lacked a Ping method, making it impossible to perform health checks on database connections. 3. **Event Publishing Logic**: The command handling logic in domain needed a way to collect and push events to the legacy eventstore after a command was successfully executed. ## How the problems are solved 1. **`LegacyEventstore` Interface**: * A new `LegacyEventstore` interface is introduced in the new `database/eventstore` . This interface exposes a `PushWithNewClient` method that accepts the new `database.QueryExecutor` interface, decoupling the v3 domain from the legacy implementation. * The `internal/eventstore.Eventstore` now implements this interface. A wrapper, PushWithClient, is added to convert the old database client types (`*sql.DB`, `*sql.Tx`) into the new `QueryExecutor` types before calling `PushWithNewClient`. 2. **Database Interface Updates**: * The `database.Pool` and `database.Client` interfaces in `storage/eventstore` have been updated to include a Ping method, allowing for consistent health checks across different database dialects. * The `postgres` and `sql` dialect implementations have been updated to support this new method. 3. **Command and Invoker Refactoring**: * The `Commander` interface in domain now includes an `Events() []legacy_es.Command` method. This allows commands to declare which events they will generate. * The `eventCollector` in the invoker logic has been redesigned. It now ensures a database transaction is started before executing a command. After successful execution, it calls the `Events()` method on the command to collect the generated events and appends them to a list. * The `eventStoreInvoker` then pushes all collected events to the legacy eventstore using the new `LegacyEventstore` interface, ensuring that events are only pushed if the entire command (and any sub-commands) executes successfully within the transaction. 4. **Testing**: * New unit tests have been added for the invoker to verify that events are correctly collected from single commands, batched commands, and nested commands. These changes create a clean bridge between the new v3 command-side logic and the existing v1 eventstore, allowing for incremental adoption of the new architecture while maintaining full functionality. ## Additional Information closes https://github.com/zitadel/zitadel/issues/10442
81 lines
2.3 KiB
YAML
81 lines
2.3 KiB
YAML
name: Build core
|
|
|
|
on:
|
|
workflow_call:
|
|
inputs:
|
|
buf_version:
|
|
required: true
|
|
type: string
|
|
node_version:
|
|
required: true
|
|
type: string
|
|
outputs:
|
|
cache_key:
|
|
value: ${{ jobs.build.outputs.cache_key }}
|
|
cache_path:
|
|
value: ${{ jobs.build.outputs.cache_path }}
|
|
|
|
env:
|
|
cache_path: |
|
|
internal/statik/statik.go
|
|
internal/notification/statik/statik.go
|
|
internal/api/ui/login/static/resources/themes/zitadel/css/zitadel.css*
|
|
internal/api/ui/login/statik/statik.go
|
|
internal/api/assets/authz.go
|
|
internal/api/assets/router.go
|
|
openapi/v2
|
|
pkg/grpc/**/*.pb.*
|
|
pkg/grpc/**/*.connect.go
|
|
|
|
jobs:
|
|
build:
|
|
runs-on:
|
|
group: zitadel-public
|
|
outputs:
|
|
cache_key: ${{ steps.cache.outputs.cache-primary-key }}
|
|
cache_path: ${{ env.cache_path }}
|
|
steps:
|
|
-
|
|
uses: actions/checkout@v4
|
|
-
|
|
uses: actions/cache/restore@v4
|
|
timeout-minutes: 1
|
|
continue-on-error: true
|
|
id: cache
|
|
with:
|
|
key: core-${{ hashFiles( 'go.*', 'openapi', 'cmd', 'pkg/grpc/**/*.go', 'proto', 'internal', 'backend') }}
|
|
restore-keys: |
|
|
core-
|
|
path: ${{ env.cache_path }}
|
|
-
|
|
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
|
|
uses: bufbuild/buf-setup-action@v1
|
|
with:
|
|
github_token: ${{ github.token }}
|
|
version: ${{ inputs.buf_version }}
|
|
|
|
-
|
|
# node to install sass
|
|
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: ${{ inputs.node_version }}
|
|
-
|
|
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
|
|
run: npm install -g sass
|
|
|
|
-
|
|
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
|
|
uses: actions/setup-go@v5
|
|
with:
|
|
go-version-file: 'go.mod'
|
|
-
|
|
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
|
|
run: make core_build
|
|
-
|
|
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
|
|
uses: actions/cache/save@v4
|
|
with:
|
|
key: ${{ steps.cache.outputs.cache-primary-key }}
|
|
path: ${{ env.cache_path }}
|
|
|