mirror of
https://github.com/zitadel/zitadel.git
synced 2024-12-17 05:18:04 +00:00
5bd9badbcf
* fix: filter granted memberships correctly * fix: only show changes of granted project * Apply suggestions from code review Co-authored-by: Fabi <38692350+hifabienne@users.noreply.github.com> * Update internal/query/user_membership.go Co-authored-by: Fabi <38692350+hifabienne@users.noreply.github.com> Co-authored-by: Fabi <38692350+hifabienne@users.noreply.github.com>
448 lines
10 KiB
Go
448 lines
10 KiB
Go
package query
|
|
|
|
import (
|
|
"database/sql"
|
|
"database/sql/driver"
|
|
"errors"
|
|
"fmt"
|
|
"regexp"
|
|
"testing"
|
|
|
|
"github.com/lib/pq"
|
|
)
|
|
|
|
var (
|
|
membershipsStmt = regexp.QuoteMeta(
|
|
"SELECT memberships.user_id" +
|
|
", memberships.roles" +
|
|
", memberships.creation_date" +
|
|
", memberships.change_date" +
|
|
", memberships.sequence" +
|
|
", memberships.resource_owner" +
|
|
", memberships.org_id" +
|
|
", memberships.id" +
|
|
", memberships.project_id" +
|
|
", memberships.grant_id" +
|
|
", projections.project_grants.granted_org_id" +
|
|
", projections.projects.name" +
|
|
", projections.orgs.name" +
|
|
", COUNT(*) OVER ()" +
|
|
" FROM (" +
|
|
"SELECT members.user_id" +
|
|
", members.roles" +
|
|
", members.creation_date" +
|
|
", members.change_date" +
|
|
", members.sequence" +
|
|
", members.resource_owner" +
|
|
", members.instance_id" +
|
|
", members.org_id" +
|
|
", NULL::STRING AS id" +
|
|
", NULL::STRING AS project_id" +
|
|
", NULL::STRING AS grant_id" +
|
|
" FROM projections.org_members as members" +
|
|
" UNION ALL " +
|
|
"SELECT members.user_id" +
|
|
", members.roles" +
|
|
", members.creation_date" +
|
|
", members.change_date" +
|
|
", members.sequence" +
|
|
", members.resource_owner" +
|
|
", members.instance_id" +
|
|
", NULL::STRING AS org_id" +
|
|
", members.id" +
|
|
", NULL::STRING AS project_id" +
|
|
", NULL::STRING AS grant_id" +
|
|
" FROM projections.instance_members as members" +
|
|
" UNION ALL " +
|
|
"SELECT members.user_id" +
|
|
", members.roles" +
|
|
", members.creation_date" +
|
|
", members.change_date" +
|
|
", members.sequence" +
|
|
", members.resource_owner" +
|
|
", members.instance_id" +
|
|
", NULL::STRING AS org_id" +
|
|
", NULL::STRING AS id" +
|
|
", members.project_id" +
|
|
", NULL::STRING AS grant_id" +
|
|
" FROM projections.project_members as members" +
|
|
" UNION ALL " +
|
|
"SELECT members.user_id" +
|
|
", members.roles" +
|
|
", members.creation_date" +
|
|
", members.change_date" +
|
|
", members.sequence" +
|
|
", members.resource_owner" +
|
|
", members.instance_id" +
|
|
", NULL::STRING AS org_id" +
|
|
", NULL::STRING AS id" +
|
|
", members.project_id" +
|
|
", members.grant_id" +
|
|
" FROM projections.project_grant_members as members" +
|
|
") AS memberships" +
|
|
" LEFT JOIN projections.projects ON memberships.project_id = projections.projects.id" +
|
|
" LEFT JOIN projections.orgs ON memberships.org_id = projections.orgs.id" +
|
|
" LEFT JOIN projections.project_grants ON memberships.grant_id = projections.project_grants.grant_id")
|
|
membershipCols = []string{
|
|
"user_id",
|
|
"roles",
|
|
"creation_date",
|
|
"change_date",
|
|
"sequence",
|
|
"resource_owner",
|
|
"org_id",
|
|
"instance_id",
|
|
"project_id",
|
|
"grant_id",
|
|
"granted_org_id",
|
|
"name", //project name
|
|
"name", //org name
|
|
"count",
|
|
}
|
|
)
|
|
|
|
func Test_MembershipPrepares(t *testing.T) {
|
|
type want struct {
|
|
sqlExpectations sqlExpectation
|
|
err checkErr
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
prepare interface{}
|
|
want want
|
|
object interface{}
|
|
}{
|
|
{
|
|
name: "prepareMembershipsQuery no result",
|
|
prepare: prepareMembershipsQuery,
|
|
want: want{
|
|
sqlExpectations: mockQueries(
|
|
membershipsStmt,
|
|
nil,
|
|
nil,
|
|
),
|
|
},
|
|
object: &Memberships{Memberships: []*Membership{}},
|
|
},
|
|
{
|
|
name: "prepareMembershipsQuery one org member",
|
|
prepare: prepareMembershipsQuery,
|
|
want: want{
|
|
sqlExpectations: mockQueries(
|
|
membershipsStmt,
|
|
membershipCols,
|
|
[][]driver.Value{
|
|
{
|
|
"user-id",
|
|
pq.StringArray{"role1", "role2"},
|
|
testNow,
|
|
testNow,
|
|
uint64(20211202),
|
|
"ro",
|
|
"org-id",
|
|
nil,
|
|
nil,
|
|
nil,
|
|
nil,
|
|
nil,
|
|
"org-name",
|
|
},
|
|
},
|
|
),
|
|
},
|
|
object: &Memberships{
|
|
SearchResponse: SearchResponse{
|
|
Count: 1,
|
|
},
|
|
Memberships: []*Membership{
|
|
{
|
|
UserID: "user-id",
|
|
Roles: []string{"role1", "role2"},
|
|
CreationDate: testNow,
|
|
ChangeDate: testNow,
|
|
Sequence: 20211202,
|
|
ResourceOwner: "ro",
|
|
Org: &OrgMembership{OrgID: "org-id", Name: "org-name"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "prepareMembershipsQuery one instance member",
|
|
prepare: prepareMembershipsQuery,
|
|
want: want{
|
|
sqlExpectations: mockQueries(
|
|
membershipsStmt,
|
|
membershipCols,
|
|
[][]driver.Value{
|
|
{
|
|
"user-id",
|
|
pq.StringArray{"role1", "role2"},
|
|
testNow,
|
|
testNow,
|
|
uint64(20211202),
|
|
"ro",
|
|
nil,
|
|
"iam-id",
|
|
nil,
|
|
nil,
|
|
nil,
|
|
nil,
|
|
nil,
|
|
},
|
|
},
|
|
),
|
|
},
|
|
object: &Memberships{
|
|
SearchResponse: SearchResponse{
|
|
Count: 1,
|
|
},
|
|
Memberships: []*Membership{
|
|
{
|
|
UserID: "user-id",
|
|
Roles: []string{"role1", "role2"},
|
|
CreationDate: testNow,
|
|
ChangeDate: testNow,
|
|
Sequence: 20211202,
|
|
ResourceOwner: "ro",
|
|
IAM: &IAMMembership{IAMID: "iam-id", Name: "iam-id"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "prepareMembershipsQuery one project member",
|
|
prepare: prepareMembershipsQuery,
|
|
want: want{
|
|
sqlExpectations: mockQueries(
|
|
membershipsStmt,
|
|
membershipCols,
|
|
[][]driver.Value{
|
|
{
|
|
"user-id",
|
|
pq.StringArray{"role1", "role2"},
|
|
testNow,
|
|
testNow,
|
|
uint64(20211202),
|
|
"ro",
|
|
nil,
|
|
nil,
|
|
"project-id",
|
|
nil,
|
|
nil,
|
|
"project-name",
|
|
nil,
|
|
},
|
|
},
|
|
),
|
|
},
|
|
object: &Memberships{
|
|
SearchResponse: SearchResponse{
|
|
Count: 1,
|
|
},
|
|
Memberships: []*Membership{
|
|
{
|
|
UserID: "user-id",
|
|
Roles: []string{"role1", "role2"},
|
|
CreationDate: testNow,
|
|
ChangeDate: testNow,
|
|
Sequence: 20211202,
|
|
ResourceOwner: "ro",
|
|
Project: &ProjectMembership{ProjectID: "project-id", Name: "project-name"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "prepareMembershipsQuery one project grant member",
|
|
prepare: prepareMembershipsQuery,
|
|
want: want{
|
|
sqlExpectations: mockQueries(
|
|
membershipsStmt,
|
|
membershipCols,
|
|
[][]driver.Value{
|
|
{
|
|
"user-id",
|
|
pq.StringArray{"role1", "role2"},
|
|
testNow,
|
|
testNow,
|
|
uint64(20211202),
|
|
"ro",
|
|
nil,
|
|
nil,
|
|
"project-id",
|
|
"grant-id",
|
|
"granted-org-id",
|
|
"project-name",
|
|
nil,
|
|
},
|
|
},
|
|
),
|
|
},
|
|
object: &Memberships{
|
|
SearchResponse: SearchResponse{
|
|
Count: 1,
|
|
},
|
|
Memberships: []*Membership{
|
|
{
|
|
UserID: "user-id",
|
|
Roles: []string{"role1", "role2"},
|
|
CreationDate: testNow,
|
|
ChangeDate: testNow,
|
|
Sequence: 20211202,
|
|
ResourceOwner: "ro",
|
|
ProjectGrant: &ProjectGrantMembership{
|
|
GrantID: "grant-id",
|
|
ProjectID: "project-id",
|
|
ProjectName: "project-name",
|
|
GrantedOrgID: "granted-org-id",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "prepareMembershipsQuery one for each member type",
|
|
prepare: prepareMembershipsQuery,
|
|
want: want{
|
|
sqlExpectations: mockQueries(
|
|
membershipsStmt,
|
|
membershipCols,
|
|
[][]driver.Value{
|
|
{
|
|
"user-id",
|
|
pq.StringArray{"role1", "role2"},
|
|
testNow,
|
|
testNow,
|
|
uint64(20211202),
|
|
"ro",
|
|
"org-id",
|
|
nil,
|
|
nil,
|
|
nil,
|
|
nil,
|
|
nil,
|
|
"org-name",
|
|
},
|
|
{
|
|
"user-id",
|
|
pq.StringArray{"role1", "role2"},
|
|
testNow,
|
|
testNow,
|
|
uint64(20211202),
|
|
"ro",
|
|
nil,
|
|
"iam-id",
|
|
nil,
|
|
nil,
|
|
nil,
|
|
nil,
|
|
nil,
|
|
},
|
|
{
|
|
"user-id",
|
|
pq.StringArray{"role1", "role2"},
|
|
testNow,
|
|
testNow,
|
|
uint64(20211202),
|
|
"ro",
|
|
nil,
|
|
nil,
|
|
"project-id",
|
|
nil,
|
|
nil,
|
|
"project-name",
|
|
nil,
|
|
},
|
|
{
|
|
"user-id",
|
|
pq.StringArray{"role1", "role2"},
|
|
testNow,
|
|
testNow,
|
|
uint64(20211202),
|
|
"ro",
|
|
nil,
|
|
nil,
|
|
"project-id",
|
|
"grant-id",
|
|
"granted-org-id",
|
|
"project-name",
|
|
nil,
|
|
},
|
|
},
|
|
),
|
|
},
|
|
object: &Memberships{
|
|
SearchResponse: SearchResponse{
|
|
Count: 4,
|
|
},
|
|
Memberships: []*Membership{
|
|
{
|
|
UserID: "user-id",
|
|
Roles: []string{"role1", "role2"},
|
|
CreationDate: testNow,
|
|
ChangeDate: testNow,
|
|
Sequence: 20211202,
|
|
ResourceOwner: "ro",
|
|
Org: &OrgMembership{OrgID: "org-id", Name: "org-name"},
|
|
},
|
|
{
|
|
UserID: "user-id",
|
|
Roles: []string{"role1", "role2"},
|
|
CreationDate: testNow,
|
|
ChangeDate: testNow,
|
|
Sequence: 20211202,
|
|
ResourceOwner: "ro",
|
|
IAM: &IAMMembership{IAMID: "iam-id", Name: "iam-id"},
|
|
},
|
|
{
|
|
UserID: "user-id",
|
|
Roles: []string{"role1", "role2"},
|
|
CreationDate: testNow,
|
|
ChangeDate: testNow,
|
|
Sequence: 20211202,
|
|
ResourceOwner: "ro",
|
|
Project: &ProjectMembership{ProjectID: "project-id", Name: "project-name"},
|
|
},
|
|
{
|
|
UserID: "user-id",
|
|
Roles: []string{"role1", "role2"},
|
|
CreationDate: testNow,
|
|
ChangeDate: testNow,
|
|
Sequence: 20211202,
|
|
ResourceOwner: "ro",
|
|
ProjectGrant: &ProjectGrantMembership{
|
|
ProjectID: "project-id",
|
|
GrantID: "grant-id",
|
|
ProjectName: "project-name",
|
|
GrantedOrgID: "granted-org-id",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "prepareMembershipsQuery sql err",
|
|
prepare: prepareMembershipsQuery,
|
|
want: want{
|
|
sqlExpectations: mockQueryErr(
|
|
membershipsStmt,
|
|
sql.ErrConnDone,
|
|
),
|
|
err: func(err error) (error, bool) {
|
|
if !errors.Is(err, sql.ErrConnDone) {
|
|
return fmt.Errorf("err should be sql.ErrConnDone got: %w", err), false
|
|
}
|
|
return nil, true
|
|
},
|
|
},
|
|
object: nil,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
assertPrepare(t, tt.prepare, tt.object, tt.want.sqlExpectations, tt.want.err)
|
|
})
|
|
}
|
|
}
|