mirror of
https://github.com/zitadel/zitadel.git
synced 2024-12-14 03:54:21 +00:00
63d733b3a2
# Which Problems Are Solved When executing many concurrent authentication requests on a single machine user, there were performance issues. As the same aggregate is being searched and written to concurrently, we traced it down to a locking issue on the used index. We already optimized the token endpoint by creating a separate OIDC aggregate. At the time we decided to push a single event to the user aggregate, for the user audit log. See [technical advisory 10010](https://zitadel.com/docs/support/advisory/a10010) for more details. However, a recent security fix introduced an additional search query on the user aggregate, causing the locking issue we found. # How the Problems Are Solved Add a feature flag which disables pushing of the `user.token.v2.added`. The event has no importance and was only added for informational purposes on the user objects. The `oidc_session.access_token.added` is the actual payload event and is pushed on the OIDC session aggregate and can still be used for audit trail. # Additional Changes - Fix an event mapper type for `SystemOIDCSingleV1SessionTerminationEventType` # Additional Context - Reported by support request - https://github.com/zitadel/zitadel/pull/7822 changed the token aggregate - https://github.com/zitadel/zitadel/pull/8631 introduced user state check Load test trace graph with `user.token.v2.added` **enabled**. Query times are steadily increasing: ![image](https://github.com/user-attachments/assets/4aa25055-8721-4e93-b695-625560979909) Load test trace graph with `user.token.v2.added` **disabled**. Query times constant: ![image](https://github.com/user-attachments/assets/a7657f6c-0c55-401b-8291-453da5d5caf9) --------- Co-authored-by: Livio Spring <livio.a@gmail.com>
119 lines
3.9 KiB
Go
119 lines
3.9 KiB
Go
// Code generated by "enumer -type Key -transform snake -trimprefix Key"; DO NOT EDIT.
|
|
|
|
package feature
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
)
|
|
|
|
const _KeyName = "unspecifiedlogin_default_orgtrigger_introspection_projectionslegacy_introspectionuser_schematoken_exchangeactionsimproved_performanceweb_keydebug_oidc_parent_erroroidc_single_v1_session_terminationdisable_user_token_event"
|
|
|
|
var _KeyIndex = [...]uint8{0, 11, 28, 61, 81, 92, 106, 113, 133, 140, 163, 197, 221}
|
|
|
|
const _KeyLowerName = "unspecifiedlogin_default_orgtrigger_introspection_projectionslegacy_introspectionuser_schematoken_exchangeactionsimproved_performanceweb_keydebug_oidc_parent_erroroidc_single_v1_session_terminationdisable_user_token_event"
|
|
|
|
func (i Key) String() string {
|
|
if i < 0 || i >= Key(len(_KeyIndex)-1) {
|
|
return fmt.Sprintf("Key(%d)", i)
|
|
}
|
|
return _KeyName[_KeyIndex[i]:_KeyIndex[i+1]]
|
|
}
|
|
|
|
// An "invalid array index" compiler error signifies that the constant values have changed.
|
|
// Re-run the stringer command to generate them again.
|
|
func _KeyNoOp() {
|
|
var x [1]struct{}
|
|
_ = x[KeyUnspecified-(0)]
|
|
_ = x[KeyLoginDefaultOrg-(1)]
|
|
_ = x[KeyTriggerIntrospectionProjections-(2)]
|
|
_ = x[KeyLegacyIntrospection-(3)]
|
|
_ = x[KeyUserSchema-(4)]
|
|
_ = x[KeyTokenExchange-(5)]
|
|
_ = x[KeyActions-(6)]
|
|
_ = x[KeyImprovedPerformance-(7)]
|
|
_ = x[KeyWebKey-(8)]
|
|
_ = x[KeyDebugOIDCParentError-(9)]
|
|
_ = x[KeyOIDCSingleV1SessionTermination-(10)]
|
|
_ = x[KeyDisableUserTokenEvent-(11)]
|
|
}
|
|
|
|
var _KeyValues = []Key{KeyUnspecified, KeyLoginDefaultOrg, KeyTriggerIntrospectionProjections, KeyLegacyIntrospection, KeyUserSchema, KeyTokenExchange, KeyActions, KeyImprovedPerformance, KeyWebKey, KeyDebugOIDCParentError, KeyOIDCSingleV1SessionTermination, KeyDisableUserTokenEvent}
|
|
|
|
var _KeyNameToValueMap = map[string]Key{
|
|
_KeyName[0:11]: KeyUnspecified,
|
|
_KeyLowerName[0:11]: KeyUnspecified,
|
|
_KeyName[11:28]: KeyLoginDefaultOrg,
|
|
_KeyLowerName[11:28]: KeyLoginDefaultOrg,
|
|
_KeyName[28:61]: KeyTriggerIntrospectionProjections,
|
|
_KeyLowerName[28:61]: KeyTriggerIntrospectionProjections,
|
|
_KeyName[61:81]: KeyLegacyIntrospection,
|
|
_KeyLowerName[61:81]: KeyLegacyIntrospection,
|
|
_KeyName[81:92]: KeyUserSchema,
|
|
_KeyLowerName[81:92]: KeyUserSchema,
|
|
_KeyName[92:106]: KeyTokenExchange,
|
|
_KeyLowerName[92:106]: KeyTokenExchange,
|
|
_KeyName[106:113]: KeyActions,
|
|
_KeyLowerName[106:113]: KeyActions,
|
|
_KeyName[113:133]: KeyImprovedPerformance,
|
|
_KeyLowerName[113:133]: KeyImprovedPerformance,
|
|
_KeyName[133:140]: KeyWebKey,
|
|
_KeyLowerName[133:140]: KeyWebKey,
|
|
_KeyName[140:163]: KeyDebugOIDCParentError,
|
|
_KeyLowerName[140:163]: KeyDebugOIDCParentError,
|
|
_KeyName[163:197]: KeyOIDCSingleV1SessionTermination,
|
|
_KeyLowerName[163:197]: KeyOIDCSingleV1SessionTermination,
|
|
_KeyName[197:221]: KeyDisableUserTokenEvent,
|
|
_KeyLowerName[197:221]: KeyDisableUserTokenEvent,
|
|
}
|
|
|
|
var _KeyNames = []string{
|
|
_KeyName[0:11],
|
|
_KeyName[11:28],
|
|
_KeyName[28:61],
|
|
_KeyName[61:81],
|
|
_KeyName[81:92],
|
|
_KeyName[92:106],
|
|
_KeyName[106:113],
|
|
_KeyName[113:133],
|
|
_KeyName[133:140],
|
|
_KeyName[140:163],
|
|
_KeyName[163:197],
|
|
_KeyName[197:221],
|
|
}
|
|
|
|
// KeyString retrieves an enum value from the enum constants string name.
|
|
// Throws an error if the param is not part of the enum.
|
|
func KeyString(s string) (Key, error) {
|
|
if val, ok := _KeyNameToValueMap[s]; ok {
|
|
return val, nil
|
|
}
|
|
|
|
if val, ok := _KeyNameToValueMap[strings.ToLower(s)]; ok {
|
|
return val, nil
|
|
}
|
|
return 0, fmt.Errorf("%s does not belong to Key values", s)
|
|
}
|
|
|
|
// KeyValues returns all values of the enum
|
|
func KeyValues() []Key {
|
|
return _KeyValues
|
|
}
|
|
|
|
// KeyStrings returns a slice of all String values of the enum
|
|
func KeyStrings() []string {
|
|
strs := make([]string, len(_KeyNames))
|
|
copy(strs, _KeyNames)
|
|
return strs
|
|
}
|
|
|
|
// IsAKey returns "true" if the value is listed in the enum definition. "false" otherwise
|
|
func (i Key) IsAKey() bool {
|
|
for _, v := range _KeyValues {
|
|
if i == v {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|