mirror of
https://github.com/zitadel/zitadel.git
synced 2025-12-23 19:48:53 +00:00
Improves compatibility of eventstore and related database components with the new relational table package. ## Which problems are solved 1. **Incompatible Database Interfaces**: The existing eventstore was tightly coupled to the database package, which is incompatible with the new, more abstract relational table package in v3. This prevented the new command-side logic from pushing events to the legacy eventstore. 2. **Missing Health Checks**: The database interfaces in the new package lacked a Ping method, making it impossible to perform health checks on database connections. 3. **Event Publishing Logic**: The command handling logic in domain needed a way to collect and push events to the legacy eventstore after a command was successfully executed. ## How the problems are solved 1. **`LegacyEventstore` Interface**: * A new `LegacyEventstore` interface is introduced in the new `database/eventstore` . This interface exposes a `PushWithNewClient` method that accepts the new `database.QueryExecutor` interface, decoupling the v3 domain from the legacy implementation. * The `internal/eventstore.Eventstore` now implements this interface. A wrapper, PushWithClient, is added to convert the old database client types (`*sql.DB`, `*sql.Tx`) into the new `QueryExecutor` types before calling `PushWithNewClient`. 2. **Database Interface Updates**: * The `database.Pool` and `database.Client` interfaces in `storage/eventstore` have been updated to include a Ping method, allowing for consistent health checks across different database dialects. * The `postgres` and `sql` dialect implementations have been updated to support this new method. 3. **Command and Invoker Refactoring**: * The `Commander` interface in domain now includes an `Events() []legacy_es.Command` method. This allows commands to declare which events they will generate. * The `eventCollector` in the invoker logic has been redesigned. It now ensures a database transaction is started before executing a command. After successful execution, it calls the `Events()` method on the command to collect the generated events and appends them to a list. * The `eventStoreInvoker` then pushes all collected events to the legacy eventstore using the new `LegacyEventstore` interface, ensuring that events are only pushed if the entire command (and any sub-commands) executes successfully within the transaction. 4. **Testing**: * New unit tests have been added for the invoker to verify that events are correctly collected from single commands, batched commands, and nested commands. These changes create a clean bridge between the new v3 command-side logic and the existing v1 eventstore, allowing for incremental adoption of the new architecture while maintaining full functionality. ## Additional Information closes https://github.com/zitadel/zitadel/issues/10442
235 lines
5.9 KiB
Go
235 lines
5.9 KiB
Go
package database
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
)
|
|
|
|
var ErrNoChanges = errors.New("update must contain a change")
|
|
|
|
// NoRowFoundError is returned when QueryRow does not find any row.
|
|
// It wraps the dialect specific original error to provide more context.
|
|
type NoRowFoundError struct {
|
|
original error
|
|
}
|
|
|
|
func NewNoRowFoundError(original error) error {
|
|
return &NoRowFoundError{
|
|
original: original,
|
|
}
|
|
}
|
|
|
|
func (e *NoRowFoundError) Error() string {
|
|
return "no row found"
|
|
}
|
|
|
|
func (e *NoRowFoundError) Is(target error) bool {
|
|
_, ok := target.(*NoRowFoundError)
|
|
return ok
|
|
}
|
|
|
|
func (e *NoRowFoundError) Unwrap() error {
|
|
return e.original
|
|
}
|
|
|
|
// MultipleRowsFoundError is returned when QueryRow finds multiple rows.
|
|
// It wraps the dialect specific original error to provide more context.
|
|
type MultipleRowsFoundError struct {
|
|
original error
|
|
count int
|
|
}
|
|
|
|
func NewMultipleRowsFoundError(original error, count int) error {
|
|
return &MultipleRowsFoundError{
|
|
original: original,
|
|
count: count,
|
|
}
|
|
}
|
|
|
|
func (e *MultipleRowsFoundError) Error() string {
|
|
return fmt.Sprintf("multiple rows found: %d", e.count)
|
|
}
|
|
|
|
func (e *MultipleRowsFoundError) Is(target error) bool {
|
|
_, ok := target.(*MultipleRowsFoundError)
|
|
return ok
|
|
}
|
|
|
|
func (e *MultipleRowsFoundError) Unwrap() error {
|
|
return e.original
|
|
}
|
|
|
|
type IntegrityType string
|
|
|
|
const (
|
|
IntegrityTypeCheck IntegrityType = "check"
|
|
IntegrityTypeUnique IntegrityType = "unique"
|
|
IntegrityTypeForeign IntegrityType = "foreign"
|
|
IntegrityTypeNotNull IntegrityType = "not null"
|
|
)
|
|
|
|
// IntegrityViolationError represents a generic integrity violation error.
|
|
// It wraps the dialect specific original error to provide more context.
|
|
type IntegrityViolationError struct {
|
|
integrityType IntegrityType
|
|
table string
|
|
constraint string
|
|
original error
|
|
}
|
|
|
|
func NewIntegrityViolationError(typ IntegrityType, table, constraint string, original error) error {
|
|
return &IntegrityViolationError{
|
|
integrityType: typ,
|
|
table: table,
|
|
constraint: constraint,
|
|
original: original,
|
|
}
|
|
}
|
|
|
|
func (e *IntegrityViolationError) Error() string {
|
|
return fmt.Sprintf("integrity violation of type %q on %q (constraint: %q): %v", e.integrityType, e.table, e.constraint, e.original)
|
|
}
|
|
|
|
func (e *IntegrityViolationError) Is(target error) bool {
|
|
_, ok := target.(*IntegrityViolationError)
|
|
return ok
|
|
}
|
|
|
|
func (e *IntegrityViolationError) Unwrap() error {
|
|
return e.original
|
|
}
|
|
|
|
// CheckError is returned when a check constraint fails.
|
|
// It wraps the [IntegrityViolationError] to provide more context.
|
|
// It is used to indicate that a check constraint was violated during an insert or update operation.
|
|
type CheckError struct {
|
|
IntegrityViolationError
|
|
}
|
|
|
|
func NewCheckError(table, constraint string, original error) error {
|
|
return &CheckError{
|
|
IntegrityViolationError: IntegrityViolationError{
|
|
integrityType: IntegrityTypeCheck,
|
|
table: table,
|
|
constraint: constraint,
|
|
original: original,
|
|
},
|
|
}
|
|
}
|
|
|
|
func (e *CheckError) Is(target error) bool {
|
|
_, ok := target.(*CheckError)
|
|
return ok
|
|
}
|
|
|
|
func (e *CheckError) Unwrap() error {
|
|
return &e.IntegrityViolationError
|
|
}
|
|
|
|
// UniqueError is returned when a unique constraint fails.
|
|
// It wraps the [IntegrityViolationError] to provide more context.
|
|
// It is used to indicate that a unique constraint was violated during an insert or update operation.
|
|
type UniqueError struct {
|
|
IntegrityViolationError
|
|
}
|
|
|
|
func NewUniqueError(table, constraint string, original error) error {
|
|
return &UniqueError{
|
|
IntegrityViolationError: IntegrityViolationError{
|
|
integrityType: IntegrityTypeUnique,
|
|
table: table,
|
|
constraint: constraint,
|
|
original: original,
|
|
},
|
|
}
|
|
}
|
|
|
|
func (e *UniqueError) Is(target error) bool {
|
|
_, ok := target.(*UniqueError)
|
|
return ok
|
|
}
|
|
|
|
func (e *UniqueError) Unwrap() error {
|
|
return &e.IntegrityViolationError
|
|
}
|
|
|
|
// ForeignKeyError is returned when a foreign key constraint fails.
|
|
// It wraps the [IntegrityViolationError] to provide more context.
|
|
// It is used to indicate that a foreign key constraint was violated during an insert or update operation
|
|
type ForeignKeyError struct {
|
|
IntegrityViolationError
|
|
}
|
|
|
|
func NewForeignKeyError(table, constraint string, original error) error {
|
|
return &ForeignKeyError{
|
|
IntegrityViolationError: IntegrityViolationError{
|
|
integrityType: IntegrityTypeForeign,
|
|
table: table,
|
|
constraint: constraint,
|
|
original: original,
|
|
},
|
|
}
|
|
}
|
|
|
|
func (e *ForeignKeyError) Is(target error) bool {
|
|
_, ok := target.(*ForeignKeyError)
|
|
return ok
|
|
}
|
|
|
|
func (e *ForeignKeyError) Unwrap() error {
|
|
return &e.IntegrityViolationError
|
|
}
|
|
|
|
// NotNullError is returned when a not null constraint fails.
|
|
// It wraps the [IntegrityViolationError] to provide more context.
|
|
// It is used to indicate that a not null constraint was violated during an insert or update operation.
|
|
type NotNullError struct {
|
|
IntegrityViolationError
|
|
}
|
|
|
|
func NewNotNullError(table, constraint string, original error) error {
|
|
return &NotNullError{
|
|
IntegrityViolationError: IntegrityViolationError{
|
|
integrityType: IntegrityTypeNotNull,
|
|
table: table,
|
|
constraint: constraint,
|
|
original: original,
|
|
},
|
|
}
|
|
}
|
|
|
|
func (e *NotNullError) Is(target error) bool {
|
|
_, ok := target.(*NotNullError)
|
|
return ok
|
|
}
|
|
|
|
func (e *NotNullError) Unwrap() error {
|
|
return &e.IntegrityViolationError
|
|
}
|
|
|
|
// UnknownError is returned when an unknown error occurs.
|
|
// It wraps the dialect specific original error to provide more context.
|
|
// It is used to indicate that an error occurred that does not fit into any of the other categories.
|
|
type UnknownError struct {
|
|
original error
|
|
}
|
|
|
|
func NewUnknownError(original error) error {
|
|
return &UnknownError{
|
|
original: original,
|
|
}
|
|
}
|
|
|
|
func (e *UnknownError) Error() string {
|
|
return fmt.Sprintf("unknown database error: %v", e.original)
|
|
}
|
|
|
|
func (e *UnknownError) Is(target error) bool {
|
|
_, ok := target.(*UnknownError)
|
|
return ok
|
|
}
|
|
|
|
func (e *UnknownError) Unwrap() error {
|
|
return e.original
|
|
}
|