mirror of
https://github.com/zitadel/zitadel.git
synced 2024-12-12 19:14:23 +00:00
26d1563643
* feat(api): feature API proto definitions * update proto based on discussion with @livio-a * cleanup old feature flag stuff * authz instance queries * align defaults * projection definitions * define commands and event reducers * implement system and instance setter APIs * api getter implementation * unit test repository package * command unit tests * unit test Get queries * grpc converter unit tests * migrate the V1 features * migrate oidc to dynamic features * projection unit test * fix instance by host * fix instance by id data type in sql * fix linting errors * add system projection test * fix behavior inversion * resolve proto file comments * rename SystemDefaultLoginInstanceEventType to SystemLoginDefaultOrgEventType so it's consistent with the instance level event * use write models and conditional set events * system features integration tests * instance features integration tests * error on empty request * documentation entry * typo in feature.proto * fix start unit tests * solve linting error on key case switch * remove system defaults after discussion with @eliobischof * fix system feature projection * resolve comments in defaults.yaml --------- Co-authored-by: Livio Spring <livio.a@gmail.com>
231 lines
6.1 KiB
Go
231 lines
6.1 KiB
Go
package query
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/zitadel/zitadel/internal/api/authz"
|
|
"github.com/zitadel/zitadel/internal/domain"
|
|
"github.com/zitadel/zitadel/internal/eventstore"
|
|
"github.com/zitadel/zitadel/internal/feature"
|
|
"github.com/zitadel/zitadel/internal/repository/feature/feature_v2"
|
|
)
|
|
|
|
func TestQueries_GetInstanceFeatures(t *testing.T) {
|
|
ctx := authz.WithInstanceID(context.Background(), "instance1")
|
|
aggregate := feature_v2.NewAggregate("instance1", "instance1")
|
|
|
|
type args struct {
|
|
cascade bool
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
eventstore func(*testing.T) *eventstore.Eventstore
|
|
args args
|
|
want *InstanceFeatures
|
|
wantErr error
|
|
}{
|
|
{
|
|
name: "filter error",
|
|
args: args{false},
|
|
eventstore: expectEventstore(
|
|
expectFilterError(io.ErrClosedPipe),
|
|
),
|
|
wantErr: io.ErrClosedPipe,
|
|
},
|
|
{
|
|
name: "system filter error cascaded",
|
|
args: args{true},
|
|
eventstore: expectEventstore(
|
|
expectFilterError(io.ErrClosedPipe),
|
|
),
|
|
wantErr: io.ErrClosedPipe,
|
|
},
|
|
{
|
|
name: "no features set, not cascaded",
|
|
eventstore: expectEventstore(
|
|
expectFilter(),
|
|
),
|
|
want: &InstanceFeatures{
|
|
Details: &domain.ObjectDetails{
|
|
ResourceOwner: "instance1",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "no features set, cascaded",
|
|
eventstore: expectEventstore(
|
|
expectFilter(),
|
|
expectFilter(),
|
|
),
|
|
args: args{true},
|
|
want: &InstanceFeatures{
|
|
Details: &domain.ObjectDetails{
|
|
ResourceOwner: "instance1",
|
|
},
|
|
LoginDefaultOrg: FeatureSource[bool]{
|
|
Level: feature.LevelUnspecified,
|
|
Value: false,
|
|
},
|
|
TriggerIntrospectionProjections: FeatureSource[bool]{
|
|
Level: feature.LevelUnspecified,
|
|
Value: false,
|
|
},
|
|
LegacyIntrospection: FeatureSource[bool]{
|
|
Level: feature.LevelUnspecified,
|
|
Value: false,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "all features set",
|
|
eventstore: expectEventstore(
|
|
expectFilter(eventFromEventPusher(feature_v2.NewSetEvent[bool](
|
|
context.Background(), aggregate,
|
|
feature_v2.SystemLoginDefaultOrgEventType, true,
|
|
))),
|
|
expectFilter(
|
|
eventFromEventPusher(feature_v2.NewSetEvent[bool](
|
|
ctx, aggregate,
|
|
feature_v2.InstanceLoginDefaultOrgEventType, false,
|
|
)),
|
|
eventFromEventPusher(feature_v2.NewSetEvent[bool](
|
|
ctx, aggregate,
|
|
feature_v2.InstanceTriggerIntrospectionProjectionsEventType, true,
|
|
)),
|
|
eventFromEventPusher(feature_v2.NewSetEvent[bool](
|
|
ctx, aggregate,
|
|
feature_v2.InstanceLegacyIntrospectionEventType, false,
|
|
)),
|
|
),
|
|
),
|
|
args: args{true},
|
|
want: &InstanceFeatures{
|
|
Details: &domain.ObjectDetails{
|
|
ResourceOwner: "instance1",
|
|
},
|
|
LoginDefaultOrg: FeatureSource[bool]{
|
|
Level: feature.LevelInstance,
|
|
Value: false,
|
|
},
|
|
TriggerIntrospectionProjections: FeatureSource[bool]{
|
|
Level: feature.LevelInstance,
|
|
Value: true,
|
|
},
|
|
LegacyIntrospection: FeatureSource[bool]{
|
|
Level: feature.LevelInstance,
|
|
Value: false,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "all features set, reset, set some feature, cascaded",
|
|
eventstore: expectEventstore(
|
|
expectFilter(eventFromEventPusher(feature_v2.NewSetEvent[bool](
|
|
context.Background(), aggregate,
|
|
feature_v2.SystemLoginDefaultOrgEventType, true,
|
|
))),
|
|
expectFilter(
|
|
eventFromEventPusher(feature_v2.NewSetEvent[bool](
|
|
ctx, aggregate,
|
|
feature_v2.InstanceLoginDefaultOrgEventType, false,
|
|
)),
|
|
eventFromEventPusher(feature_v2.NewSetEvent[bool](
|
|
ctx, aggregate,
|
|
feature_v2.InstanceTriggerIntrospectionProjectionsEventType, true,
|
|
)),
|
|
eventFromEventPusher(feature_v2.NewSetEvent[bool](
|
|
ctx, aggregate,
|
|
feature_v2.InstanceLegacyIntrospectionEventType, false,
|
|
)),
|
|
eventFromEventPusher(feature_v2.NewResetEvent(
|
|
ctx, aggregate,
|
|
feature_v2.InstanceResetEventType,
|
|
)),
|
|
eventFromEventPusher(feature_v2.NewSetEvent[bool](
|
|
ctx, aggregate,
|
|
feature_v2.InstanceTriggerIntrospectionProjectionsEventType, true,
|
|
)),
|
|
),
|
|
),
|
|
args: args{true},
|
|
want: &InstanceFeatures{
|
|
Details: &domain.ObjectDetails{
|
|
ResourceOwner: "instance1",
|
|
},
|
|
LoginDefaultOrg: FeatureSource[bool]{
|
|
Level: feature.LevelSystem,
|
|
Value: true,
|
|
},
|
|
TriggerIntrospectionProjections: FeatureSource[bool]{
|
|
Level: feature.LevelInstance,
|
|
Value: true,
|
|
},
|
|
LegacyIntrospection: FeatureSource[bool]{
|
|
Level: feature.LevelUnspecified,
|
|
Value: false,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "all features set, reset, set some feature, not cascaded",
|
|
eventstore: expectEventstore(
|
|
expectFilter(
|
|
eventFromEventPusher(feature_v2.NewSetEvent[bool](
|
|
ctx, aggregate,
|
|
feature_v2.InstanceLoginDefaultOrgEventType, false,
|
|
)),
|
|
eventFromEventPusher(feature_v2.NewSetEvent[bool](
|
|
ctx, aggregate,
|
|
feature_v2.InstanceTriggerIntrospectionProjectionsEventType, true,
|
|
)),
|
|
eventFromEventPusher(feature_v2.NewSetEvent[bool](
|
|
ctx, aggregate,
|
|
feature_v2.InstanceLegacyIntrospectionEventType, false,
|
|
)),
|
|
eventFromEventPusher(feature_v2.NewResetEvent(
|
|
ctx, aggregate,
|
|
feature_v2.InstanceResetEventType,
|
|
)),
|
|
eventFromEventPusher(feature_v2.NewSetEvent[bool](
|
|
ctx, aggregate,
|
|
feature_v2.InstanceTriggerIntrospectionProjectionsEventType, true,
|
|
)),
|
|
),
|
|
),
|
|
args: args{false},
|
|
want: &InstanceFeatures{
|
|
Details: &domain.ObjectDetails{
|
|
ResourceOwner: "instance1",
|
|
},
|
|
LoginDefaultOrg: FeatureSource[bool]{
|
|
Level: feature.LevelUnspecified,
|
|
Value: false,
|
|
},
|
|
TriggerIntrospectionProjections: FeatureSource[bool]{
|
|
Level: feature.LevelInstance,
|
|
Value: true,
|
|
},
|
|
LegacyIntrospection: FeatureSource[bool]{
|
|
Level: feature.LevelUnspecified,
|
|
Value: false,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
q := &Queries{
|
|
eventstore: tt.eventstore(t),
|
|
}
|
|
got, err := q.GetInstanceFeatures(ctx, tt.args.cascade)
|
|
require.ErrorIs(t, err, tt.wantErr)
|
|
assert.Equal(t, tt.want, got)
|
|
})
|
|
}
|
|
}
|