mirror of
https://github.com/zitadel/zitadel.git
synced 2024-12-15 12:27:59 +00:00
041af26917
# Which Problems Are Solved Currently ZITADEL supports RP-initiated logout for clients. Back-channel logout ensures that user sessions are terminated across all connected applications, even if the user closes their browser or loses connectivity providing a more secure alternative for certain use cases. # How the Problems Are Solved If the feature is activated and the client used for the authentication has a back_channel_logout_uri configured, a `session_logout.back_channel` will be registered. Once a user terminates their session, a (notification) handler will send a SET (form POST) to the registered uri containing a logout_token (with the user's ID and session ID). - A new feature "back_channel_logout" is added on system and instance level - A `back_channel_logout_uri` can be managed on OIDC applications - Added a `session_logout` aggregate to register and inform about sent `back_channel` notifications - Added a `SecurityEventToken` channel and `Form`message type in the notification handlers - Added `TriggeredAtOrigin` fields to `HumanSignedOut` and `TerminateSession` events for notification handling - Exported various functions and types in the `oidc` package to be able to reuse for token signing in the back_channel notifier. - To prevent that current existing session termination events will be handled, a setup step is added to set the `current_states` for the `projections.notifications_back_channel_logout` to the current position - [x] requires https://github.com/zitadel/oidc/pull/671 # Additional Changes - Updated all OTEL dependencies to v1.29.0, since OIDC already updated some of them to that version. - Single Session Termination feature is correctly checked (fixed feature mapping) # Additional Context - closes https://github.com/zitadel/zitadel/issues/8467 - TODO: - Documentation - UI to be done: https://github.com/zitadel/zitadel/issues/8469 --------- Co-authored-by: Hidde Wieringa <hidde@hiddewieringa.nl>
331 lines
9.5 KiB
Go
331 lines
9.5 KiB
Go
package feature
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/muhlemmer/gu"
|
|
"github.com/stretchr/testify/assert"
|
|
"google.golang.org/protobuf/types/known/timestamppb"
|
|
|
|
"github.com/zitadel/zitadel/internal/command"
|
|
"github.com/zitadel/zitadel/internal/domain"
|
|
"github.com/zitadel/zitadel/internal/feature"
|
|
"github.com/zitadel/zitadel/internal/query"
|
|
feature_pb "github.com/zitadel/zitadel/pkg/grpc/feature/v2"
|
|
"github.com/zitadel/zitadel/pkg/grpc/object/v2"
|
|
)
|
|
|
|
func Test_systemFeaturesToCommand(t *testing.T) {
|
|
arg := &feature_pb.SetSystemFeaturesRequest{
|
|
LoginDefaultOrg: gu.Ptr(true),
|
|
OidcTriggerIntrospectionProjections: gu.Ptr(false),
|
|
OidcLegacyIntrospection: nil,
|
|
UserSchema: gu.Ptr(true),
|
|
Actions: gu.Ptr(true),
|
|
OidcTokenExchange: gu.Ptr(true),
|
|
ImprovedPerformance: nil,
|
|
OidcSingleV1SessionTermination: gu.Ptr(true),
|
|
}
|
|
want := &command.SystemFeatures{
|
|
LoginDefaultOrg: gu.Ptr(true),
|
|
TriggerIntrospectionProjections: gu.Ptr(false),
|
|
LegacyIntrospection: nil,
|
|
UserSchema: gu.Ptr(true),
|
|
Actions: gu.Ptr(true),
|
|
TokenExchange: gu.Ptr(true),
|
|
ImprovedPerformance: nil,
|
|
OIDCSingleV1SessionTermination: gu.Ptr(true),
|
|
}
|
|
got := systemFeaturesToCommand(arg)
|
|
assert.Equal(t, want, got)
|
|
}
|
|
|
|
func Test_systemFeaturesToPb(t *testing.T) {
|
|
arg := &query.SystemFeatures{
|
|
Details: &domain.ObjectDetails{
|
|
Sequence: 22,
|
|
EventDate: time.Unix(123, 0),
|
|
ResourceOwner: "SYSTEM",
|
|
},
|
|
LoginDefaultOrg: query.FeatureSource[bool]{
|
|
Level: feature.LevelSystem,
|
|
Value: true,
|
|
},
|
|
TriggerIntrospectionProjections: query.FeatureSource[bool]{
|
|
Level: feature.LevelUnspecified,
|
|
Value: false,
|
|
},
|
|
LegacyIntrospection: query.FeatureSource[bool]{
|
|
Level: feature.LevelSystem,
|
|
Value: true,
|
|
},
|
|
UserSchema: query.FeatureSource[bool]{
|
|
Level: feature.LevelSystem,
|
|
Value: true,
|
|
},
|
|
Actions: query.FeatureSource[bool]{
|
|
Level: feature.LevelSystem,
|
|
Value: true,
|
|
},
|
|
TokenExchange: query.FeatureSource[bool]{
|
|
Level: feature.LevelSystem,
|
|
Value: false,
|
|
},
|
|
ImprovedPerformance: query.FeatureSource[[]feature.ImprovedPerformanceType]{
|
|
Level: feature.LevelSystem,
|
|
Value: []feature.ImprovedPerformanceType{feature.ImprovedPerformanceTypeOrgByID},
|
|
},
|
|
OIDCSingleV1SessionTermination: query.FeatureSource[bool]{
|
|
Level: feature.LevelSystem,
|
|
Value: true,
|
|
},
|
|
EnableBackChannelLogout: query.FeatureSource[bool]{
|
|
Level: feature.LevelSystem,
|
|
Value: true,
|
|
},
|
|
}
|
|
want := &feature_pb.GetSystemFeaturesResponse{
|
|
Details: &object.Details{
|
|
Sequence: 22,
|
|
ChangeDate: ×tamppb.Timestamp{Seconds: 123},
|
|
ResourceOwner: "SYSTEM",
|
|
},
|
|
LoginDefaultOrg: &feature_pb.FeatureFlag{
|
|
Enabled: true,
|
|
Source: feature_pb.Source_SOURCE_SYSTEM,
|
|
},
|
|
OidcTriggerIntrospectionProjections: &feature_pb.FeatureFlag{
|
|
Enabled: false,
|
|
Source: feature_pb.Source_SOURCE_UNSPECIFIED,
|
|
},
|
|
OidcLegacyIntrospection: &feature_pb.FeatureFlag{
|
|
Enabled: true,
|
|
Source: feature_pb.Source_SOURCE_SYSTEM,
|
|
},
|
|
UserSchema: &feature_pb.FeatureFlag{
|
|
Enabled: true,
|
|
Source: feature_pb.Source_SOURCE_SYSTEM,
|
|
},
|
|
OidcTokenExchange: &feature_pb.FeatureFlag{
|
|
Enabled: false,
|
|
Source: feature_pb.Source_SOURCE_SYSTEM,
|
|
},
|
|
Actions: &feature_pb.FeatureFlag{
|
|
Enabled: true,
|
|
Source: feature_pb.Source_SOURCE_SYSTEM,
|
|
},
|
|
ImprovedPerformance: &feature_pb.ImprovedPerformanceFeatureFlag{
|
|
ExecutionPaths: []feature_pb.ImprovedPerformance{feature_pb.ImprovedPerformance_IMPROVED_PERFORMANCE_ORG_BY_ID},
|
|
Source: feature_pb.Source_SOURCE_SYSTEM,
|
|
},
|
|
OidcSingleV1SessionTermination: &feature_pb.FeatureFlag{
|
|
Enabled: true,
|
|
Source: feature_pb.Source_SOURCE_SYSTEM,
|
|
},
|
|
DisableUserTokenEvent: &feature_pb.FeatureFlag{
|
|
Enabled: false,
|
|
Source: feature_pb.Source_SOURCE_UNSPECIFIED,
|
|
},
|
|
EnableBackChannelLogout: &feature_pb.FeatureFlag{
|
|
Enabled: true,
|
|
Source: feature_pb.Source_SOURCE_SYSTEM,
|
|
},
|
|
}
|
|
got := systemFeaturesToPb(arg)
|
|
assert.Equal(t, want, got)
|
|
}
|
|
|
|
func Test_instanceFeaturesToCommand(t *testing.T) {
|
|
arg := &feature_pb.SetInstanceFeaturesRequest{
|
|
LoginDefaultOrg: gu.Ptr(true),
|
|
OidcTriggerIntrospectionProjections: gu.Ptr(false),
|
|
OidcLegacyIntrospection: nil,
|
|
UserSchema: gu.Ptr(true),
|
|
OidcTokenExchange: gu.Ptr(true),
|
|
Actions: gu.Ptr(true),
|
|
ImprovedPerformance: nil,
|
|
WebKey: gu.Ptr(true),
|
|
DebugOidcParentError: gu.Ptr(true),
|
|
OidcSingleV1SessionTermination: gu.Ptr(true),
|
|
EnableBackChannelLogout: gu.Ptr(true),
|
|
}
|
|
want := &command.InstanceFeatures{
|
|
LoginDefaultOrg: gu.Ptr(true),
|
|
TriggerIntrospectionProjections: gu.Ptr(false),
|
|
LegacyIntrospection: nil,
|
|
UserSchema: gu.Ptr(true),
|
|
TokenExchange: gu.Ptr(true),
|
|
Actions: gu.Ptr(true),
|
|
ImprovedPerformance: nil,
|
|
WebKey: gu.Ptr(true),
|
|
DebugOIDCParentError: gu.Ptr(true),
|
|
OIDCSingleV1SessionTermination: gu.Ptr(true),
|
|
EnableBackChannelLogout: gu.Ptr(true),
|
|
}
|
|
got := instanceFeaturesToCommand(arg)
|
|
assert.Equal(t, want, got)
|
|
}
|
|
|
|
func Test_instanceFeaturesToPb(t *testing.T) {
|
|
arg := &query.InstanceFeatures{
|
|
Details: &domain.ObjectDetails{
|
|
Sequence: 22,
|
|
EventDate: time.Unix(123, 0),
|
|
ResourceOwner: "instance1",
|
|
},
|
|
LoginDefaultOrg: query.FeatureSource[bool]{
|
|
Level: feature.LevelSystem,
|
|
Value: true,
|
|
},
|
|
TriggerIntrospectionProjections: query.FeatureSource[bool]{
|
|
Level: feature.LevelUnspecified,
|
|
Value: false,
|
|
},
|
|
LegacyIntrospection: query.FeatureSource[bool]{
|
|
Level: feature.LevelInstance,
|
|
Value: true,
|
|
},
|
|
UserSchema: query.FeatureSource[bool]{
|
|
Level: feature.LevelInstance,
|
|
Value: true,
|
|
},
|
|
Actions: query.FeatureSource[bool]{
|
|
Level: feature.LevelInstance,
|
|
Value: true,
|
|
},
|
|
TokenExchange: query.FeatureSource[bool]{
|
|
Level: feature.LevelSystem,
|
|
Value: false,
|
|
},
|
|
ImprovedPerformance: query.FeatureSource[[]feature.ImprovedPerformanceType]{
|
|
Level: feature.LevelSystem,
|
|
Value: []feature.ImprovedPerformanceType{feature.ImprovedPerformanceTypeOrgByID},
|
|
},
|
|
WebKey: query.FeatureSource[bool]{
|
|
Level: feature.LevelInstance,
|
|
Value: true,
|
|
},
|
|
OIDCSingleV1SessionTermination: query.FeatureSource[bool]{
|
|
Level: feature.LevelInstance,
|
|
Value: true,
|
|
},
|
|
EnableBackChannelLogout: query.FeatureSource[bool]{
|
|
Level: feature.LevelInstance,
|
|
Value: true,
|
|
},
|
|
}
|
|
want := &feature_pb.GetInstanceFeaturesResponse{
|
|
Details: &object.Details{
|
|
Sequence: 22,
|
|
ChangeDate: ×tamppb.Timestamp{Seconds: 123},
|
|
ResourceOwner: "instance1",
|
|
},
|
|
LoginDefaultOrg: &feature_pb.FeatureFlag{
|
|
Enabled: true,
|
|
Source: feature_pb.Source_SOURCE_SYSTEM,
|
|
},
|
|
OidcTriggerIntrospectionProjections: &feature_pb.FeatureFlag{
|
|
Enabled: false,
|
|
Source: feature_pb.Source_SOURCE_UNSPECIFIED,
|
|
},
|
|
OidcLegacyIntrospection: &feature_pb.FeatureFlag{
|
|
Enabled: true,
|
|
Source: feature_pb.Source_SOURCE_INSTANCE,
|
|
},
|
|
UserSchema: &feature_pb.FeatureFlag{
|
|
Enabled: true,
|
|
Source: feature_pb.Source_SOURCE_INSTANCE,
|
|
},
|
|
Actions: &feature_pb.FeatureFlag{
|
|
Enabled: true,
|
|
Source: feature_pb.Source_SOURCE_INSTANCE,
|
|
},
|
|
OidcTokenExchange: &feature_pb.FeatureFlag{
|
|
Enabled: false,
|
|
Source: feature_pb.Source_SOURCE_SYSTEM,
|
|
},
|
|
ImprovedPerformance: &feature_pb.ImprovedPerformanceFeatureFlag{
|
|
ExecutionPaths: []feature_pb.ImprovedPerformance{feature_pb.ImprovedPerformance_IMPROVED_PERFORMANCE_ORG_BY_ID},
|
|
Source: feature_pb.Source_SOURCE_SYSTEM,
|
|
},
|
|
WebKey: &feature_pb.FeatureFlag{
|
|
Enabled: true,
|
|
Source: feature_pb.Source_SOURCE_INSTANCE,
|
|
},
|
|
DebugOidcParentError: &feature_pb.FeatureFlag{
|
|
Enabled: false,
|
|
Source: feature_pb.Source_SOURCE_UNSPECIFIED,
|
|
},
|
|
OidcSingleV1SessionTermination: &feature_pb.FeatureFlag{
|
|
Enabled: true,
|
|
Source: feature_pb.Source_SOURCE_INSTANCE,
|
|
},
|
|
DisableUserTokenEvent: &feature_pb.FeatureFlag{
|
|
Enabled: false,
|
|
Source: feature_pb.Source_SOURCE_UNSPECIFIED,
|
|
},
|
|
EnableBackChannelLogout: &feature_pb.FeatureFlag{
|
|
Enabled: true,
|
|
Source: feature_pb.Source_SOURCE_INSTANCE,
|
|
},
|
|
}
|
|
got := instanceFeaturesToPb(arg)
|
|
assert.Equal(t, want, got)
|
|
}
|
|
|
|
func Test_featureLevelToSourcePb(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
level feature.Level
|
|
want feature_pb.Source
|
|
}{
|
|
{
|
|
name: "unspecified",
|
|
level: feature.LevelUnspecified,
|
|
want: feature_pb.Source_SOURCE_UNSPECIFIED,
|
|
},
|
|
{
|
|
name: "system",
|
|
level: feature.LevelSystem,
|
|
want: feature_pb.Source_SOURCE_SYSTEM,
|
|
},
|
|
{
|
|
name: "instance",
|
|
level: feature.LevelInstance,
|
|
want: feature_pb.Source_SOURCE_INSTANCE,
|
|
},
|
|
{
|
|
name: "org",
|
|
level: feature.LevelOrg,
|
|
want: feature_pb.Source_SOURCE_ORGANIZATION,
|
|
},
|
|
{
|
|
name: "project",
|
|
level: feature.LevelProject,
|
|
want: feature_pb.Source_SOURCE_PROJECT,
|
|
},
|
|
{
|
|
name: "app",
|
|
level: feature.LevelApp,
|
|
want: feature_pb.Source_SOURCE_APP,
|
|
},
|
|
{
|
|
name: "user",
|
|
level: feature.LevelUser,
|
|
want: feature_pb.Source_SOURCE_USER,
|
|
},
|
|
{
|
|
name: "unknown",
|
|
level: 99,
|
|
want: 99,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
got := featureLevelToSourcePb(tt.level)
|
|
assert.Equal(t, tt.want, got)
|
|
})
|
|
}
|
|
}
|