mirror of
https://github.com/zitadel/zitadel.git
synced 2024-12-16 21:08:00 +00:00
63d733b3a2
# Which Problems Are Solved When executing many concurrent authentication requests on a single machine user, there were performance issues. As the same aggregate is being searched and written to concurrently, we traced it down to a locking issue on the used index. We already optimized the token endpoint by creating a separate OIDC aggregate. At the time we decided to push a single event to the user aggregate, for the user audit log. See [technical advisory 10010](https://zitadel.com/docs/support/advisory/a10010) for more details. However, a recent security fix introduced an additional search query on the user aggregate, causing the locking issue we found. # How the Problems Are Solved Add a feature flag which disables pushing of the `user.token.v2.added`. The event has no importance and was only added for informational purposes on the user objects. The `oidc_session.access_token.added` is the actual payload event and is pushed on the OIDC session aggregate and can still be used for audit trail. # Additional Changes - Fix an event mapper type for `SystemOIDCSingleV1SessionTerminationEventType` # Additional Context - Reported by support request - https://github.com/zitadel/zitadel/pull/7822 changed the token aggregate - https://github.com/zitadel/zitadel/pull/8631 introduced user state check Load test trace graph with `user.token.v2.added` **enabled**. Query times are steadily increasing: ![image](https://github.com/user-attachments/assets/4aa25055-8721-4e93-b695-625560979909) Load test trace graph with `user.token.v2.added` **disabled**. Query times constant: ![image](https://github.com/user-attachments/assets/a7657f6c-0c55-401b-8291-453da5d5caf9) --------- Co-authored-by: Livio Spring <livio.a@gmail.com>
154 lines
5.1 KiB
Go
154 lines
5.1 KiB
Go
package projection
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/zitadel/zitadel/internal/eventstore"
|
|
old_handler "github.com/zitadel/zitadel/internal/eventstore/handler"
|
|
"github.com/zitadel/zitadel/internal/eventstore/handler/v2"
|
|
"github.com/zitadel/zitadel/internal/feature"
|
|
feature_v1 "github.com/zitadel/zitadel/internal/repository/feature"
|
|
"github.com/zitadel/zitadel/internal/repository/feature/feature_v2"
|
|
"github.com/zitadel/zitadel/internal/repository/instance"
|
|
"github.com/zitadel/zitadel/internal/zerrors"
|
|
)
|
|
|
|
const (
|
|
InstanceFeatureTable = "projections.instance_features2"
|
|
|
|
InstanceFeatureInstanceIDCol = "instance_id"
|
|
InstanceFeatureKeyCol = "key"
|
|
InstanceFeatureCreationDateCol = "creation_date"
|
|
InstanceFeatureChangeDateCol = "change_date"
|
|
InstanceFeatureSequenceCol = "sequence"
|
|
InstanceFeatureValueCol = "value"
|
|
)
|
|
|
|
type instanceFeatureProjection struct{}
|
|
|
|
func newInstanceFeatureProjection(ctx context.Context, config handler.Config) *handler.Handler {
|
|
return handler.NewHandler(ctx, &config, new(instanceFeatureProjection))
|
|
}
|
|
|
|
func (*instanceFeatureProjection) Name() string {
|
|
return InstanceFeatureTable
|
|
}
|
|
|
|
func (*instanceFeatureProjection) Init() *old_handler.Check {
|
|
return handler.NewTableCheck(handler.NewTable(
|
|
[]*handler.InitColumn{
|
|
handler.NewColumn(InstanceFeatureInstanceIDCol, handler.ColumnTypeText),
|
|
handler.NewColumn(InstanceFeatureKeyCol, handler.ColumnTypeText),
|
|
handler.NewColumn(InstanceFeatureCreationDateCol, handler.ColumnTypeTimestamp),
|
|
handler.NewColumn(InstanceFeatureChangeDateCol, handler.ColumnTypeTimestamp),
|
|
handler.NewColumn(InstanceFeatureSequenceCol, handler.ColumnTypeInt64),
|
|
handler.NewColumn(InstanceFeatureValueCol, handler.ColumnTypeJSONB),
|
|
},
|
|
handler.NewPrimaryKey(InstanceFeatureInstanceIDCol, InstanceFeatureKeyCol),
|
|
))
|
|
}
|
|
|
|
func (*instanceFeatureProjection) Reducers() []handler.AggregateReducer {
|
|
return []handler.AggregateReducer{{
|
|
Aggregate: feature_v2.AggregateType,
|
|
EventReducers: []handler.EventReducer{
|
|
{
|
|
Event: feature_v1.DefaultLoginInstanceEventType,
|
|
Reduce: reduceSetDefaultLoginInstance_v1,
|
|
},
|
|
{
|
|
Event: feature_v2.InstanceResetEventType,
|
|
Reduce: reduceInstanceResetFeatures,
|
|
},
|
|
{
|
|
Event: feature_v2.InstanceLoginDefaultOrgEventType,
|
|
Reduce: reduceInstanceSetFeature[bool],
|
|
},
|
|
{
|
|
Event: feature_v2.InstanceTriggerIntrospectionProjectionsEventType,
|
|
Reduce: reduceInstanceSetFeature[bool],
|
|
},
|
|
{
|
|
Event: feature_v2.InstanceLegacyIntrospectionEventType,
|
|
Reduce: reduceInstanceSetFeature[bool],
|
|
},
|
|
{
|
|
Event: feature_v2.InstanceUserSchemaEventType,
|
|
Reduce: reduceInstanceSetFeature[bool],
|
|
},
|
|
{
|
|
Event: feature_v2.InstanceTokenExchangeEventType,
|
|
Reduce: reduceInstanceSetFeature[bool],
|
|
},
|
|
{
|
|
Event: feature_v2.InstanceActionsEventType,
|
|
Reduce: reduceInstanceSetFeature[bool],
|
|
},
|
|
{
|
|
Event: feature_v2.InstanceImprovedPerformanceEventType,
|
|
Reduce: reduceInstanceSetFeature[[]feature.ImprovedPerformanceType],
|
|
},
|
|
{
|
|
Event: feature_v2.InstanceWebKeyEventType,
|
|
Reduce: reduceInstanceSetFeature[bool],
|
|
},
|
|
{
|
|
Event: feature_v2.InstanceDebugOIDCParentErrorEventType,
|
|
Reduce: reduceInstanceSetFeature[bool],
|
|
},
|
|
{
|
|
Event: feature_v2.InstanceOIDCSingleV1SessionTerminationEventType,
|
|
Reduce: reduceInstanceSetFeature[bool],
|
|
},
|
|
{
|
|
Event: feature_v2.InstanceDisableUserTokenEvent,
|
|
Reduce: reduceInstanceSetFeature[bool],
|
|
},
|
|
{
|
|
Event: instance.InstanceRemovedEventType,
|
|
Reduce: reduceInstanceRemovedHelper(InstanceDomainInstanceIDCol),
|
|
},
|
|
},
|
|
}}
|
|
}
|
|
|
|
func reduceSetDefaultLoginInstance_v1(event eventstore.Event) (*handler.Statement, error) {
|
|
e, ok := event.(*feature_v1.SetEvent[feature_v1.Boolean])
|
|
if !ok {
|
|
return nil, zerrors.ThrowInvalidArgumentf(nil, "PROJE-in2Xo", "reduce.wrong.event.type %T", event)
|
|
}
|
|
return reduceInstanceSetFeature[bool](
|
|
feature_v1.DefaultLoginInstanceEventToV2(e),
|
|
)
|
|
}
|
|
|
|
func reduceInstanceSetFeature[T any](event eventstore.Event) (*handler.Statement, error) {
|
|
e, ok := event.(*feature_v2.SetEvent[T])
|
|
if !ok {
|
|
return nil, zerrors.ThrowInvalidArgumentf(nil, "PROJE-uPh8O", "reduce.wrong.event.type %T", event)
|
|
}
|
|
f, err := e.FeatureJSON()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
columns := []handler.Column{
|
|
handler.NewCol(InstanceFeatureInstanceIDCol, e.Aggregate().ID),
|
|
handler.NewCol(InstanceFeatureKeyCol, f.Key.String()),
|
|
handler.NewCol(InstanceFeatureCreationDateCol, handler.OnlySetValueOnInsert(InstanceFeatureTable, e.CreationDate())),
|
|
handler.NewCol(InstanceFeatureChangeDateCol, e.CreationDate()),
|
|
handler.NewCol(InstanceFeatureSequenceCol, e.Sequence()),
|
|
handler.NewCol(InstanceFeatureValueCol, f.Value),
|
|
}
|
|
return handler.NewUpsertStatement(e, columns[0:2], columns), nil
|
|
}
|
|
|
|
func reduceInstanceResetFeatures(event eventstore.Event) (*handler.Statement, error) {
|
|
e, ok := event.(*feature_v2.ResetEvent)
|
|
if !ok {
|
|
return nil, zerrors.ThrowInvalidArgumentf(nil, "PROJE-roo6A", "reduce.wrong.event.type %T", event)
|
|
}
|
|
return handler.NewDeleteStatement(e, []handler.Condition{
|
|
handler.NewCond(InstanceFeatureInstanceIDCol, e.Aggregate().ID),
|
|
}), nil
|
|
}
|