mirror of
https://github.com/zitadel/zitadel.git
synced 2025-12-07 15:22:32 +00:00
b10455b51f
# Which Problems Are Solved - The previous monorepo in monorepo structure for the login app and its related packages was fragmented, complicated and buggy. - The process for building and testing the login container was inconsistent between local development and CI. - Lack of clear documentation as well as easy and reliable ways for non-frontend developers to reproduce and fix failing PR checks locally. # How the Problems Are Solved - Consolidated the login app and its related npm packages by moving the main package to `apps/login/apps/login` and merging `apps/login/packages/integration` and `apps/login/packages/acceptance` into the main `apps/login` package. - Migrated from Docker Compose-based test setups to dev container-based setups, adding support for multiple dev container configurations: - `.devcontainer/base` - `.devcontainer/turbo-lint-unit` - `.devcontainer/turbo-lint-unit-debug` - `.devcontainer/login-integration` - `.devcontainer/login-integration-debug` - Added npm scripts to run the new dev container setups, enabling exact reproduction of GitHub PR checks locally, and updated the pipeline to use these containers. - Cleaned up Dockerfiles and docker-bake.hcl files to only build the production image for the login app. - Cleaned up compose files to focus on dev environments in dev containers. - Updated `CONTRIBUTING.md` with guidance on running and debugging PR checks locally using the new dev container approach. - Introduced separate Dockerfiles for the login app to distinguish between using published client packages and building clients from local protos. - Ensured the login container is always built in the pipeline for use in integration and acceptance tests. - Updated Makefile and GitHub Actions workflows to use `--frozen-lockfile` for installing pnpm packages, ensuring reproducible installs. - Disabled GitHub release creation by the changeset action. - Refactored the `/build` directory structure for clarity and maintainability. - Added a `clean` command to `docks/package.json`. - Experimentally added `knip` to the `zitadel-client` package for improved linting of dependencies and exports. # Additional Changes - Fixed Makefile commands for consistency and reliability. - Improved the structure and clarity of the `/build` directory to support seamless integration of the login build. - Enhanced documentation and developer experience for running and debugging CI checks locally. # Additional Context - See updated `CONTRIBUTING.md` for new local development and debugging instructions. - These changes are a prerequisite for further improvements to the CI pipeline and local development workflow. - Closes #10276
26 lines
692 B
HCL
26 lines
692 B
HCL
variable "LOGIN_TAG" {
|
|
default = "zitadel-login:local"
|
|
}
|
|
|
|
group "default" {
|
|
targets = ["login-standalone"]
|
|
}
|
|
|
|
# The release target is overwritten in docker-bake-release.hcl
|
|
# It makes sure the image is built for multiple platforms.
|
|
# By default the platforms property is empty, so images are only built for the current bake runtime platform.
|
|
target "release" {}
|
|
|
|
target "docker-metadata-action" {
|
|
# In the pipeline, this target is overwritten by the docker metadata action.
|
|
tags = ["${LOGIN_TAG}"]
|
|
}
|
|
|
|
# We run integration and acceptance tests against the next standalone server for docker.
|
|
target "login-standalone" {
|
|
inherits = [
|
|
"docker-metadata-action",
|
|
"release",
|
|
]
|
|
}
|