mirror of
https://github.com/zitadel/zitadel.git
synced 2024-12-16 04:48:04 +00:00
9c3e5e467b
# Which Problems Are Solved Queries currently execute 3 statements, begin, query, commit # How the Problems Are Solved remove transaction handling from query methods in database package # Additional Changes - Bump versions of `core_grpc_dependencies`-receipt in Makefile # Additional info During load tests we saw a lot of idle transactions of `zitadel_queries` application name which is the connection pool used to query data in zitadel. Executed query: `select query_start - xact_start, pid, application_name, backend_start, xact_start, query_start, state_change, wait_event_type, wait_event,substring(query, 1, 200) query from pg_stat_activity where datname = 'zitadel' and state <> 'idle';` Mostly the last query executed was `begin isolation level read committed read only`. example: ``` ?column? | pid | application_name | backend_start | xact_start | query_start | state_change | wait_event_type | wait_event | query -----------------+-------+----------------------------+-------------------------------+-------------------------------+-------------------------------+-------------------------------+-----------------+--------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 00:00:00 | 33030 | zitadel_queries | 2024-10-16 16:25:53.906036+00 | 2024-10-16 16:30:19.191661+00 | 2024-10-16 16:30:19.191661+00 | 2024-10-16 16:30:19.19169+00 | Client | ClientRead | begin isolation level read committed read only 00:00:00 | 33035 | zitadel_queries | 2024-10-16 16:25:53.909629+00 | 2024-10-16 16:30:19.19179+00 | 2024-10-16 16:30:19.19179+00 | 2024-10-16 16:30:19.191805+00 | Client | ClientRead | begin isolation level read committed read only 00:00:00.00412 | 33028 | zitadel_queries | 2024-10-16 16:25:53.904247+00 | 2024-10-16 16:30:19.187734+00 | 2024-10-16 16:30:19.191854+00 | 2024-10-16 16:30:19.191964+00 | Client | ClientRead | SELECT created_at, event_type, "sequence", "position", payload, creator, "owner", instance_id, aggregate_type, aggregate_id, revision FROM eventstore.events2 WHERE instance_id = $1 AND aggregate_type 00:00:00.084662 | 33134 | zitadel_es_pusher | 2024-10-16 16:29:54.979692+00 | 2024-10-16 16:30:19.178578+00 | 2024-10-16 16:30:19.26324+00 | 2024-10-16 16:30:19.263267+00 | Client | ClientRead | RELEASE SAVEPOINT cockroach_restart 00:00:00.084768 | 33139 | zitadel_es_pusher | 2024-10-16 16:29:54.979585+00 | 2024-10-16 16:30:19.180762+00 | 2024-10-16 16:30:19.26553+00 | 2024-10-16 16:30:19.265531+00 | LWLock | WALWriteLock | commit 00:00:00.077377 | 33136 | zitadel_es_pusher | 2024-10-16 16:29:54.978582+00 | 2024-10-16 16:30:19.187883+00 | 2024-10-16 16:30:19.26526+00 | 2024-10-16 16:30:19.265431+00 | Client | ClientRead | WITH existing AS ( + | | | | | | | | | (SELECT instance_id, aggregate_type, aggregate_id, "sequence" FROM eventstore.events2 WHERE instance_id = $1 AND aggregate_type = $2 AND aggregate_id = $3 ORDER BY "sequence" DE 00:00:00.012309 | 33123 | zitadel_es_pusher | 2024-10-16 16:29:54.963484+00 | 2024-10-16 16:30:19.175066+00 | 2024-10-16 16:30:19.187375+00 | 2024-10-16 16:30:19.187376+00 | IO | WalSync | commit 00:00:00 | 33034 | zitadel_queries | 2024-10-16 16:25:53.90791+00 | 2024-10-16 16:30:19.262921+00 | 2024-10-16 16:30:19.262921+00 | 2024-10-16 16:30:19.263133+00 | Client | ClientRead | begin isolation level read committed read only 00:00:00 | 33039 | zitadel_queries | 2024-10-16 16:25:53.914106+00 | 2024-10-16 16:30:19.191676+00 | 2024-10-16 16:30:19.191676+00 | 2024-10-16 16:30:19.191687+00 | Client | ClientRead | begin isolation level read committed read only 00:00:00.24539 | 33083 | zitadel_projection_spooler | 2024-10-16 16:27:49.895548+00 | 2024-10-16 16:30:19.020058+00 | 2024-10-16 16:30:19.265448+00 | 2024-10-16 16:30:19.26546+00 | Client | ClientRead | SAVEPOINT exec_stmt 00:00:00 | 33125 | zitadel_es_pusher | 2024-10-16 16:29:54.963859+00 | 2024-10-16 16:30:19.191715+00 | 2024-10-16 16:30:19.191715+00 | 2024-10-16 16:30:19.191729+00 | Client | ClientRead | begin 00:00:00.004292 | 33032 | zitadel_queries | 2024-10-16 16:25:53.906624+00 | 2024-10-16 16:30:19.187713+00 | 2024-10-16 16:30:19.192005+00 | 2024-10-16 16:30:19.192062+00 | Client | ClientRead | SELECT created_at, event_type, "sequence", "position", payload, creator, "owner", instance_id, aggregate_type, aggregate_id, revision FROM eventstore.events2 WHERE instance_id = $1 AND aggregate_type 00:00:00 | 33031 | zitadel_queries | 2024-10-16 16:25:53.906422+00 | 2024-10-16 16:30:19.191625+00 | 2024-10-16 16:30:19.191625+00 | 2024-10-16 16:30:19.191645+00 | Client | ClientRead | begin isolation level read committed read only ``` The amount of idle transactions is significantly less if the query transactions are removed: example: ``` ?column? | pid | application_name | backend_start | xact_start | query_start | state_change | wait_event_type | wait_event | query -----------------+-------+----------------------------+-------------------------------+-------------------------------+-------------------------------+-------------------------------+-----------------+------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 00:00:00.000094 | 32741 | zitadel_queries | 2024-10-16 16:23:49.73935+00 | 2024-10-16 16:24:59.785589+00 | 2024-10-16 16:24:59.785683+00 | 2024-10-16 16:24:59.785684+00 | | | SELECT created_at, event_type, "sequence", "position", payload, creator, "owner", instance_id, aggregate_type, aggregate_id, revision FROM eventstore.events2 WHERE instance_id = $1 AND aggregate_type 00:00:00 | 32762 | zitadel_es_pusher | 2024-10-16 16:24:02.275136+00 | 2024-10-16 16:24:59.784586+00 | 2024-10-16 16:24:59.784586+00 | 2024-10-16 16:24:59.784607+00 | Client | ClientRead | begin 00:00:00.000167 | 32742 | zitadel_queries | 2024-10-16 16:23:49.740489+00 | 2024-10-16 16:24:59.784274+00 | 2024-10-16 16:24:59.784441+00 | 2024-10-16 16:24:59.784442+00 | | | with usr as ( + | | | | | | | | | select u.id, u.creation_date, u.change_date, u.sequence, u.state, u.resource_owner, u.username, n.login_name as preferred_login_name + | | | | | | | | | from projections.users13 u + | | | | | | | | | left join projections.l 00:00:00.256014 | 32759 | zitadel_projection_spooler | 2024-10-16 16:24:01.418429+00 | 2024-10-16 16:24:59.52959+00 | 2024-10-16 16:24:59.785604+00 | 2024-10-16 16:24:59.785649+00 | Client | ClientRead | UPDATE projections.milestones SET reached_date = $1 WHERE (instance_id = $2) AND (type = $3) AND (reached_date IS NULL) 00:00:00.014199 | 32773 | zitadel_es_pusher | 2024-10-16 16:24:02.320404+00 | 2024-10-16 16:24:59.769509+00 | 2024-10-16 16:24:59.783708+00 | 2024-10-16 16:24:59.783709+00 | IO | WalSync | commit 00:00:00 | 32765 | zitadel_es_pusher | 2024-10-16 16:24:02.28173+00 | 2024-10-16 16:24:59.780413+00 | 2024-10-16 16:24:59.780413+00 | 2024-10-16 16:24:59.780426+00 | Client | ClientRead | begin 00:00:00.012729 | 32777 | zitadel_es_pusher | 2024-10-16 16:24:02.339737+00 | 2024-10-16 16:24:59.767432+00 | 2024-10-16 16:24:59.780161+00 | 2024-10-16 16:24:59.780195+00 | Client | ClientRead | RELEASE SAVEPOINT cockroach_restart ``` --------- Co-authored-by: Tim Möhlmann <tim+github@zitadel.com> Co-authored-by: Livio Spring <livio.a@gmail.com> Co-authored-by: Max Peintner <max@caos.ch> Co-authored-by: Elio Bischof <elio@zitadel.com> Co-authored-by: Stefan Benz <46600784+stebenz@users.noreply.github.com> Co-authored-by: Miguel Cabrerizo <30386061+doncicuto@users.noreply.github.com> Co-authored-by: Joakim Lodén <Loddan@users.noreply.github.com> Co-authored-by: Yxnt <Yxnt@users.noreply.github.com> Co-authored-by: Stefan Benz <stefan@caos.ch> Co-authored-by: Harsha Reddy <harsha.reddy@klaviyo.com> Co-authored-by: Zach H <zhirschtritt@gmail.com>
143 lines
4.6 KiB
Go
143 lines
4.6 KiB
Go
package repository
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/jinzhu/gorm"
|
|
|
|
"github.com/zitadel/zitadel/internal/database"
|
|
"github.com/zitadel/zitadel/internal/domain"
|
|
"github.com/zitadel/zitadel/internal/zerrors"
|
|
)
|
|
|
|
type SearchRequest interface {
|
|
GetLimit() uint64
|
|
GetOffset() uint64
|
|
GetSortingColumn() ColumnKey
|
|
GetAsc() bool
|
|
GetQueries() []SearchQuery
|
|
}
|
|
|
|
type SearchQuery interface {
|
|
GetKey() ColumnKey
|
|
GetMethod() domain.SearchMethod
|
|
GetValue() interface{}
|
|
}
|
|
|
|
type ColumnKey interface {
|
|
ToColumnName() string
|
|
}
|
|
|
|
func PrepareSearchQuery(table string, request SearchRequest) func(db *gorm.DB, res interface{}) (uint64, error) {
|
|
return func(db *gorm.DB, res interface{}) (uint64, error) {
|
|
var count uint64 = 0
|
|
query := db.Table(table)
|
|
if column := request.GetSortingColumn(); column != nil {
|
|
order := "DESC"
|
|
if request.GetAsc() {
|
|
order = "ASC"
|
|
}
|
|
query = query.Order(fmt.Sprintf("%s %s", column.ToColumnName(), order))
|
|
}
|
|
|
|
for _, q := range request.GetQueries() {
|
|
var err error
|
|
query, err = SetQuery(query, q.GetKey(), q.GetValue(), q.GetMethod())
|
|
if err != nil {
|
|
return count, zerrors.ThrowInvalidArgument(err, "VIEW-KaGue", "query is invalid")
|
|
}
|
|
}
|
|
|
|
query = query.Count(&count)
|
|
if res == nil {
|
|
return count, nil
|
|
}
|
|
if request.GetLimit() != 0 {
|
|
query = query.Limit(request.GetLimit())
|
|
}
|
|
query = query.Offset(request.GetOffset())
|
|
err := query.Find(res).Error
|
|
if err != nil {
|
|
return count, zerrors.ThrowInternal(err, "VIEW-muSDK", "unable to find result")
|
|
}
|
|
return count, nil
|
|
}
|
|
}
|
|
|
|
func SetQuery(query *gorm.DB, key ColumnKey, value interface{}, method domain.SearchMethod) (*gorm.DB, error) {
|
|
column := key.ToColumnName()
|
|
if column == "" {
|
|
return nil, zerrors.ThrowInvalidArgument(nil, "VIEW-7dz3w", "Column name missing")
|
|
}
|
|
|
|
switch method {
|
|
case domain.SearchMethodEquals:
|
|
query = query.Where(""+column+" = ?", value)
|
|
case domain.SearchMethodEqualsIgnoreCase:
|
|
valueText, ok := value.(string)
|
|
if !ok {
|
|
return nil, zerrors.ThrowInvalidArgument(nil, "VIEW-idu8e", "Equal ignore case only possible for strings")
|
|
}
|
|
query = query.Where("LOWER("+column+") = LOWER(?)", valueText)
|
|
case domain.SearchMethodStartsWith:
|
|
valueText, ok := value.(string)
|
|
if !ok {
|
|
return nil, zerrors.ThrowInvalidArgument(nil, "VIEW-SLj7s", "Starts with only possible for strings")
|
|
}
|
|
valueText = database.EscapeLikeWildcards(valueText)
|
|
query = query.Where(column+" LIKE ?", valueText+"%")
|
|
case domain.SearchMethodStartsWithIgnoreCase:
|
|
valueText, ok := value.(string)
|
|
if !ok {
|
|
return nil, zerrors.ThrowInvalidArgument(nil, "VIEW-eidus", "Starts with ignore case only possible for strings")
|
|
}
|
|
valueText = database.EscapeLikeWildcards(valueText)
|
|
query = query.Where("LOWER("+column+") LIKE LOWER(?)", valueText+"%")
|
|
case domain.SearchMethodEndsWith:
|
|
valueText, ok := value.(string)
|
|
if !ok {
|
|
return nil, zerrors.ThrowInvalidArgument(nil, "VIEW-Hswd3", "Ends with only possible for strings")
|
|
}
|
|
valueText = database.EscapeLikeWildcards(valueText)
|
|
query = query.Where(column+" LIKE ?", "%"+valueText)
|
|
case domain.SearchMethodEndsWithIgnoreCase:
|
|
valueText, ok := value.(string)
|
|
if !ok {
|
|
return nil, zerrors.ThrowInvalidArgument(nil, "VIEW-dAG31", "Ends with ignore case only possible for strings")
|
|
}
|
|
valueText = database.EscapeLikeWildcards(valueText)
|
|
query = query.Where("LOWER("+column+") LIKE LOWER(?)", "%"+valueText)
|
|
case domain.SearchMethodContains:
|
|
valueText, ok := value.(string)
|
|
if !ok {
|
|
return nil, zerrors.ThrowInvalidArgument(nil, "VIEW-3ids", "Contains with only possible for strings")
|
|
}
|
|
valueText = database.EscapeLikeWildcards(valueText)
|
|
query = query.Where(column+" LIKE ?", "%"+valueText+"%")
|
|
case domain.SearchMethodContainsIgnoreCase:
|
|
valueText, ok := value.(string)
|
|
if !ok {
|
|
return nil, zerrors.ThrowInvalidArgument(nil, "VIEW-eid73", "Contains with ignore case only possible for strings")
|
|
}
|
|
valueText = database.EscapeLikeWildcards(valueText)
|
|
query = query.Where("LOWER("+column+") LIKE LOWER(?)", "%"+valueText+"%")
|
|
case domain.SearchMethodNotEquals:
|
|
query = query.Where(""+column+" <> ?", value)
|
|
case domain.SearchMethodGreaterThan:
|
|
query = query.Where(column+" > ?", value)
|
|
case domain.SearchMethodLessThan:
|
|
query = query.Where(column+" < ?", value)
|
|
case domain.SearchMethodIsOneOf:
|
|
query = query.Where(column+" IN (?)", value)
|
|
case domain.SearchMethodListContains:
|
|
valueText, ok := value.(string)
|
|
if !ok {
|
|
return nil, zerrors.ThrowInvalidArgument(nil, "VIEW-Psois", "list contains only possible for strings")
|
|
}
|
|
query = query.Where("? <@ "+column, database.TextArray[string]{valueText})
|
|
default:
|
|
return nil, nil
|
|
}
|
|
return query, nil
|
|
}
|